New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 592005 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocking:
issue 249382



Sign in to add a comment

Add ColorspaceConversion in ImageBitmapOptions

Project Member Reported by xidac...@chromium.org, Mar 4 2016

Issue description

According to the spec here:
https://html.spec.whatwg.org/#imagebitmapoptions

The ImageBitmapOptions has a ColorspaceConversion member, this should be supported.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e71ee33752db1b8817870cc25324ae40dbcd6d3

commit 1e71ee33752db1b8817870cc25324ae40dbcd6d3
Author: xidachen <xidachen@chromium.org>
Date: Tue Mar 15 14:51:22 2016

Add ColorspaceConversion in ImageBitmapOptions

This option is specifically for createImageBitmap from a Blob or a
HTMLImageElement. This CL adds support for this option, starting with
Blob. Layout tests are added to ensure the correctness.

BUG= 592005 

Review URL: https://codereview.chromium.org/1763043002

Cr-Commit-Position: refs/heads/master@{#381224}

[add] https://crrev.com/1e71ee33752db1b8817870cc25324ae40dbcd6d3/third_party/WebKit/LayoutTests/fast/canvas/webgl/resources/square-with-colorspin-profile.png
[modify] https://crrev.com/1e71ee33752db1b8817870cc25324ae40dbcd6d3/third_party/WebKit/LayoutTests/fast/canvas/webgl/resources/tex-image-and-sub-image-image-bitmap-utils.js
[modify] https://crrev.com/1e71ee33752db1b8817870cc25324ae40dbcd6d3/third_party/WebKit/LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-image-bitmap-from-blob.html
[modify] https://crrev.com/1e71ee33752db1b8817870cc25324ae40dbcd6d3/third_party/WebKit/LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-image-bitmap-from-canvas.html
[modify] https://crrev.com/1e71ee33752db1b8817870cc25324ae40dbcd6d3/third_party/WebKit/LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-image-bitmap-from-image-bitmap.html
[modify] https://crrev.com/1e71ee33752db1b8817870cc25324ae40dbcd6d3/third_party/WebKit/LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-image-bitmap-from-image-data.html
[modify] https://crrev.com/1e71ee33752db1b8817870cc25324ae40dbcd6d3/third_party/WebKit/LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-image-bitmap-from-image.html
[modify] https://crrev.com/1e71ee33752db1b8817870cc25324ae40dbcd6d3/third_party/WebKit/LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-image-bitmap-from-video.html
[modify] https://crrev.com/1e71ee33752db1b8817870cc25324ae40dbcd6d3/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp
[modify] https://crrev.com/1e71ee33752db1b8817870cc25324ae40dbcd6d3/third_party/WebKit/Source/core/imagebitmap/ImageBitmapOptions.idl

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/514c171c54f89d92c33e454b410fcd404039880e

commit 514c171c54f89d92c33e454b410fcd404039880e
Author: xidachen <xidachen@chromium.org>
Date: Mon Apr 11 19:53:21 2016

Add ColorspaceConversion to createImageBitmap(HTMLImageElement)

The ColorspaceConversion option has been added to createImageBitmap(Blob)
and the corresponding layout test has been added too.

This CL adds this option to createImageBitmap(HTMLImageElement) and also
modify an existing layout test so that this option is effective.

BUG= 592005 

Review URL: https://codereview.chromium.org/1843953003

Cr-Commit-Position: refs/heads/master@{#386446}

[modify] https://crrev.com/514c171c54f89d92c33e454b410fcd404039880e/third_party/WebKit/LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-image-bitmap-from-image.html
[modify] https://crrev.com/514c171c54f89d92c33e454b410fcd404039880e/third_party/WebKit/Source/core/frame/ImageBitmap.cpp

Status: Fixed (was: Started)

Sign in to add a comment