SuggestionsService should implement SyncServiceObserver, to respond to changes in the sync state by itself rather than relying on clients to pass in the correct state.
Status: Complete; waiting for one last (rubber stamp) lgtm to land.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16070ce69cfb26481240995705c8a1a206fd829c commit 16070ce69cfb26481240995705c8a1a206fd829c Author: treib <treib@chromium.org> Date: Fri Mar 11 11:57:40 2016 SuggestionsService: implement SyncServiceObserver so that its clients don't have to. Also remove a bunch of null checks on SuggestionsService - SuggestionsServiceFactory::GetForProfile will never return null. BUG= 591973 Review URL: https://codereview.chromium.org/1770843002 Cr-Commit-Position: refs/heads/master@{#380603} [modify] https://crrev.com/16070ce69cfb26481240995705c8a1a206fd829c/chrome/browser/android/most_visited_sites.cc [modify] https://crrev.com/16070ce69cfb26481240995705c8a1a206fd829c/chrome/browser/android/most_visited_sites.h [modify] https://crrev.com/16070ce69cfb26481240995705c8a1a206fd829c/chrome/browser/extensions/api/preferences_private/preferences_private_apitest.cc [modify] https://crrev.com/16070ce69cfb26481240995705c8a1a206fd829c/chrome/browser/search/instant_service.cc [modify] https://crrev.com/16070ce69cfb26481240995705c8a1a206fd829c/chrome/browser/search/instant_service.h [modify] https://crrev.com/16070ce69cfb26481240995705c8a1a206fd829c/chrome/browser/search/instant_service_factory.cc [modify] https://crrev.com/16070ce69cfb26481240995705c8a1a206fd829c/chrome/browser/search/suggestions/suggestions_service_factory.cc [modify] https://crrev.com/16070ce69cfb26481240995705c8a1a206fd829c/chrome/browser/search/suggestions/suggestions_source.cc [delete] https://crrev.com/52643c06c9af36fdb16113e104bd6771324fcd61/chrome/browser/search/suggestions/suggestions_utils.cc [delete] https://crrev.com/52643c06c9af36fdb16113e104bd6771324fcd61/chrome/browser/search/suggestions/suggestions_utils.h [modify] https://crrev.com/16070ce69cfb26481240995705c8a1a206fd829c/chrome/browser/ui/app_list/search/suggestions/suggestions_search_provider.cc [modify] https://crrev.com/16070ce69cfb26481240995705c8a1a206fd829c/chrome/chrome_browser.gypi [modify] https://crrev.com/16070ce69cfb26481240995705c8a1a206fd829c/components/suggestions.gypi [modify] https://crrev.com/16070ce69cfb26481240995705c8a1a206fd829c/components/suggestions/BUILD.gn [modify] https://crrev.com/16070ce69cfb26481240995705c8a1a206fd829c/components/suggestions/DEPS [modify] https://crrev.com/16070ce69cfb26481240995705c8a1a206fd829c/components/suggestions/suggestions_service.cc [modify] https://crrev.com/16070ce69cfb26481240995705c8a1a206fd829c/components/suggestions/suggestions_service.h [modify] https://crrev.com/16070ce69cfb26481240995705c8a1a206fd829c/components/suggestions/suggestions_service_unittest.cc [delete] https://crrev.com/52643c06c9af36fdb16113e104bd6771324fcd61/components/suggestions/suggestions_utils.cc [delete] https://crrev.com/52643c06c9af36fdb16113e104bd6771324fcd61/components/suggestions/suggestions_utils.h [modify] https://crrev.com/16070ce69cfb26481240995705c8a1a206fd829c/ios/chrome/browser/suggestions/suggestions_service_factory.mm
Comment 1 by treib@chromium.org
, Mar 4 2016