New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 591958 link

Starred by 9 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocked on:
issue 622111

Blocking:
issue 618933



Sign in to add a comment

Storage management UI for Chrome OS

Project Member Reported by fukino@chromium.org, Mar 4 2016

Issue description

It will be convenient if we have a storage management tool that allows users to see what consume the disk space and purge the data as needed. 

Chrome OS is designed to be stateless and basically users do not have to take care of the usage of the storage.
However, there are many ways to consume the disk space.
- Web sites can use the storage for cache, persistent data, etc...
- Chrome extensions, app, and other types of apps can store data to the storage.
- Users can store data in Downloads and expect it as persistent.
- Googe Drive integration in Files app uses storage for Drive's offline cache.
- etc...
Running out of storage can be a cause of some unwanted results. For example, profiles can be deleted.

The OS should be / can be smarter to handle most situations, but in some cases, user's explicit intention will be desired to purge the data.
Some kind of data (e.g. Web site caches) provides a way to purge it, but it can take many steps to do, and different ways for different types of data will not be a friendly solution.

A management tool for Chrome OS storage will be convenient for users who are running out of space.

 
Cc: hirono@chromium.org fukino@chromium.org
 Issue 586992  has been merged into this issue.
Labels: -Type-Bug Type-Feature
Agreed, thank you for the suggestion. I'm actually in the process of discussing this with other folks, so please feel free to assign this to me. 

I think a thoughtful UI will be necessary for this to be successful (i.e. clearly displaying what's taking up space, what can be purged). Let me gather some data and put a product doc together. 
Owner: mitsuji@chromium.org
Thank you!
Assigning this to Hiro for UI work.
I'll continue to investigate technical details.
Frequent questions in CBC forum regarding this issue.
#CBC-RS/TC-watchlist

Comment 6 by fukino@chromium.org, Apr 22 2016

Labels: -Pri-3 Pri-1
Owner: fukino@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, May 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0063cf80ae18f025807016c41f17462d51bee872

commit 0063cf80ae18f025807016c41f17462d51bee872
Author: fukino <fukino@chromium.org>
Date: Thu May 26 06:56:36 2016

Add storage manager overlay on Settings.

This CL adds a button for storage manager overlay in Setting page's device section.
The button is shown only when the flag --enable-storage-manager is specified.
The content of the overlay is empty for now.
I'm going to add functions on top of it.

BUG= 591958 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2009543002
Cr-Commit-Position: refs/heads/master@{#396136}

[modify] https://crrev.com/0063cf80ae18f025807016c41f17462d51bee872/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/0063cf80ae18f025807016c41f17462d51bee872/chrome/browser/about_flags.cc
[modify] https://crrev.com/0063cf80ae18f025807016c41f17462d51bee872/chrome/browser/resources/options/browser_options.html
[modify] https://crrev.com/0063cf80ae18f025807016c41f17462d51bee872/chrome/browser/resources/options/browser_options.js
[add] https://crrev.com/0063cf80ae18f025807016c41f17462d51bee872/chrome/browser/resources/options/chromeos/storage_manager.css
[add] https://crrev.com/0063cf80ae18f025807016c41f17462d51bee872/chrome/browser/resources/options/chromeos/storage_manager.html
[add] https://crrev.com/0063cf80ae18f025807016c41f17462d51bee872/chrome/browser/resources/options/chromeos/storage_manager.js
[modify] https://crrev.com/0063cf80ae18f025807016c41f17462d51bee872/chrome/browser/resources/options/options.html
[modify] https://crrev.com/0063cf80ae18f025807016c41f17462d51bee872/chrome/browser/resources/options/options.js
[modify] https://crrev.com/0063cf80ae18f025807016c41f17462d51bee872/chrome/browser/resources/options/options_bundle.js
[modify] https://crrev.com/0063cf80ae18f025807016c41f17462d51bee872/chrome/browser/ui/webui/options/browser_options_handler.cc
[add] https://crrev.com/0063cf80ae18f025807016c41f17462d51bee872/chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc
[add] https://crrev.com/0063cf80ae18f025807016c41f17462d51bee872/chrome/browser/ui/webui/options/chromeos/storage_manager_handler.h
[modify] https://crrev.com/0063cf80ae18f025807016c41f17462d51bee872/chrome/browser/ui/webui/options/options_ui.cc
[modify] https://crrev.com/0063cf80ae18f025807016c41f17462d51bee872/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/0063cf80ae18f025807016c41f17462d51bee872/chromeos/chromeos_switches.cc
[modify] https://crrev.com/0063cf80ae18f025807016c41f17462d51bee872/chromeos/chromeos_switches.h
[modify] https://crrev.com/0063cf80ae18f025807016c41f17462d51bee872/tools/metrics/histograms/histograms.xml

Project Member

Comment 8 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6380c07c5be816838aa3e8027d32b1cc2404c9c9

commit 6380c07c5be816838aa3e8027d32b1cc2404c9c9
Author: fukino <fukino@chromium.org>
Date: Thu Jun 09 07:28:29 2016

Add an API to get total size of Drive cache including non-evictable ones.

The API is needed to show the total size of Drive cache in storage manager.
This CL also changes the type of cache size to int64_t, to be consistent with functions under base/files.

BUG= 591958 
TEST=manually

Review-Url: https://codereview.chromium.org/2048993002
Cr-Commit-Position: refs/heads/master@{#398805}

[modify] https://crrev.com/6380c07c5be816838aa3e8027d32b1cc2404c9c9/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
[modify] https://crrev.com/6380c07c5be816838aa3e8027d32b1cc2404c9c9/components/drive/chromeos/dummy_file_system.h
[modify] https://crrev.com/6380c07c5be816838aa3e8027d32b1cc2404c9c9/components/drive/chromeos/fake_file_system.cc
[modify] https://crrev.com/6380c07c5be816838aa3e8027d32b1cc2404c9c9/components/drive/chromeos/fake_file_system.h
[modify] https://crrev.com/6380c07c5be816838aa3e8027d32b1cc2404c9c9/components/drive/chromeos/file_cache.cc
[modify] https://crrev.com/6380c07c5be816838aa3e8027d32b1cc2404c9c9/components/drive/chromeos/file_cache.h
[modify] https://crrev.com/6380c07c5be816838aa3e8027d32b1cc2404c9c9/components/drive/chromeos/file_system.cc
[modify] https://crrev.com/6380c07c5be816838aa3e8027d32b1cc2404c9c9/components/drive/chromeos/file_system.h
[modify] https://crrev.com/6380c07c5be816838aa3e8027d32b1cc2404c9c9/components/drive/chromeos/file_system_interface.h

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/205d6d81b48dc72872c07c0f56bdd730129e60a1

commit 205d6d81b48dc72872c07c0f56bdd730129e60a1
Author: fukino <fukino@chromium.org>
Date: Fri Jun 10 00:42:13 2016

Storage manager: Show overall size information and size of Downloads.

On the storage manager overlay, this CL adds following functions.
- Shows overall storage information(total/used/available) using statvfs() on the local volume.
- Shows size of Downloads directory by computing directory size recursively.
- Opens up Files app when the label "Downloads" is clicked.
The layout inside the overlay is tentative.

BUG= 591958 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
TEST=manually by flag #enable-storage-manager enabled.

Review-Url: https://codereview.chromium.org/2041343002
Cr-Commit-Position: refs/heads/master@{#399057}

[modify] https://crrev.com/205d6d81b48dc72872c07c0f56bdd730129e60a1/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/205d6d81b48dc72872c07c0f56bdd730129e60a1/chrome/browser/resources/options/chromeos/storage_manager.css
[modify] https://crrev.com/205d6d81b48dc72872c07c0f56bdd730129e60a1/chrome/browser/resources/options/chromeos/storage_manager.html
[modify] https://crrev.com/205d6d81b48dc72872c07c0f56bdd730129e60a1/chrome/browser/resources/options/chromeos/storage_manager.js
[modify] https://crrev.com/205d6d81b48dc72872c07c0f56bdd730129e60a1/chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc
[modify] https://crrev.com/205d6d81b48dc72872c07c0f56bdd730129e60a1/chrome/browser/ui/webui/options/chromeos/storage_manager_handler.h

Blocking: 618933
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6380c07c5be816838aa3e8027d32b1cc2404c9c9

commit 6380c07c5be816838aa3e8027d32b1cc2404c9c9
Author: fukino <fukino@chromium.org>
Date: Thu Jun 09 07:28:29 2016

Add an API to get total size of Drive cache including non-evictable ones.

The API is needed to show the total size of Drive cache in storage manager.
This CL also changes the type of cache size to int64_t, to be consistent with functions under base/files.

BUG= 591958 
TEST=manually

Review-Url: https://codereview.chromium.org/2048993002
Cr-Commit-Position: refs/heads/master@{#398805}

[modify] https://crrev.com/6380c07c5be816838aa3e8027d32b1cc2404c9c9/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
[modify] https://crrev.com/6380c07c5be816838aa3e8027d32b1cc2404c9c9/components/drive/chromeos/dummy_file_system.h
[modify] https://crrev.com/6380c07c5be816838aa3e8027d32b1cc2404c9c9/components/drive/chromeos/fake_file_system.cc
[modify] https://crrev.com/6380c07c5be816838aa3e8027d32b1cc2404c9c9/components/drive/chromeos/fake_file_system.h
[modify] https://crrev.com/6380c07c5be816838aa3e8027d32b1cc2404c9c9/components/drive/chromeos/file_cache.cc
[modify] https://crrev.com/6380c07c5be816838aa3e8027d32b1cc2404c9c9/components/drive/chromeos/file_cache.h
[modify] https://crrev.com/6380c07c5be816838aa3e8027d32b1cc2404c9c9/components/drive/chromeos/file_system.cc
[modify] https://crrev.com/6380c07c5be816838aa3e8027d32b1cc2404c9c9/components/drive/chromeos/file_system.h
[modify] https://crrev.com/6380c07c5be816838aa3e8027d32b1cc2404c9c9/components/drive/chromeos/file_system_interface.h

Project Member

Comment 13 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/205d6d81b48dc72872c07c0f56bdd730129e60a1

commit 205d6d81b48dc72872c07c0f56bdd730129e60a1
Author: fukino <fukino@chromium.org>
Date: Fri Jun 10 00:42:13 2016

Storage manager: Show overall size information and size of Downloads.

On the storage manager overlay, this CL adds following functions.
- Shows overall storage information(total/used/available) using statvfs() on the local volume.
- Shows size of Downloads directory by computing directory size recursively.
- Opens up Files app when the label "Downloads" is clicked.
The layout inside the overlay is tentative.

BUG= 591958 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
TEST=manually by flag #enable-storage-manager enabled.

Review-Url: https://codereview.chromium.org/2041343002
Cr-Commit-Position: refs/heads/master@{#399057}

[modify] https://crrev.com/205d6d81b48dc72872c07c0f56bdd730129e60a1/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/205d6d81b48dc72872c07c0f56bdd730129e60a1/chrome/browser/resources/options/chromeos/storage_manager.css
[modify] https://crrev.com/205d6d81b48dc72872c07c0f56bdd730129e60a1/chrome/browser/resources/options/chromeos/storage_manager.html
[modify] https://crrev.com/205d6d81b48dc72872c07c0f56bdd730129e60a1/chrome/browser/resources/options/chromeos/storage_manager.js
[modify] https://crrev.com/205d6d81b48dc72872c07c0f56bdd730129e60a1/chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc
[modify] https://crrev.com/205d6d81b48dc72872c07c0f56bdd730129e60a1/chrome/browser/ui/webui/options/chromeos/storage_manager_handler.h

Project Member

Comment 14 by bugdroid1@chromium.org, Jun 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3fbfe7d3230493784f1818e1ee6bd6246112470

commit f3fbfe7d3230493784f1818e1ee6bd6246112470
Author: fukino <fukino@chromium.org>
Date: Sat Jun 18 03:46:02 2016

Storage manager: Show Google Drive offline files.

This CL adds following functions:
- Show the total size of Google Drive offline files.
- Show a confirmation dialog from which users can delete evictable offline files.

BUG= 591958 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2070893003
Cr-Commit-Position: refs/heads/master@{#400575}

[modify] https://crrev.com/f3fbfe7d3230493784f1818e1ee6bd6246112470/chrome/app/chromeos_strings.grdp
[add] https://crrev.com/f3fbfe7d3230493784f1818e1ee6bd6246112470/chrome/browser/resources/options/chromeos/storage_clear_drive_cache_overlay.html
[add] https://crrev.com/f3fbfe7d3230493784f1818e1ee6bd6246112470/chrome/browser/resources/options/chromeos/storage_clear_drive_cache_overlay.js
[modify] https://crrev.com/f3fbfe7d3230493784f1818e1ee6bd6246112470/chrome/browser/resources/options/chromeos/storage_manager.html
[modify] https://crrev.com/f3fbfe7d3230493784f1818e1ee6bd6246112470/chrome/browser/resources/options/chromeos/storage_manager.js
[modify] https://crrev.com/f3fbfe7d3230493784f1818e1ee6bd6246112470/chrome/browser/resources/options/options.html
[modify] https://crrev.com/f3fbfe7d3230493784f1818e1ee6bd6246112470/chrome/browser/resources/options/options.js
[modify] https://crrev.com/f3fbfe7d3230493784f1818e1ee6bd6246112470/chrome/browser/resources/options/options_bundle.js
[modify] https://crrev.com/f3fbfe7d3230493784f1818e1ee6bd6246112470/chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc
[modify] https://crrev.com/f3fbfe7d3230493784f1818e1ee6bd6246112470/chrome/browser/ui/webui/options/chromeos/storage_manager_handler.h

Blockedon: 622111
Project Member

Comment 16 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c20fd8c81e0174fca68bcdf8db4da70342daf3b0

commit c20fd8c81e0174fca68bcdf8db4da70342daf3b0
Author: fukino <fukino@chromium.org>
Date: Wed Jun 22 03:55:07 2016

Storage manager: Add conditional messages for disk low situation and update design.

This CL does:
- Show warning messages when disk space is low.
    1) If the space is below 1GB, show a warning message.
    2) If the space is below 512MB, show a scary warning message.
- Show a bar indicating how much space is used. The bar color is changed when space < 1GB and space < 512MB.
- Update layout and strings to match the latest spec.

BUG= 591958 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2078153002
Cr-Commit-Position: refs/heads/master@{#401199}

[modify] https://crrev.com/c20fd8c81e0174fca68bcdf8db4da70342daf3b0/chrome/app/chromeos_strings.grdp
[add] https://crrev.com/c20fd8c81e0174fca68bcdf8db4da70342daf3b0/chrome/browser/resources/options/chromeos/space_critically_low.svg
[add] https://crrev.com/c20fd8c81e0174fca68bcdf8db4da70342daf3b0/chrome/browser/resources/options/chromeos/space_low.svg
[modify] https://crrev.com/c20fd8c81e0174fca68bcdf8db4da70342daf3b0/chrome/browser/resources/options/chromeos/storage_manager.css
[modify] https://crrev.com/c20fd8c81e0174fca68bcdf8db4da70342daf3b0/chrome/browser/resources/options/chromeos/storage_manager.html
[modify] https://crrev.com/c20fd8c81e0174fca68bcdf8db4da70342daf3b0/chrome/browser/resources/options/chromeos/storage_manager.js
[modify] https://crrev.com/c20fd8c81e0174fca68bcdf8db4da70342daf3b0/chrome/browser/resources/options/options.html
[modify] https://crrev.com/c20fd8c81e0174fca68bcdf8db4da70342daf3b0/chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc
[modify] https://crrev.com/c20fd8c81e0174fca68bcdf8db4da70342daf3b0/chrome/browser/ui/webui/options/chromeos/storage_manager_handler.h

Project Member

Comment 17 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f79246fa18da77ae1739b26c91f500a06127004a

commit f79246fa18da77ae1739b26c91f500a06127004a
Author: fukino <fukino@chromium.org>
Date: Thu Jun 23 19:52:50 2016

Use ENABLE_DISABLE_VALUE_TYPE for storage-manager switch and enable it by default on dev.

This CL does:
- Modify storage manager's flag type from SINGLE_VALUE_TYPE to ENABLE_DISABLE_VALUE_TYPE to have a default value.
- Enable storage manager by default on dev channel.

BUG= 591958 

Review-Url: https://codereview.chromium.org/2076763004
Cr-Commit-Position: refs/heads/master@{#401693}

[modify] https://crrev.com/f79246fa18da77ae1739b26c91f500a06127004a/chrome/browser/about_flags.cc
[modify] https://crrev.com/f79246fa18da77ae1739b26c91f500a06127004a/chrome/browser/ui/webui/options/browser_options_handler.cc
[modify] https://crrev.com/f79246fa18da77ae1739b26c91f500a06127004a/chromeos/chromeos_switches.cc
[modify] https://crrev.com/f79246fa18da77ae1739b26c91f500a06127004a/chromeos/chromeos_switches.h
[modify] https://crrev.com/f79246fa18da77ae1739b26c91f500a06127004a/tools/metrics/histograms/histograms.xml

Project Member

Comment 19 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/2cf87623ebe64dbff665490900713695ba7c5113

commit 2cf87623ebe64dbff665490900713695ba7c5113
Author: Naoki Fukino <fukino@chromium.org>
Date: Tue Jun 28 16:03:47 2016

cryptohome: Add constants and protobuf for GetAccountDiskUsage.

BUG= chromium:591958 
TEST=none

Change-Id: Idcdac1829f0b81ed9c7f86c70f0c29bdfdf327fd
Reviewed-on: https://chromium-review.googlesource.com/356275
Tested-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Will Drewry <wad@chromium.org>
Reviewed-by: Darren Krahn <dkrahn@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>

[modify] https://crrev.com/2cf87623ebe64dbff665490900713695ba7c5113/dbus/cryptohome/rpc.proto
[modify] https://crrev.com/2cf87623ebe64dbff665490900713695ba7c5113/dbus/cryptohome/dbus-constants.h

Project Member

Comment 20 by bugdroid1@chromium.org, Jun 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b5028eb08cc3ce13ad3b8c878befc742c75b5e66

commit b5028eb08cc3ce13ad3b8c878befc742c75b5e66
Author: Naoki Fukino <fukino@chromium.org>
Date: Tue Jun 28 15:56:43 2016

cryptohome: Add GetAccountDiskUsage call.

To know the size of cryptohome for a specified user even when the user
is not signed in, this CL adds an API to cryptohome which computes the
size and returns it in bytes.

BUG= chromium:591958 
TEST=HomeDirsTest.ComputeCryptohomeSize unittest. Manually tested.

Change-Id: I89d33c19dbf794553d0748b6deaf186cb5d9ba31
Reviewed-on: https://chromium-review.googlesource.com/356641
Commit-Ready: Naoki Fukino <fukino@chromium.org>
Tested-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Darren Krahn <dkrahn@chromium.org>

[modify] https://crrev.com/b5028eb08cc3ce13ad3b8c878befc742c75b5e66/cryptohome/mock_platform.cc
[modify] https://crrev.com/b5028eb08cc3ce13ad3b8c878befc742c75b5e66/cryptohome/service.cc
[modify] https://crrev.com/b5028eb08cc3ce13ad3b8c878befc742c75b5e66/cryptohome/platform.cc
[modify] https://crrev.com/b5028eb08cc3ce13ad3b8c878befc742c75b5e66/cryptohome/homedirs.h
[modify] https://crrev.com/b5028eb08cc3ce13ad3b8c878befc742c75b5e66/cryptohome/etc/Cryptohome.conf
[modify] https://crrev.com/b5028eb08cc3ce13ad3b8c878befc742c75b5e66/cryptohome/mock_platform.h
[modify] https://crrev.com/b5028eb08cc3ce13ad3b8c878befc742c75b5e66/cryptohome/service.h
[modify] https://crrev.com/b5028eb08cc3ce13ad3b8c878befc742c75b5e66/cryptohome/interface.cc
[modify] https://crrev.com/b5028eb08cc3ce13ad3b8c878befc742c75b5e66/cryptohome/interface.h
[modify] https://crrev.com/b5028eb08cc3ce13ad3b8c878befc742c75b5e66/cryptohome/homedirs_unittest.cc
[modify] https://crrev.com/b5028eb08cc3ce13ad3b8c878befc742c75b5e66/cryptohome/cryptohome.xml
[modify] https://crrev.com/b5028eb08cc3ce13ad3b8c878befc742c75b5e66/cryptohome/homedirs.cc
[modify] https://crrev.com/b5028eb08cc3ce13ad3b8c878befc742c75b5e66/cryptohome/platform.h

Project Member

Comment 21 by bugdroid1@chromium.org, Jun 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc2718d95cc02f86c1258d8ef497892e7b346a22

commit cc2718d95cc02f86c1258d8ef497892e7b346a22
Author: fukino <fukino@chromium.org>
Date: Thu Jun 30 19:04:51 2016

Add a counter to calculate the total size of site data.

To compute the total size of site data in browsing data, this CL adds following classes.
  SiteDataSizeCollector: collects size information of site data from storage backends using BrowsingData*Helper.
  SiteDataCounter: works as a BrowsingDataCounter using the size collector above.

BUG= 591958 

Review-Url: https://codereview.chromium.org/2092663002
Cr-Commit-Position: refs/heads/master@{#403236}

[modify] https://crrev.com/cc2718d95cc02f86c1258d8ef497892e7b346a22/chrome/browser/browsing_data/mock_browsing_data_appcache_helper.cc
[modify] https://crrev.com/cc2718d95cc02f86c1258d8ef497892e7b346a22/chrome/browser/browsing_data/mock_browsing_data_appcache_helper.h
[modify] https://crrev.com/cc2718d95cc02f86c1258d8ef497892e7b346a22/chrome/browser/browsing_data/mock_browsing_data_file_system_helper.cc
[modify] https://crrev.com/cc2718d95cc02f86c1258d8ef497892e7b346a22/chrome/browser/browsing_data/mock_browsing_data_file_system_helper.h
[modify] https://crrev.com/cc2718d95cc02f86c1258d8ef497892e7b346a22/chrome/browser/browsing_data/mock_browsing_data_service_worker_helper.cc
[add] https://crrev.com/cc2718d95cc02f86c1258d8ef497892e7b346a22/chrome/browser/browsing_data/site_data_size_collector.cc
[add] https://crrev.com/cc2718d95cc02f86c1258d8ef497892e7b346a22/chrome/browser/browsing_data/site_data_size_collector.h
[add] https://crrev.com/cc2718d95cc02f86c1258d8ef497892e7b346a22/chrome/browser/browsing_data/site_data_size_collector_unittest.cc
[modify] https://crrev.com/cc2718d95cc02f86c1258d8ef497892e7b346a22/chrome/chrome_browser.gypi
[modify] https://crrev.com/cc2718d95cc02f86c1258d8ef497892e7b346a22/chrome/chrome_tests_unit.gypi

Project Member

Comment 22 by bugdroid1@chromium.org, Jul 1 2016

Project Member

Comment 23 by bugdroid1@chromium.org, Jul 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1717bcb71c4e34c4dbef814afbca83e21049dba7

commit 1717bcb71c4e34c4dbef814afbca83e21049dba7
Author: fukino <fukino@chromium.org>
Date: Fri Jul 01 02:35:28 2016

Storage manager: Show the disk usage of other users.

This CL adds an item "Other users" on the storage manager, which shows the total
disk size used by other users.
Cryptohome API was added by https://chromium-review.googlesource.com/#/c/356641

BUG= 591958 
TEST=manually tested on link/minnie
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2111043003
Cr-Commit-Position: refs/heads/master@{#403393}

[modify] https://crrev.com/1717bcb71c4e34c4dbef814afbca83e21049dba7/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/1717bcb71c4e34c4dbef814afbca83e21049dba7/chrome/browser/resources/options/chromeos/storage_manager.html
[modify] https://crrev.com/1717bcb71c4e34c4dbef814afbca83e21049dba7/chrome/browser/resources/options/chromeos/storage_manager.js
[modify] https://crrev.com/1717bcb71c4e34c4dbef814afbca83e21049dba7/chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc
[modify] https://crrev.com/1717bcb71c4e34c4dbef814afbca83e21049dba7/chrome/browser/ui/webui/options/chromeos/storage_manager_handler.h
[modify] https://crrev.com/1717bcb71c4e34c4dbef814afbca83e21049dba7/chromeos/cryptohome/homedir_methods.cc
[modify] https://crrev.com/1717bcb71c4e34c4dbef814afbca83e21049dba7/chromeos/cryptohome/homedir_methods.h
[modify] https://crrev.com/1717bcb71c4e34c4dbef814afbca83e21049dba7/chromeos/cryptohome/mock_homedir_methods.h
[modify] https://crrev.com/1717bcb71c4e34c4dbef814afbca83e21049dba7/chromeos/dbus/cryptohome_client.cc
[modify] https://crrev.com/1717bcb71c4e34c4dbef814afbca83e21049dba7/chromeos/dbus/cryptohome_client.h
[modify] https://crrev.com/1717bcb71c4e34c4dbef814afbca83e21049dba7/chromeos/dbus/fake_cryptohome_client.cc
[modify] https://crrev.com/1717bcb71c4e34c4dbef814afbca83e21049dba7/chromeos/dbus/fake_cryptohome_client.h
[modify] https://crrev.com/1717bcb71c4e34c4dbef814afbca83e21049dba7/chromeos/dbus/mock_cryptohome_client.h

Labels: Merge-Request-53
The commit in #23 missed M53 branch, so I'd like to request a merge for it.
Labels: ReleaseBlock-Stable

Comment 26 by dimu@google.com, Jul 11 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 27 by bugdroid1@chromium.org, Jul 11 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a954edd289c69b89d330cf42f95c3d99eaa8a02f

commit a954edd289c69b89d330cf42f95c3d99eaa8a02f
Author: Naoki Fukino <fukino@chromium.org>
Date: Mon Jul 11 08:21:47 2016

Storage manager: Show the disk usage of other users.

This CL adds an item "Other users" on the storage manager, which shows the total
disk size used by other users.
Cryptohome API was added by https://chromium-review.googlesource.com/#/c/356641

BUG= 591958 
TEST=manually tested on link/minnie
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
TBR=dbeam@chromium.org

Review-Url: https://codereview.chromium.org/2111043003
Cr-Commit-Position: refs/heads/master@{#403393}
(cherry picked from commit 1717bcb71c4e34c4dbef814afbca83e21049dba7)

Review URL: https://codereview.chromium.org/2135103003 .

Cr-Commit-Position: refs/branch-heads/2785@{#73}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/a954edd289c69b89d330cf42f95c3d99eaa8a02f/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/a954edd289c69b89d330cf42f95c3d99eaa8a02f/chrome/browser/resources/options/chromeos/storage_manager.html
[modify] https://crrev.com/a954edd289c69b89d330cf42f95c3d99eaa8a02f/chrome/browser/resources/options/chromeos/storage_manager.js
[modify] https://crrev.com/a954edd289c69b89d330cf42f95c3d99eaa8a02f/chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc
[modify] https://crrev.com/a954edd289c69b89d330cf42f95c3d99eaa8a02f/chrome/browser/ui/webui/options/chromeos/storage_manager_handler.h
[modify] https://crrev.com/a954edd289c69b89d330cf42f95c3d99eaa8a02f/chromeos/cryptohome/homedir_methods.cc
[modify] https://crrev.com/a954edd289c69b89d330cf42f95c3d99eaa8a02f/chromeos/cryptohome/homedir_methods.h
[modify] https://crrev.com/a954edd289c69b89d330cf42f95c3d99eaa8a02f/chromeos/cryptohome/mock_homedir_methods.h
[modify] https://crrev.com/a954edd289c69b89d330cf42f95c3d99eaa8a02f/chromeos/dbus/cryptohome_client.cc
[modify] https://crrev.com/a954edd289c69b89d330cf42f95c3d99eaa8a02f/chromeos/dbus/cryptohome_client.h
[modify] https://crrev.com/a954edd289c69b89d330cf42f95c3d99eaa8a02f/chromeos/dbus/fake_cryptohome_client.cc
[modify] https://crrev.com/a954edd289c69b89d330cf42f95c3d99eaa8a02f/chromeos/dbus/fake_cryptohome_client.h
[modify] https://crrev.com/a954edd289c69b89d330cf42f95c3d99eaa8a02f/chromeos/dbus/mock_cryptohome_client.h

Status: Fixed (was: Started)
Let me mark this issue as Fixed since basic implementation is done.
For the remaining issues about storage manager, I'll file separated issues.
At this moment, I filed these issues.
 Issue 625070  Storage manager: Show user list to remove a user.
 Issue 625071  Storage manager: Storage usage shown on the UI should be updated periodically.
 Issue 625072  Storage manager: Count the size of site data as a part of size of "Browsing data".
 Issue 625074  Storage manager should retry fetching Android storage size.
 Issue 626560  Storage manager: The total size of other users are shown as "Calculating..." forever.

Labels: -ReleaseBlock-Stable
Status: Verified (was: Fixed)
ChromeOS build 8530.96.0 / 53.0.2785.154

Sign in to add a comment