New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 591952 link

Starred by 2 users
Status: WontFix
Owner:
jochen@chromium.org
Closed: Apr 2016
Cc:
█ djasper@google.com
cbruni@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

cpplint.py and clang-format sort headers differently

Project Member Reported by jochen@chromium.org, Mar 4 2016 
e.g.

This is what git cl format produces:
#include "src/api-natives.h"
#include "src/api.h"
....
#include "src/objects-body-descriptors-inl.h"
#include "src/objects-inl.h"

This is what git cl presubmit wants:
#include "src/api.h"
#include "src/api-natives.h"
....
#include "src/objects-inl.h"
#include "src/objects-body-descriptors-inl.h"

Comment 1 by jochen@chromium.org, Mar 4 2016 

cpplint.py is  https://code.google.com/p/google-styleguide/source/detail?spec=svn141&r=141

clang-format also claims to do google style sorting.

There can only be one!

Comment 2 by djasper@google.com, Mar 4 2016 

cpplint is wrong. It converts the "-" to "_" and then sorts which doesn't
really makes sense.

On Fri, Mar 4, 2016 at 1:09 AM, jochen@chromium.org via Monorail <
monorail@chromium.org> wrote:

Comment 3 by jochen@chromium.org, Mar 7 2016

Owner: jochen@chromium.org
Status: Assigned (was: Available)
created https://github.com/google/styleguide/pull/108

Comment 4 by jochen@chromium.org, Apr 22 2016

Status: WontFix (was: Assigned)
we've just disabled the check in cpplint...
►

Sign in to add a comment