New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 591951 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

WebRTC doesn't specify what revision of transport sequence number it has implemented.

Project Member Reported by holmer@chromium.org, Mar 4 2016

Issue description

This is problematic if the header extension is updated in an incompatible way in the future.

The extension name should be:
http://www.ietf.org/id/draft-holmer-rmcat-transport-wide-cc-extensions-01

But currently is:
http://www.ietf.org/id/draft-holmer-rmcat-transport-wide-cc-extensions
 
Labels: Merge-Request-50
Fixed with https://chromium.googlesource.com/external/webrtc.git/+/5711c8d1f84918ee2eb70e91a41058dfb0d2d313

which has been verified to solve the issue and is part of current Canary (	51.0.2667.0).
Status: Verified (was: Assigned)
Cc: srnarayanan@chromium.org jansson@chromium.org
Status: Fixed (was: Verified)
Moving this out of "verified" status so that it's clear that this is fixed in ToT, but the merge hasn't landed (or been approved) yet.

holmer@ - if this also results in a user visible change (via chrome://webrtc-internals, etc), can you briefly describe where we should find the revision info?
It is visible in webrtc-internals and SetLocalDescription in an appr.tc call _if_ --force-fieldtrials=WebRTC-SendSideBwe/Enabled/ is specified when starting Chrome.

Comment 6 by tin...@google.com, Mar 5 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Seems like this is already merged to M50. If nothing is left for M50, please remove "Merge-Approved-50" label. Thank you.
Labels: -Merge-Approved-50
Status: Verified (was: Fixed)
Per repro steps in #5 above, verified in M50 50.0.2661.28 

In SetLocalDescription - 

a=extmap:2 urn:ietf:params:rtp-hdrext:toffset
a=extmap:3 http://www.webrtc.org/experiments/rtp-hdrext/abs-send-time
a=extmap:4 urn:3gpp:video-orientation
a=extmap:5 http://www.ietf.org/id/draft-holmer-rmcat-transport-wide-cc-extensions-01
a=sendrecv
a=rtcp-mux
a=rtpmap:100 VP8/90000
a=rtcp-fb:100 ccm fir

Sign in to add a comment