New issue
Advanced search Search tips

Issue 591946 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Remove dependency from LayoutTests/fast/dom/shadow/resources/shadow-dom.js to LayoutTests/resources/js-test.js

Project Member Reported by hayato@chromium.org, Mar 4 2016

Issue description

shadow-dom.js is using a `debug` function, which is defined in js-test.js.

Because shadow-dom.js is also getting used without js-test.js, such as in a testharness based test,
it would be nice to remove a dependency from shadow-dom.js to js-test.js.


 
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a49cbd778aef637c586a8ebae8bb2f952d30a09

commit 5a49cbd778aef637c586a8ebae8bb2f952d30a09
Author: yuzus <yuzus@chromium.org>
Date: Tue Mar 08 07:43:01 2016

Removing dependency on js-test.js from shadow-dom.js

This CL removes dependency of shadow-dom.js on js-test.js, namely debug function.

BUG= 591946 

Review URL: https://codereview.chromium.org/1773553003

Cr-Commit-Position: refs/heads/master@{#379777}

[modify] https://crrev.com/5a49cbd778aef637c586a8ebae8bb2f952d30a09/third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js
[modify] https://crrev.com/5a49cbd778aef637c586a8ebae8bb2f952d30a09/third_party/WebKit/LayoutTests/fast/dom/shadow/tabindex-slot.html

Comment 3 by yuzus@chromium.org, Mar 8 2016

Status: Fixed (was: Assigned)

Sign in to add a comment