Regression: Browser crashes on clicking scrollbar in 'Edit bookmark' overlay.
Reported by
vvishwak...@etouch.net,
Mar 4 2016
|
|||||||
Issue descriptionVersion: 50.0.2661.14 (Official Build) c6bd6394a1dce112a7cff87339494d6850b0dfd7-refs/branch-heads/2661@{#74} (32/64-bit) OS: Linux, Windows (Win 7-Aero enabled) What steps will reproduce the problem? 1) Launch chrome, show bookmarks bar using 'Ctrl+Shift+B'. 2) Right click on Bookmarks bar, click on 'Add folder', rename the folder with some long name and 'Save'. 3) Right click on Bookmarks bar, select 'Add file' option, & expand Bookmarks bar option. 4) Click on the vertical scrollbar 4-5 times and observe. Browser crashes on clicking scrollbar. Browser should not crash on clicking scrollbar. This is a Regression issue broken in M-50, below is the bisect info Manual bisect: Good build: 50.0.2654.0 Bad build: 50.0.2655.0 Crash ID: Crash ID 0c079ff000000000 (Chrome) Crash ID 1b4a3d9800000000 (dfe2f829-0ac8-459a-9c3e-b690eb2a8c58) Narrow bisect URL: https://chromium.googlesource.com/chromium/src/+log/3c8f3ebf3736574766e042f76f265e5793ef3e51..5def0de596a472b50c5bfb99ec218c36241e4631?pretty=fuller&n=100 Suspecting: r376199 Note: Issue is not seen on Mac OS.
,
Mar 4 2016
,
Mar 4 2016
When you create a long bookmark name it forces the horizontal scroll bar to be shown. This forces display of the vertical scroll bar as well but since there's no vertical scrolling necessary the thumb is the entire length of the track. My new logic from r376199 computes the distance the thumb can move by subtracting its size from the total size of the track. Since these are equal in this case it gets 0 and divides by it to determine the scroll distance in the content pane. This can be special cased in the code. I also notice that another division by zero is possible if content_size_ == viewport_size_ in the function above. I'll take a look at this tomorrow and add tests to cover these edge cases.
,
Mar 4 2016
,
Mar 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c6639a0a0b75d2696f6b3c9a5a47c8dc6096df8 commit 5c6639a0a0b75d2696f6b3c9a5a47c8dc6096df8 Author: reillyg <reillyg@chromium.org> Date: Sat Mar 05 02:23:36 2016 Guard against division by zero for useless scroll bars. This patch adds protection against division by zero when a scroll bar's thumb is the full size of the track (i.e. the scroll bar is useless). BUG= 591933 Review URL: https://codereview.chromium.org/1769553003 Cr-Commit-Position: refs/heads/master@{#379437} [modify] https://crrev.com/5c6639a0a0b75d2696f6b3c9a5a47c8dc6096df8/ui/views/controls/scrollbar/base_scroll_bar.cc [modify] https://crrev.com/5c6639a0a0b75d2696f6b3c9a5a47c8dc6096df8/ui/views/controls/scrollbar/base_scroll_bar.h [modify] https://crrev.com/5c6639a0a0b75d2696f6b3c9a5a47c8dc6096df8/ui/views/controls/scrollbar/scrollbar_unittest.cc
,
Mar 5 2016
,
Mar 6 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Mar 7 2016
Merge out for review: https://codereview.chromium.org/1772023002
,
Mar 7 2016
If possible, please try to merge your change to M50 branch 2661 before 5:00 PM PST today to catch up with M50 Dev candidate cut @ 5:00 PM today.
,
Mar 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87686973fe8171dfbc515c81e50b9602b9a8cf12 commit 87686973fe8171dfbc515c81e50b9602b9a8cf12 Author: Reilly Grant <reillyg@chromium.org> Date: Mon Mar 07 23:55:57 2016 Guard against division by zero for useless scroll bars. This patch adds protection against division by zero when a scroll bar's thumb is the full size of the track (i.e. the scroll bar is useless). BUG= 591933 Review URL: https://codereview.chromium.org/1769553003 Cr-Commit-Position: refs/heads/master@{#379437} (cherry-picked from commit 5c6639a0a0b75d2696f6b3c9a5a47c8dc6096df8) R=sky@chromium.org Review URL: https://codereview.chromium.org/1772023002 . Cr-Commit-Position: refs/branch-heads/2661@{#115} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/87686973fe8171dfbc515c81e50b9602b9a8cf12/ui/views/controls/scrollbar/base_scroll_bar.cc [modify] https://crrev.com/87686973fe8171dfbc515c81e50b9602b9a8cf12/ui/views/controls/scrollbar/base_scroll_bar.h [modify] https://crrev.com/87686973fe8171dfbc515c81e50b9602b9a8cf12/ui/views/controls/scrollbar/scrollbar_unittest.cc
,
Mar 8 2016
Fix is working as intended. Rechecked on Verified OS for chrome version: 50.0.2661.18 and adding TE-verified labels.
,
Mar 8 2016
Verified the above issue on Win 7, Win 8.1, Win 10 and Linux OS.
,
Jun 6 2016
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ranjitkan@chromium.org
, Mar 4 2016