IcoImageDecoderTest and BmpImageDecoderTest need to be moved into blink |
||
Issue descriptionBlink is vastly simplifying the public API as per the Onion Soup plan and won't be exposing APIs to content for unit testing classes inside blink. These tests need to be moved into blink. Note that these tests are also extremely unfortunate since they depend on src-internal meaning the code looks untested and the tests don't actually run on any of the try jobs so external contributors can't work in that code. We should really upstream the images or switch to public images. For example we have a bunch of BMP unit tests now, though we apparently don't have ico ones.
,
Mar 4 2016
I would be amazed if the public images tested anywhere remotely close to what the private images do. Upstreaming them as-is is dangerous as they were scraped without attribution. Making a new set of images from scratch to test all the cases here would be possible but extremely laborious.
,
Mar 4 2016
Well step #1 is the move the tests into blink. Would you be able to do that?
,
Mar 4 2016
Someday? I currently have about 400% more tasks than I have time :( I haven't landed anything functional in Blink in a very long time, but I assume this wouldn't be too hard to do.
,
Jun 23 2016
Renaming Blink>Architecture to Blink>Internals |
||
►
Sign in to add a comment |
||
Comment 1 by esprehn@chromium.org
, Mar 4 2016