New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 591909 link

Starred by 1 user
Status: Fixed
Owner:
yuzus@chromium.org
Closed: Mar 2016
Cc:
█ kochi@chromium.org
hayato@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 531990



Sign in to add a comment

<slot> should have its own focus navigation scope

Project Member Reported by kochi@chromium.org, Mar 4 2016 
Per discussion in
https://github.com/w3c/webcomponents/issues/375

For Shadow DOM v1, distributed elements under a <slot> should have
its own focus navigation scope.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/856302237805d511bcc93ffc965b674406d7c80a

commit 856302237805d511bcc93ffc965b674406d7c80a
Author: yuzus <yuzus@chromium.org>
Date: Mon Mar 07 07:55:35 2016

Consider slots as a focus scope

V1 Slots can now have their own focus scope just like shadow roots, so that the assigned elements would be traversed together, which is visually more consistent than the current implementation. This reflects the results of the discussion in TPAC.
See the discussion here: https://github.com/w3c/webcomponents/issues/375

BUG= 591909 

Review URL: https://codereview.chromium.org/1707443003

Cr-Commit-Position: refs/heads/master@{#379523}

[modify] https://crrev.com/856302237805d511bcc93ffc965b674406d7c80a/third_party/WebKit/LayoutTests/fast/dom/shadow/focus-navigation-with-multiple-shadow-roots-expected.txt
[modify] https://crrev.com/856302237805d511bcc93ffc965b674406d7c80a/third_party/WebKit/LayoutTests/fast/dom/shadow/focus-navigation-with-multiple-shadow-roots.html
[add] https://crrev.com/856302237805d511bcc93ffc965b674406d7c80a/third_party/WebKit/LayoutTests/fast/dom/shadow/tabindex-slot.html
[modify] https://crrev.com/856302237805d511bcc93ffc965b674406d7c80a/third_party/WebKit/Source/core/core.gypi
[add] https://crrev.com/856302237805d511bcc93ffc965b674406d7c80a/third_party/WebKit/Source/core/dom/shadow/SlotScopedTraversal.cpp
[add] https://crrev.com/856302237805d511bcc93ffc965b674406d7c80a/third_party/WebKit/Source/core/dom/shadow/SlotScopedTraversal.h
[modify] https://crrev.com/856302237805d511bcc93ffc965b674406d7c80a/third_party/WebKit/Source/core/page/FocusController.cpp

Comment 2 by yuzus@chromium.org, Mar 7 2016

Status: Fixed (was: Started)

Comment 3 by benhenry@chromium.org, Sep 29 2017

Components: Blink>HTML>Focus

Comment 4 by benhenry@chromium.org, Sep 29 2017

Components: -Blink>Focus
►

Sign in to add a comment