New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 591901 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 587737



Sign in to add a comment

layout test failures in fast/images/color-profile-{background-clip-text,svg-fill-text}.html

Project Member Reported by dpranke@chromium.org, Mar 4 2016

Issue description

These appear to be producing failures on Mac10.11 (both regular and retina), but the images seem oddly different on linux, win, and mac10.9 as well, so I'm not actually sure what is considered correct or why the platforms would be different.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fimages%2Fcolor-profile-background-clip-text.html%20fast%2Fimages%2Fcolor-profile-svg-fill-text.html

fast/images/color-profile-background-clip-text.html
fast/images/color-profile-svg-fill-text.html

noel@, pdr@ can one of you take a look at these and, if you're not the right people to decide what to do about them, hopefully re-point this bug at the right people?
 

Comment 1 by noel@chromium.org, Mar 4 2016

Cc: -noel@chromium.org
Owner: noel@chromium.org
Status: Started (was: Untriaged)

Comment 2 by noel@chromium.org, Mar 4 2016

These tests use Ahem font and use point (pt) units for font size, and for some page element position code.

I will change the tests to use absolute units (px) for font size and positions, and see if that produces consistent render results on these ports.

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5982e29a45b6d2074d85daa86409c6065adfd8f4

commit 5982e29a45b6d2074d85daa86409c6065adfd8f4
Author: noel <noel@chromium.org>
Date: Fri Mar 04 09:22:30 2016

Use px in color-profile-{background-clip-text,svg-fill-text}.html

Use px for font size and positions in these tests to produce more
consistent rendering across ports ( issue 591901 ), and request new
test rebaselines on all ports.

TBR=dpranke@chromium.org
BUG=587737, 591901 
NOPRESUBMIT=true
NOTRY=true

Review URL: https://codereview.chromium.org/1761293002

Cr-Commit-Position: refs/heads/master@{#379253}

[modify] https://crrev.com/5982e29a45b6d2074d85daa86409c6065adfd8f4/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/5982e29a45b6d2074d85daa86409c6065adfd8f4/third_party/WebKit/LayoutTests/fast/images/color-profile-background-clip-text.html
[modify] https://crrev.com/5982e29a45b6d2074d85daa86409c6065adfd8f4/third_party/WebKit/LayoutTests/fast/images/color-profile-svg-fill-text.html

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ed72916ddc16becae48e3ee861922d6de9b2136

commit 4ed72916ddc16becae48e3ee861922d6de9b2136
Author: treib <treib@chromium.org>
Date: Fri Mar 04 10:52:27 2016

Revert of Use px in color-profile-{background-clip-text,svg-fill-text}.html (patchset #1 id:1 of https://codereview.chromium.org/1761293002/ )

Reason for revert:
Broke webkit_lint on all the bots.
What was the justification for NOPRESUBMIT and NOTRY here?

Original issue's description:
> Use px in color-profile-{background-clip-text,svg-fill-text}.html
>
> Use px for font size and positions in these tests to produce more
> consistent rendering across ports ( issue 591901 ), and request new
> test rebaselines on all ports.
>
> TBR=dpranke@chromium.org
> BUG=587737, 591901 
> NOPRESUBMIT=true
> NOTRY=true
>
> Committed: https://crrev.com/5982e29a45b6d2074d85daa86409c6065adfd8f4
> Cr-Commit-Position: refs/heads/master@{#379253}

TBR=dpranke@chromium.org,noel@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=587737, 591901 

Review URL: https://codereview.chromium.org/1764693005

Cr-Commit-Position: refs/heads/master@{#379266}

[modify] https://crrev.com/4ed72916ddc16becae48e3ee861922d6de9b2136/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/4ed72916ddc16becae48e3ee861922d6de9b2136/third_party/WebKit/LayoutTests/fast/images/color-profile-background-clip-text.html
[modify] https://crrev.com/4ed72916ddc16becae48e3ee861922d6de9b2136/third_party/WebKit/LayoutTests/fast/images/color-profile-svg-fill-text.html

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/685c9b8cdc54f0bac465fc5170a77c206c871510

commit 685c9b8cdc54f0bac465fc5170a77c206c871510
Author: noel <noel@chromium.org>
Date: Sat Mar 05 02:32:15 2016

Use px in color-profile-{background-clip-text,svg-fill-text}.html

Use px for font size and positions in these tests to produce more
consistent rendering across ports ( issue 591901 ), and request new
test rebaselines on all ports.

BUG=587737, 591901 

Committed: https://crrev.com/5982e29a45b6d2074d85daa86409c6065adfd8f4
Cr-Commit-Position: refs/heads/master@{#379253}

Review URL: https://codereview.chromium.org/1761293002

Cr-Commit-Position: refs/heads/master@{#379440}

[modify] https://crrev.com/685c9b8cdc54f0bac465fc5170a77c206c871510/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/685c9b8cdc54f0bac465fc5170a77c206c871510/third_party/WebKit/LayoutTests/fast/images/color-profile-background-clip-text.html
[modify] https://crrev.com/685c9b8cdc54f0bac465fc5170a77c206c871510/third_party/WebKit/LayoutTests/fast/images/color-profile-svg-fill-text.html

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/102f64940572448134ee271e88d7ded2cea36dc2

commit 102f64940572448134ee271e88d7ded2cea36dc2
Author: Walter Korman <wkorman@google.com>
Date: Mon Mar 07 20:09:24 2016

Auto-rebaseline for r379253

https://chromium.googlesource.com/chromium/src/+/685c9b8cd

BUG= 591901 
TBR=noel@chromium.org

Review URL: https://codereview.chromium.org/1773773002 .

Cr-Commit-Position: refs/heads/master@{#379621}

[modify] https://crrev.com/102f64940572448134ee271e88d7ded2cea36dc2/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/102f64940572448134ee271e88d7ded2cea36dc2/third_party/WebKit/LayoutTests/platform/android/fast/images/color-profile-background-clip-text-expected.png
[add] https://crrev.com/102f64940572448134ee271e88d7ded2cea36dc2/third_party/WebKit/LayoutTests/platform/android/fast/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/102f64940572448134ee271e88d7ded2cea36dc2/third_party/WebKit/LayoutTests/platform/linux/fast/images/color-profile-background-clip-text-expected.png
[modify] https://crrev.com/102f64940572448134ee271e88d7ded2cea36dc2/third_party/WebKit/LayoutTests/platform/linux/fast/images/color-profile-svg-fill-text-expected.png
[add] https://crrev.com/102f64940572448134ee271e88d7ded2cea36dc2/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/images/color-profile-background-clip-text-expected.png
[add] https://crrev.com/102f64940572448134ee271e88d7ded2cea36dc2/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/102f64940572448134ee271e88d7ded2cea36dc2/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/images/color-profile-background-clip-text-expected.png
[modify] https://crrev.com/102f64940572448134ee271e88d7ded2cea36dc2/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/102f64940572448134ee271e88d7ded2cea36dc2/third_party/WebKit/LayoutTests/platform/mac/fast/images/color-profile-background-clip-text-expected.png
[modify] https://crrev.com/102f64940572448134ee271e88d7ded2cea36dc2/third_party/WebKit/LayoutTests/platform/mac/fast/images/color-profile-svg-fill-text-expected.png

Cc: wkorman@chromium.org
It looks like the auto-rebaseline went wrong in #379621, I'm not sure what happened (yet).
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92b182e177d28ca5b2202aec83d8ec48b339a5c5

commit 92b182e177d28ca5b2202aec83d8ec48b339a5c5
Author: dpranke <dpranke@chromium.org>
Date: Thu Mar 10 05:47:21 2016

Suppress layout test failures on win for fast/images/color-profile-* tests.

TBR=tsergeant@chromium.org, noel@chromium.org
BUG= 591901 

Review URL: https://codereview.chromium.org/1784593003

Cr-Commit-Position: refs/heads/master@{#380350}

[modify] https://crrev.com/92b182e177d28ca5b2202aec83d8ec48b339a5c5/third_party/WebKit/LayoutTests/TestExpectations

Cc: yukishiino@chromium.org noel@chromium.org
 Issue 593618  has been merged into this issue.
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b93a925584694b4113e359279a3a1a402a1174b9

commit b93a925584694b4113e359279a3a1a402a1174b9
Author: radu.velea <radu.velea@intel.com>
Date: Fri Apr 01 12:11:09 2016

Remove commented out layout tests failures

After the autorebaseline ran for
https://codereview.chromium.org/1779163002

The following tests now pass on Windows:

fast/images/color-profile-background-clip-text.html and
fast/images/color-profile-svg-fill-text.html

Rather than uncommenting as per TODO. They can simply be removed.

BUG= 591901 , 580917 
NOTRY=true

Review URL: https://codereview.chromium.org/1846193002

Cr-Commit-Position: refs/heads/master@{#384560}

[modify] https://crrev.com/b93a925584694b4113e359279a3a1a402a1174b9/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Started)

Comment 13 by noel@chromium.org, Apr 1 2016

Blocking: 587737
Labels: Test-Layout

Sign in to add a comment