New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 591896 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Long OOO (go/where-is-mgiuca)
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Feature

Blocked on:
issue 352425
issue 523930
issue 610900



Sign in to add a comment

Exclusive access per-site exceptions: delete the data, remove the settings

Project Member Reported by mgiuca@chromium.org, Mar 4 2016

Issue description

Follow-up to  Issue 352425 . We have, or will be, ignoring fullscreen and mouse lock exceptions going forward, and instead just auto-accept on all sites. Assuming everything goes to plan, this will happen in:

- Windows, Linux, Chrome OS: M49
- Mac: M50 or M51
- Android: M51 ( Issue 523930 )

However, we are still storing the user data about fullscreen and mouse lock exceptions, and still exposing the exceptions UI to users (we have to, because we are still storing the data). We can't delete the data until we have stopped using it on all platforms and for all active versions of Chrome (otherwise, we might delete exceptions from sync that are still being used on some of the users' devices).

Assuming we no longer use the data in M51, we can't just delete it, because M51 will be in canary when M49 is stable. We need to wait until M51 is stable and then we can delete it from M53 in canary. I don't think it is time critical, so we just wait until M53.
 
Cc: finnur@chromium.org
+finnur, working on new settings UI.
This went to stable on Android last, in M52. Therefore, we should wait until M52 is stable, then we can delete all the per-site data.
Cc: raymes@chromium.org
Cleanup plan (Step 2 onwards must not land in ToT before M52 stable):
1. We need to deprecate the extensions API chrome.contentSettings (https://developer.chrome.com/extensions/contentSettings) by updating the documentation and examples, and then making it do nothing (set does nothing, get returns empty). It will stay this way forever, to avoid breaking existing extensions.
2. Startup task to delete the following prefs:
- extensions.settings.*.content_settings: delete any elements with type: 'fullscreen' or type: 'mouselock'.
- profile.content_settings.exceptions.fullscreen
- profile.content_settings.exceptions.mouselock
(There are two separate exceptions lists; one for exceptions set by extensions and one for exceptions set from the UI).
3. Remove all references to the above prefs from the code.
4. Remove all UI for these exceptions.

+raymes to confirm this plan.
sgtm
Blockedon: 610900
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 15 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b4b6268ca5e5eb81910dd304c8408eeff0f4e64

commit 9b4b6268ca5e5eb81910dd304c8408eeff0f4e64
Author: mgiuca <mgiuca@chromium.org>
Date: Tue Oct 04 05:41:16 2016

Deprecate chrome.contentSettings.{fullscreen,mouselock} extension API.

These settings no longer hook up to actual data; they just return
'allow' always, and setting them has no effect. Updated documentation.

This is because Chrome now (and has for awhile) ignores these settings
and always permits these actions without asking the user.

BUG= 591896 

Review-Url: https://codereview.chromium.org/2358893004
Cr-Commit-Position: refs/heads/master@{#422716}

[modify] https://crrev.com/9b4b6268ca5e5eb81910dd304c8408eeff0f4e64/chrome/browser/extensions/api/content_settings/content_settings_apitest.cc
[modify] https://crrev.com/9b4b6268ca5e5eb81910dd304c8408eeff0f4e64/chrome/common/extensions/api/content_settings.json
[modify] https://crrev.com/9b4b6268ca5e5eb81910dd304c8408eeff0f4e64/chrome/renderer/resources/extensions/content_setting.js
[modify] https://crrev.com/9b4b6268ca5e5eb81910dd304c8408eeff0f4e64/chrome/test/data/extensions/api_test/content_settings/standard/test.js

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ddd4c1941e58af6ac66b38fce017721a0afe70d3

commit ddd4c1941e58af6ac66b38fce017721a0afe70d3
Author: mgiuca <mgiuca@chromium.org>
Date: Wed Oct 05 23:42:13 2016

Remove fullscreen and mouselock from contentSettings API sample.

These APIs are deprecated (just return dummy data) so it doesn't make
sense to show them in a sample extension.

BUG= 591896 

Review-Url: https://codereview.chromium.org/2397633002
Cr-Commit-Position: refs/heads/master@{#423340}

[modify] https://crrev.com/ddd4c1941e58af6ac66b38fce017721a0afe70d3/chrome/common/extensions/docs/examples/api/contentSettings/popup.html
[modify] https://crrev.com/ddd4c1941e58af6ac66b38fce017721a0afe70d3/chrome/common/extensions/docs/examples/api/contentSettings/popup.js

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8550142e5c20a86576d98de3a4d7031592bc9692

commit 8550142e5c20a86576d98de3a4d7031592bc9692
Author: mgiuca <mgiuca@chromium.org>
Date: Fri Oct 21 06:33:34 2016

Delete fullscreen/mouselock pref data associated with extensions.

This deletes all data associated with the now-removed
chrome.contentSettings.{fullscreen,mouselock} APIs, on startup. Despite
those APIs having been removed in M55 (r422716), the data (fullscreen
and mouselock exception rules associated per-extension per-site) would
still be stored. This deletes the data, as it is no longer being used.

BUG= 591896 

Review-Url: https://chromiumcodereview.appspot.com/2423003002
Cr-Commit-Position: refs/heads/master@{#426737}

[modify] https://crrev.com/8550142e5c20a86576d98de3a4d7031592bc9692/chrome/browser/extensions/api/content_settings/content_settings_store.cc
[modify] https://crrev.com/8550142e5c20a86576d98de3a4d7031592bc9692/chrome/browser/extensions/api/content_settings/content_settings_store_unittest.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ddd4c1941e58af6ac66b38fce017721a0afe70d3

commit ddd4c1941e58af6ac66b38fce017721a0afe70d3
Author: mgiuca <mgiuca@chromium.org>
Date: Wed Oct 05 23:42:13 2016

Remove fullscreen and mouselock from contentSettings API sample.

These APIs are deprecated (just return dummy data) so it doesn't make
sense to show them in a sample extension.

BUG= 591896 

Review-Url: https://codereview.chromium.org/2397633002
Cr-Commit-Position: refs/heads/master@{#423340}

[modify] https://crrev.com/ddd4c1941e58af6ac66b38fce017721a0afe70d3/chrome/common/extensions/docs/examples/api/contentSettings/popup.html
[modify] https://crrev.com/ddd4c1941e58af6ac66b38fce017721a0afe70d3/chrome/common/extensions/docs/examples/api/contentSettings/popup.js

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc83d0f2fbe5aa2e75c3861d626f4b6a0b65cbb6

commit cc83d0f2fbe5aa2e75c3861d626f4b6a0b65cbb6
Author: mgiuca <mgiuca@chromium.org>
Date: Tue Nov 01 04:37:13 2016

Delete fullscreen/mouselock pref data.

This deletes the default and per-site exceptions for fullscreen and
mouse lock settings on startup. These have not been used for some time,
but the settings have still been around (and visible in the settings
UI). This deletes the data, as it is no longer being used.

Note: The content settings page still allows these to be viewed and
edited, though they will be cleared on startup each time. A follow-up CL
will delete the UI since it is now useless. The UI could not be deleted
before this because otherwise there would be no way for the user to see
what data we are storing.

BUG= 591896 

Review-Url: https://codereview.chromium.org/2428433002
Cr-Commit-Position: refs/heads/master@{#428936}

[modify] https://crrev.com/cc83d0f2fbe5aa2e75c3861d626f4b6a0b65cbb6/chrome/browser/content_settings/content_settings_default_provider_unittest.cc
[modify] https://crrev.com/cc83d0f2fbe5aa2e75c3861d626f4b6a0b65cbb6/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc
[modify] https://crrev.com/cc83d0f2fbe5aa2e75c3861d626f4b6a0b65cbb6/chrome/browser/ui/webui/settings/site_settings_handler.cc
[modify] https://crrev.com/cc83d0f2fbe5aa2e75c3861d626f4b6a0b65cbb6/components/content_settings/core/browser/content_settings_default_provider.cc
[modify] https://crrev.com/cc83d0f2fbe5aa2e75c3861d626f4b6a0b65cbb6/components/content_settings/core/browser/content_settings_default_provider.h
[modify] https://crrev.com/cc83d0f2fbe5aa2e75c3861d626f4b6a0b65cbb6/components/content_settings/core/browser/content_settings_pref_provider.cc
[modify] https://crrev.com/cc83d0f2fbe5aa2e75c3861d626f4b6a0b65cbb6/components/content_settings/core/browser/content_settings_pref_provider.h

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/642d06cd509213a349d6d47464075abdd4294aaa

commit 642d06cd509213a349d6d47464075abdd4294aaa
Author: mgiuca <mgiuca@chromium.org>
Date: Thu Nov 03 00:24:38 2016

Remove fullscreen content settings UI from Android.

This UI was vestigial since the content settings themselves had been
removed and data deleted. This just cleans up non-functional UI, both
the general setting in Site Settings, and the per-site setting on the
site page.

BUG= 591896 

Review-Url: https://codereview.chromium.org/2467203002
Cr-Commit-Position: refs/heads/master@{#429474}

[delete] https://crrev.com/890cc54a9df16b8cc36e1d29df9707ec7bed3f24/chrome/android/java/res/drawable-hdpi/permission_fullscreen.png
[delete] https://crrev.com/890cc54a9df16b8cc36e1d29df9707ec7bed3f24/chrome/android/java/res/drawable-mdpi/permission_fullscreen.png
[delete] https://crrev.com/890cc54a9df16b8cc36e1d29df9707ec7bed3f24/chrome/android/java/res/drawable-xhdpi/permission_fullscreen.png
[delete] https://crrev.com/890cc54a9df16b8cc36e1d29df9707ec7bed3f24/chrome/android/java/res/drawable-xxhdpi/permission_fullscreen.png
[delete] https://crrev.com/890cc54a9df16b8cc36e1d29df9707ec7bed3f24/chrome/android/java/res/drawable-xxxhdpi/permission_fullscreen.png
[modify] https://crrev.com/642d06cd509213a349d6d47464075abdd4294aaa/chrome/android/java/res/xml/single_website_preferences.xml
[modify] https://crrev.com/642d06cd509213a349d6d47464075abdd4294aaa/chrome/android/java/res/xml/site_settings_preferences.xml
[modify] https://crrev.com/642d06cd509213a349d6d47464075abdd4294aaa/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ContentSettingsResources.java
[modify] https://crrev.com/642d06cd509213a349d6d47464075abdd4294aaa/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java
[modify] https://crrev.com/642d06cd509213a349d6d47464075abdd4294aaa/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java
[modify] https://crrev.com/642d06cd509213a349d6d47464075abdd4294aaa/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferences.java
[modify] https://crrev.com/642d06cd509213a349d6d47464075abdd4294aaa/chrome/android/java/strings/android_chrome_strings.grd

Project Member

Comment 14 by bugdroid1@chromium.org, Nov 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb853fe9971aac49e05c17e24ce06e1c12bc9157

commit cb853fe9971aac49e05c17e24ce06e1c12bc9157
Author: mgiuca <mgiuca@chromium.org>
Date: Thu Nov 03 04:31:00 2016

Android: Clean up dead code involving now-removed Fullscreen permission.

BUG= 591896 

Review-Url: https://codereview.chromium.org/2470043002
Cr-Commit-Position: refs/heads/master@{#429525}

[modify] https://crrev.com/cb853fe9971aac49e05c17e24ce06e1c12bc9157/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java
[delete] https://crrev.com/03e91a8a23d50943760df3c84a5439fbbc2c0e59/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/FullscreenInfo.java
[modify] https://crrev.com/cb853fe9971aac49e05c17e24ce06e1c12bc9157/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java
[modify] https://crrev.com/cb853fe9971aac49e05c17e24ce06e1c12bc9157/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsCategory.java
[modify] https://crrev.com/cb853fe9971aac49e05c17e24ce06e1c12bc9157/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/Website.java
[modify] https://crrev.com/cb853fe9971aac49e05c17e24ce06e1c12bc9157/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePermissionsFetcher.java
[modify] https://crrev.com/cb853fe9971aac49e05c17e24ce06e1c12bc9157/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreferenceBridge.java
[modify] https://crrev.com/cb853fe9971aac49e05c17e24ce06e1c12bc9157/chrome/android/java_sources.gni
[modify] https://crrev.com/cb853fe9971aac49e05c17e24ce06e1c12bc9157/chrome/browser/android/preferences/pref_service_bridge.cc
[modify] https://crrev.com/cb853fe9971aac49e05c17e24ce06e1c12bc9157/chrome/browser/android/preferences/website_preference_bridge.cc

Comment 15 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
Project Member

Comment 16 by bugdroid1@chromium.org, Nov 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/273b9672cfbf83ffed8f52a91cb59a6e78a64577

commit 273b9672cfbf83ffed8f52a91cb59a6e78a64577
Author: mgiuca <mgiuca@chromium.org>
Date: Fri Nov 11 02:22:20 2016

Deleted CONTENT_SETTINGS_TYPE_FULLSCREEN and MOUSELOCK.

Fullscreen and mouselock content settings have not been used for some
time. The pref data was recently deleted and now all code associated
with these settings is vestigial.

BUG= 591896 , 610900 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2419413002
Cr-Commit-Position: refs/heads/master@{#431465}

[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/chrome/browser/content_settings/host_content_settings_map_unittest.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/chrome/browser/extensions/api/content_settings/content_settings_store.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/chrome/browser/extensions/api/content_settings/content_settings_store_unittest.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/chrome/browser/resources/settings/site_settings/site_settings_behavior.js
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/chrome/browser/resources/settings/site_settings/site_settings_category.js
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/chrome/browser/ui/exclusive_access/fullscreen_controller_browsertest.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/chrome/browser/ui/website_settings/permission_menu_model.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/chrome/browser/ui/website_settings/permission_menu_model_unittest.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/chrome/browser/ui/website_settings/website_settings.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/chrome/browser/ui/website_settings/website_settings_ui.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/chrome/browser/ui/website_settings/website_settings_unittest.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/chrome/browser/ui/webui/options/content_settings_handler.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/chrome/browser/ui/webui/settings/site_settings_handler.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/chrome/browser/ui/webui/site_settings_helper.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/chrome/test/ppapi/ppapi_interactive_browsertest.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/components/content_settings/core/browser/content_settings_default_provider.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/components/content_settings/core/browser/content_settings_pref_provider.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/components/content_settings/core/browser/content_settings_registry.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/components/content_settings/core/common/content_settings.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/components/content_settings/core/common/content_settings_types.h
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/ppapi/tests/test_mouse_lock.cc
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/ppapi/tests/test_mouse_lock.h
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/tools/metrics/actions/actions.xml
[modify] https://crrev.com/273b9672cfbf83ffed8f52a91cb59a6e78a64577/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)

Sign in to add a comment