[Blimp Engine] Simplify ThreadPipeManagerTest to remove message loop-back |
|||||
Issue description
In particular,
per Kevin M comments on issue 1647193003, ThreadPipeManagerTest can use a mockable BlimpMessageProcessor on target |thread_| instead of using looping back FakeFeature.
RegisterFeature(...) {
// check that we are sequenced on thread_
return MockRegisterFeature(type, incoming_processor);
}
MOCK_METHOD2(MockRegisterFeature, BlimpMessageProcessor*(type,
incoming_processor).
,
Mar 4 2016
FWIW I'd suggest having a custom ThreadCheckingMessageProcessor that is constructed with the task-runner for the thread on which it expects to be run. See https://code.google.com/p/chromium/codesearch#chromium/src/remoting/protocol/video_frame_pump_unittest.cc&sq=package:chromium&l=74 (ThreadCheckVideoEncoder) for a similar situation.
,
Mar 24 2016
,
Mar 31 2016
,
Nov 15 2016
Closing out as this will be removed once we migrate to new transport.
,
Dec 9 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by haibinlu@chromium.org
, Mar 4 2016