New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 591874 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Need UMA metrics for Net.DailyContentSavingPercent_* for video

Project Member Reported by bol...@chromium.org, Mar 4 2016

Issue description

We need the daily saving percentage UMA for videos.

It seems that we have

Net.DailyOriginalContentLength_DataReductionProxyEnabled_Video
Net.DailyOriginalContentLength_ViaDataReductionProxy_Video

and

Net.DailyContentLength_DataReductionProxyEnabled_Video
Net.DailyContentLength_ViaDataReductionProxy_Video

But we don't have related Net.DailyContentSavingPercent_* for video, which is more important for than the absolute daily bytes.

More specifically, we need to add
Net.DailyContentSavingPercent_DataReductionProxyEnabled_Video and
Net.DailyContentSavingPercent_ViaDataReductionProxy

Their meaning will be similar to the ones without "_Video" suffix, but for "video/*" Content-Type only.

 

Comment 1 by bengr@chromium.org, Mar 6 2016

Owner: ryansturm@chromium.org
Ryan, could you jump on this? It's pretty important. Thanks.
Status: Started (was: Assigned)

Comment 3 by mdw@chromium.org, Mar 29 2016

Labels: ReleaseBlock-Stable

Comment 4 by mdw@chromium.org, Mar 29 2016

Labels: -ReleaseBlock-Stable

Comment 5 by mdw@chromium.org, Mar 29 2016

Sorry, did not mean to edit this bug...

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc1cf83356706986647d5a77f39e060a499dce82

commit cc1cf83356706986647d5a77f39e060a499dce82
Author: ryansturm <ryansturm@chromium.org>
Date: Tue Apr 12 18:22:28 2016

Adding UMA for daily video percent savings for data reduction proxy

This will track the savings percent of video that went through flywheel
and the video that was downloaded while flywheel was enabled on a daily
basis.

BUG= 591874 

Review URL: https://codereview.chromium.org/1771093002

Cr-Commit-Position: refs/heads/master@{#386743}

[modify] https://crrev.com/cc1cf83356706986647d5a77f39e060a499dce82/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc
[modify] https://crrev.com/cc1cf83356706986647d5a77f39e060a499dce82/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)
Ryan,

This does not seem to working as expected, we have data for all the content lengths case, but not data for 

Net.DailyContentSavingPercent_ViaDataReductionProxy_Video
Net.DailyContentSavingPercent_DataReductionProxyEnabled_Video

can you take a look?

Currently the metric is including users who don't watch video at all.

My suggestion for scoping these down:

Scoping Net.DailyContentSavingPercent_ViaDataReductionProxy_Video to users who have any video bytes via the proxy server.

Scoping Net.DailyContentSavingPercent_DataReductionProxyEnabled_Video to users who have any video bytes with data reduction proxy enabled.

Scoping this down as described above:

https://codereview.chromium.org/1956773003
Status: Started (was: Fixed)
Project Member

Comment 13 by bugdroid1@chromium.org, May 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f76fc2bbe58660f61465a6746e8f411d636c7b65

commit f76fc2bbe58660f61465a6746e8f411d636c7b65
Author: ryansturm <ryansturm@chromium.org>
Date: Fri May 06 22:23:09 2016

UMA for data reduction proxy video percentages are being
reported when users don't watch video.

This change scopes down the reporting to only happen when the
user is served video with data reduction proxy enabled and
via data reduction proxy for the two respective histograms.

BUG= 591874 

Review-Url: https://codereview.chromium.org/1956773003
Cr-Commit-Position: refs/heads/master@{#392183}

[modify] https://crrev.com/f76fc2bbe58660f61465a6746e8f411d636c7b65/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc
[modify] https://crrev.com/f76fc2bbe58660f61465a6746e8f411d636c7b65/tools/metrics/histograms/histograms.xml

Labels: -M-50 M-52
Status: Fixed (was: Started)
Labels: VerifyIn-55

Comment 16 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 17 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 18 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 19 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 20 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 22 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment