New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 591873 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 27 days ago
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Perf tryjob for all-win sets incorrect config for win 32 platforms

Project Member Reported by pras...@chromium.org, Mar 4 2016

Issue description

When running Perf tryjob on all-win platforms, the config generated by trybot_command for win32 is incorrect.

https://build.chromium.org/p/tryserver.chromium.perf/builders/win_perf_bisect/builds/6380/steps/load%20config/logs/json.output

Incorrect config
{
  "command": "python tools\\perf\\run_benchmark --browser=release_x64 page_cycler.typical_25", 
  "max_time_minutes": "120", 
  "repeat_count": "1", 
  "target_arch": "x64", 
  "truncate_percent": "0"
}

Expected config
{
  "command": "python tools\\perf\\run_benchmark --browser=release page_cycler.typical_25", 
  "max_time_minutes": "120", 
  "repeat_count": "1", 
  "target_arch": "ia32", 
  "truncate_percent": "0"
}
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b94d8c2f422327a5a0d5c53aa9e04bb96e35dc3

commit 7b94d8c2f422327a5a0d5c53aa9e04bb96e35dc3
Author: prasadv <prasadv@chromium.org>
Date: Fri Mar 04 02:42:12 2016

Create separate list for win and win-64 bisect in order to generate appropriate perf config.

BUG= 591873 

Review URL: https://codereview.chromium.org/1759183003

Cr-Commit-Position: refs/heads/master@{#379188}

[modify] https://crrev.com/7b94d8c2f422327a5a0d5c53aa9e04bb96e35dc3/tools/perf/core/trybot_command.py
[modify] https://crrev.com/7b94d8c2f422327a5a0d5c53aa9e04bb96e35dc3/tools/perf/core/trybot_command_unittest.py

Status: Fixed (was: Started)
Components: Speed>Bisection

Sign in to add a comment