Consolidate MPEG*_AAC_* Codec values |
|||
Issue description
MimeUtil's Codec enum contains six entries for AAC - three each for the MPEG2 and MPEG4 variants:
MPEG2_AAC_LC,
MPEG2_AAC_MAIN,
MPEG2_AAC_SSR,
MPEG4_AAC_LC,
MPEG4_AAC_SBR_v1,
MPEG4_AAC_SBR_PS_v2,
Each set is always used together. In other words, all three suffixes are either all supported or not supported. Now that the H.264 profiles have been consolidated into a single enum, this is the only remaining codec that is broken out like this.
We should consolidate to two enum values (and potentially one if we can resolve issue 544268 ).
,
Mar 5 2016
,
Mar 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f52bd5bf94cf63512e6de19ad25181cabc641357 commit f52bd5bf94cf63512e6de19ad25181cabc641357 Author: ddorwin <ddorwin@chromium.org> Date: Wed Mar 09 02:50:59 2016 Consolidate MPEG*_AAC_* MimeUtil::Codec enum values We don't differentiate between the profiles, so we do not need separate values. Also remove duplicate video codec strings from kFormatCodecMappings. BUG= 591869 TEST=content_browsertests --gtest_filter=MediaCanPlayTypeTest* Review URL: https://codereview.chromium.org/1769833003 Cr-Commit-Position: refs/heads/master@{#380045} [modify] https://crrev.com/f52bd5bf94cf63512e6de19ad25181cabc641357/content/browser/media/media_canplaytype_browsertest.cc [modify] https://crrev.com/f52bd5bf94cf63512e6de19ad25181cabc641357/media/base/mime_util_internal.cc [modify] https://crrev.com/f52bd5bf94cf63512e6de19ad25181cabc641357/media/base/mime_util_internal.h [modify] https://crrev.com/f52bd5bf94cf63512e6de19ad25181cabc641357/media/base/mime_util_unittest.cc
,
Mar 9 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by ddorwin@chromium.org
, Mar 4 2016