Last compiler update was a lot of months ago. This is meta issue for all related frontend code changes.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/942c361cdadfa17a6d8d0464b7afcf3efe4b0c82 commit 942c361cdadfa17a6d8d0464b7afcf3efe4b0c82 Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Fri Mar 04 02:58:40 2016 [DevTools] Remove Array.from method from utilities.js Last stable Chrome supports native Array.from. R=dgozman@chromium.org BUG= 591865 Review URL: https://codereview.chromium.org/1765733002 Cr-Commit-Position: refs/heads/master@{#379192} [modify] https://crrev.com/942c361cdadfa17a6d8d0464b7afcf3efe4b0c82/third_party/WebKit/Source/devtools/front_end/Runtime.js [modify] https://crrev.com/942c361cdadfa17a6d8d0464b7afcf3efe4b0c82/third_party/WebKit/Source/devtools/front_end/externs.js [modify] https://crrev.com/942c361cdadfa17a6d8d0464b7afcf3efe4b0c82/third_party/WebKit/Source/devtools/front_end/platform/utilities.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/101058cde76dc4d5b385a770bb799a2eefb816bf commit 101058cde76dc4d5b385a770bb799a2eefb816bf Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Fri Mar 04 04:55:42 2016 [DevTools] Prepare UI module for closure compiler roll BUG= 591865 R=lushnikov@chromium.org Review URL: https://codereview.chromium.org/1760093003 Cr-Commit-Position: refs/heads/master@{#379215} [modify] https://crrev.com/101058cde76dc4d5b385a770bb799a2eefb816bf/third_party/WebKit/Source/devtools/front_end/platform/utilities.js [modify] https://crrev.com/101058cde76dc4d5b385a770bb799a2eefb816bf/third_party/WebKit/Source/devtools/front_end/ui/ContextMenu.js [modify] https://crrev.com/101058cde76dc4d5b385a770bb799a2eefb816bf/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js [modify] https://crrev.com/101058cde76dc4d5b385a770bb799a2eefb816bf/third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js [modify] https://crrev.com/101058cde76dc4d5b385a770bb799a2eefb816bf/third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js [modify] https://crrev.com/101058cde76dc4d5b385a770bb799a2eefb816bf/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3053098da46ad929bbebfdb914203eeddd3fdfdd commit 3053098da46ad929bbebfdb914203eeddd3fdfdd Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Fri Mar 04 07:36:02 2016 [DevTools] Fix compiler errors in bindings module BUG= 591865 R=lushnikov@chromium.org Review URL: https://codereview.chromium.org/1763883003 Cr-Commit-Position: refs/heads/master@{#379240} [modify] https://crrev.com/3053098da46ad929bbebfdb914203eeddd3fdfdd/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js [modify] https://crrev.com/3053098da46ad929bbebfdb914203eeddd3fdfdd/third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js [modify] https://crrev.com/3053098da46ad929bbebfdb914203eeddd3fdfdd/third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e92b321e3356b463f671e6b8004f8c38d76cc6ad commit e92b321e3356b463f671e6b8004f8c38d76cc6ad Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Fri Mar 04 16:17:18 2016 [DevTools] Fix compile errors before closure compiler roll BUG= 591865 R=lushnikov@chromium.org Review URL: https://codereview.chromium.org/1761243002 Cr-Commit-Position: refs/heads/master@{#379295} [modify] https://crrev.com/e92b321e3356b463f671e6b8004f8c38d76cc6ad/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityNodeView.js [modify] https://crrev.com/e92b321e3356b463f671e6b8004f8c38d76cc6ad/third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js [modify] https://crrev.com/e92b321e3356b463f671e6b8004f8c38d76cc6ad/third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js [modify] https://crrev.com/e92b321e3356b463f671e6b8004f8c38d76cc6ad/third_party/WebKit/Source/devtools/front_end/bindings/TempFile.js [modify] https://crrev.com/e92b321e3356b463f671e6b8004f8c38d76cc6ad/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js [modify] https://crrev.com/e92b321e3356b463f671e6b8004f8c38d76cc6ad/third_party/WebKit/Source/devtools/front_end/devices/DevicesView.js [modify] https://crrev.com/e92b321e3356b463f671e6b8004f8c38d76cc6ad/third_party/WebKit/Source/devtools/front_end/elements/ElementsBreadcrumbs.js [modify] https://crrev.com/e92b321e3356b463f671e6b8004f8c38d76cc6ad/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js [modify] https://crrev.com/e92b321e3356b463f671e6b8004f8c38d76cc6ad/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js [modify] https://crrev.com/e92b321e3356b463f671e6b8004f8c38d76cc6ad/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js [modify] https://crrev.com/e92b321e3356b463f671e6b8004f8c38d76cc6ad/third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js [modify] https://crrev.com/e92b321e3356b463f671e6b8004f8c38d76cc6ad/third_party/WebKit/Source/devtools/front_end/resources/DatabaseModel.js [modify] https://crrev.com/e92b321e3356b463f671e6b8004f8c38d76cc6ad/third_party/WebKit/Source/devtools/front_end/sources/FilePathScoreFunction.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c6677f6d346364b23581302dbb3a2d3905bf873 commit 9c6677f6d346364b23581302dbb3a2d3905bf873 Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Sat Mar 05 00:58:37 2016 [DevTools] Fix more frontend compiler errors BUG= 591865 R=lushnikov@chromium.org Review URL: https://codereview.chromium.org/1763193002 Cr-Commit-Position: refs/heads/master@{#379420} [modify] https://crrev.com/9c6677f6d346364b23581302dbb3a2d3905bf873/third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js [modify] https://crrev.com/9c6677f6d346364b23581302dbb3a2d3905bf873/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js [modify] https://crrev.com/9c6677f6d346364b23581302dbb3a2d3905bf873/third_party/WebKit/Source/devtools/front_end/externs.js [modify] https://crrev.com/9c6677f6d346364b23581302dbb3a2d3905bf873/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileFlameChart.js [modify] https://crrev.com/9c6677f6d346364b23581302dbb3a2d3905bf873/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotProxy.js [modify] https://crrev.com/9c6677f6d346364b23581302dbb3a2d3905bf873/third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js [modify] https://crrev.com/9c6677f6d346364b23581302dbb3a2d3905bf873/third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js [modify] https://crrev.com/9c6677f6d346364b23581302dbb3a2d3905bf873/third_party/WebKit/Source/devtools/front_end/timeline/LayerTreeModel.js [modify] https://crrev.com/9c6677f6d346364b23581302dbb3a2d3905bf873/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js [modify] https://crrev.com/9c6677f6d346364b23581302dbb3a2d3905bf873/third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9441c5e62f2a8caf30b8d5709ad374bb1dc6432c commit 9441c5e62f2a8caf30b8d5709ad374bb1dc6432c Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Tue Mar 08 21:53:32 2016 [DevTools] Roll closure compiler to ToT version Closure version: commit e89bb281f3dbf72c20f1a86e3313831f943be688 Date: Mon Mar 7 08:27:56 2016 -0800 Array.prototype.push supports type checking. Better arrow function support. Removed third_party/WebKit/Source/devtools/front_end/es6.js. BUG= 591865 R=alph@chromium.org, caseq@chromium.org, lushnikov@chromium.org, dgozman@chromium.org TBR=sergeyv@chromium.org Review URL: https://codereview.chromium.org/1774503005 . Cr-Commit-Position: refs/heads/master@{#379920} [delete] https://crrev.com/a76a64fc18d8ee0578b7e5588d0f948f21a1fb9b/third_party/WebKit/Source/devtools/front_end/es6.js [modify] https://crrev.com/9441c5e62f2a8caf30b8d5709ad374bb1dc6432c/third_party/WebKit/Source/devtools/front_end/externs.js [modify] https://crrev.com/9441c5e62f2a8caf30b8d5709ad374bb1dc6432c/third_party/WebKit/Source/devtools/front_end/platform/utilities.js [modify] https://crrev.com/9441c5e62f2a8caf30b8d5709ad374bb1dc6432c/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js [modify] https://crrev.com/9441c5e62f2a8caf30b8d5709ad374bb1dc6432c/third_party/WebKit/Source/devtools/front_end/sass/ASTSourceMap.js [modify] https://crrev.com/9441c5e62f2a8caf30b8d5709ad374bb1dc6432c/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js [modify] https://crrev.com/9441c5e62f2a8caf30b8d5709ad374bb1dc6432c/third_party/WebKit/Source/devtools/front_end/timeline/TimelineProfileTree.js [modify] https://crrev.com/9441c5e62f2a8caf30b8d5709ad374bb1dc6432c/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js [modify] https://crrev.com/9441c5e62f2a8caf30b8d5709ad374bb1dc6432c/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js [modify] https://crrev.com/9441c5e62f2a8caf30b8d5709ad374bb1dc6432c/third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js [modify] https://crrev.com/9441c5e62f2a8caf30b8d5709ad374bb1dc6432c/third_party/WebKit/Source/devtools/scripts/closure/compiler.jar [modify] https://crrev.com/9441c5e62f2a8caf30b8d5709ad374bb1dc6432c/third_party/WebKit/Source/devtools/scripts/compile_frontend.py [modify] https://crrev.com/9441c5e62f2a8caf30b8d5709ad374bb1dc6432c/third_party/WebKit/Source/devtools/scripts/compiler-runner/closure-runner.jar [modify] https://crrev.com/9441c5e62f2a8caf30b8d5709ad374bb1dc6432c/third_party/WebKit/Source/devtools/scripts/compiler-runner/src/org/chromium/devtools/compiler/Runner.java [modify] https://crrev.com/9441c5e62f2a8caf30b8d5709ad374bb1dc6432c/third_party/WebKit/Source/devtools/scripts/jsdoc-validator/hashes [modify] https://crrev.com/9441c5e62f2a8caf30b8d5709ad374bb1dc6432c/third_party/WebKit/Source/devtools/scripts/jsdoc-validator/jsdoc-validator.jar [modify] https://crrev.com/9441c5e62f2a8caf30b8d5709ad374bb1dc6432c/third_party/WebKit/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/FileCheckerCallable.java
This roll has taken compiles from 3min to 13min on some machines. On my machine, it was stuck compiling for >40 minutes. Is anyone investigating these performance regressions?
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1435f441749ab0acc8d06642108546de899f4f3 commit a1435f441749ab0acc8d06642108546de899f4f3 Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Sat May 07 01:08:59 2016 [DevTools] roll closure compiler to ToT Improvements: - better type inference, - better CSSStyleDeclaration property check. Closure compiler version: commit 6b49cfd9022fe111bdad745c78ea877fbc2f7ba3 Date: Tue Nov 3 23:51:57 2009 +0000 BUG= 591865 R=lushnikov@chromium.org, pfeldman@chromium.org Review URL: https://codereview.chromium.org/1956703004 . Cr-Commit-Position: refs/heads/master@{#392227} [modify] https://crrev.com/a1435f441749ab0acc8d06642108546de899f4f3/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js [modify] https://crrev.com/a1435f441749ab0acc8d06642108546de899f4f3/third_party/WebKit/Source/devtools/front_end/ui_lazy/OverviewGrid.js [modify] https://crrev.com/a1435f441749ab0acc8d06642108546de899f4f3/third_party/WebKit/Source/devtools/scripts/closure/compiler.jar
Comment 1 by bugdroid1@chromium.org
, Mar 4 2016