gn gen error should be fatal |
||
Issue descriptionsee https://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/1235/steps/generate_build_files%20%28with%20patch%29/logs/stdio I had a gn check failure. the step failed, but the try run continued probably using old ninja files which is confusing. Filing bug per Dirk.
,
Mar 4 2016
Hmm, okay, looking at this more, I don't know what happened. It looks like the GN failure was fatal (the next step after that was re-running bot update to de-apply the patch. And, we re-ran GN after that, so everything should've been fine. @jam, did you end up getting your patch working and/or have to change anything to land it? If there's something more here to dig into, let me know and/or reopen this ... |
||
►
Sign in to add a comment |
||
Comment 1 by dpranke@chromium.org
, Mar 4 2016