New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 591820 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Not currently working on Chromium
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 565736



Sign in to add a comment

Remove Web Bluetooth from Experimental in M50.

Project Member Reported by scheib@chromium.org, Mar 3 2016

Issue description

Remove Web Bluetooth from Experimental in M50. Shipping the experiment has blockers as defined in  issue 565736 .
 

Comment 2 by tin...@google.com, Mar 4 2016

Pls add OS. Thanks.
Labels: OS-All
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c113ac03cbf3d44926c6584d1755a82834dd0b4

commit 0c113ac03cbf3d44926c6584d1755a82834dd0b4
Author: scheib <scheib@chromium.org>
Date: Tue Mar 08 18:20:37 2016

Remove Web Bluetooth from Experimental in M50.

Shipping the experiment has blockers as defined in
 https://crbug.com/565736  that are not satisfied in M50.

This essentially reverts https://crrev.com/1662183002.
When re-enabling copy the TEST instructions from there.

BUG= 591820 

Review URL: https://codereview.chromium.org/1763923002

Cr-Commit-Position: refs/heads/master@{#379864}

[modify] https://crrev.com/0c113ac03cbf3d44926c6584d1755a82834dd0b4/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/0c113ac03cbf3d44926c6584d1755a82834dd0b4/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/0c113ac03cbf3d44926c6584d1755a82834dd0b4/third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp
[modify] https://crrev.com/0c113ac03cbf3d44926c6584d1755a82834dd0b4/third_party/WebKit/Source/modules/bluetooth/Bluetooth.idl
[modify] https://crrev.com/0c113ac03cbf3d44926c6584d1755a82834dd0b4/third_party/WebKit/Source/modules/bluetooth/BluetoothAdvertisingData.idl
[modify] https://crrev.com/0c113ac03cbf3d44926c6584d1755a82834dd0b4/third_party/WebKit/Source/modules/bluetooth/BluetoothCharacteristicProperties.idl
[modify] https://crrev.com/0c113ac03cbf3d44926c6584d1755a82834dd0b4/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.idl
[modify] https://crrev.com/0c113ac03cbf3d44926c6584d1755a82834dd0b4/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.idl
[modify] https://crrev.com/0c113ac03cbf3d44926c6584d1755a82834dd0b4/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.idl
[modify] https://crrev.com/0c113ac03cbf3d44926c6584d1755a82834dd0b4/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.idl
[modify] https://crrev.com/0c113ac03cbf3d44926c6584d1755a82834dd0b4/third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.idl
[modify] https://crrev.com/0c113ac03cbf3d44926c6584d1755a82834dd0b4/third_party/WebKit/Source/modules/bluetooth/NavigatorBluetooth.idl
[modify] https://crrev.com/0c113ac03cbf3d44926c6584d1755a82834dd0b4/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/0c113ac03cbf3d44926c6584d1755a82834dd0b4/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Cc: durga.behera@chromium.org
Labels: Needs-Feedback
scheib@ : The #enable-web-bluetooth flag is available on Dev 50.0.2661.18	 still, and its disabled in canary 51.0.2677.0.Could you please take a look into this and update further.

Comment 6 by scheib@chromium.org, Mar 14 2016

Labels: -Needs-Feedback Merge-Request-50
The enable-web-bluetooth flag will remain, but the feature will be removed from the experimental framework. 
https://docs.google.com/document/d/1qVP2CK1lbfmtIJRIm6nwuEFFhGhYbtThLQPo3CSTtmg/edit

Now that the removal has been in Canary several days, and I don't see any issues or crash reports, requesting merge.

Comment 7 by tin...@google.com, Mar 14 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 14 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/524ae8b6372dec986a4d3e61a3bbc4f38e1ec010

commit 524ae8b6372dec986a4d3e61a3bbc4f38e1ec010
Author: Vincent Scheib <scheib@chromium.org>
Date: Mon Mar 14 20:55:28 2016

Remove Web Bluetooth from Experimental in M50.

Shipping the experiment has blockers as defined in
 https://crbug.com/565736  that are not satisfied in M50.

This essentially reverts https://crrev.com/1662183002.
When re-enabling copy the TEST instructions from there.

BUG= 591820 

Review URL: https://codereview.chromium.org/1763923002

Cr-Commit-Position: refs/heads/master@{#379864}
(cherry picked from commit 0c113ac03cbf3d44926c6584d1755a82834dd0b4)

Review URL: https://codereview.chromium.org/1802043002 .

Cr-Commit-Position: refs/branch-heads/2661@{#222}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/524ae8b6372dec986a4d3e61a3bbc4f38e1ec010/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/524ae8b6372dec986a4d3e61a3bbc4f38e1ec010/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/524ae8b6372dec986a4d3e61a3bbc4f38e1ec010/third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp
[modify] https://crrev.com/524ae8b6372dec986a4d3e61a3bbc4f38e1ec010/third_party/WebKit/Source/modules/bluetooth/Bluetooth.idl
[modify] https://crrev.com/524ae8b6372dec986a4d3e61a3bbc4f38e1ec010/third_party/WebKit/Source/modules/bluetooth/BluetoothAdvertisingData.idl
[modify] https://crrev.com/524ae8b6372dec986a4d3e61a3bbc4f38e1ec010/third_party/WebKit/Source/modules/bluetooth/BluetoothCharacteristicProperties.idl
[modify] https://crrev.com/524ae8b6372dec986a4d3e61a3bbc4f38e1ec010/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.idl
[modify] https://crrev.com/524ae8b6372dec986a4d3e61a3bbc4f38e1ec010/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.idl
[modify] https://crrev.com/524ae8b6372dec986a4d3e61a3bbc4f38e1ec010/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.idl
[modify] https://crrev.com/524ae8b6372dec986a4d3e61a3bbc4f38e1ec010/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.idl
[modify] https://crrev.com/524ae8b6372dec986a4d3e61a3bbc4f38e1ec010/third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.idl
[modify] https://crrev.com/524ae8b6372dec986a4d3e61a3bbc4f38e1ec010/third_party/WebKit/Source/modules/bluetooth/NavigatorBluetooth.idl
[modify] https://crrev.com/524ae8b6372dec986a4d3e61a3bbc4f38e1ec010/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/524ae8b6372dec986a4d3e61a3bbc4f38e1ec010/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Comment 9 by scheib@chromium.org, Mar 14 2016

Status: Fixed (was: Started)

Sign in to add a comment