New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 591782 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

fix silent failures in chromeos-chrome.ebuild

Project Member Reported by ihf@chromium.org, Mar 3 2016

Issue description

Many file operations in the ebuild fail silently. Often we only see the impact in build_packages/build_image much later. Fail early.
 

Comment 1 by ihf@chromium.org, Mar 3 2016

Components: Build
Labels: M-51
I have landed a change
https://chromium-review.googlesource.com/#/c/330201/

but the cleanup is taking longer than expected
https://chromium-review.googlesource.com/#/c/330127/1

I will revert the first change and land when everything is clean.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/425528bea361d396becfa36552fe99fc2abba1a9

commit 425528bea361d396becfa36552fe99fc2abba1a9
Author: Ilja Friedel <ihf@chromium.org>
Date: Thu Mar 03 20:00:22 2016

Revert "chromeos-chrome: die early."

This reverts commit 9ea2c632d2610b2fe81cad84359af0c2af352556.

The insights from the bot were limited. I will reland at a later time once the cleanup is ready.

BUG= chromium:591782 ,  chromium:591401 

Change-Id: Ie5357ca4213a60694380e9cc269062e34387ea8e
Reviewed-on: https://chromium-review.googlesource.com/330198
Reviewed-by: Ilja Friedel <ihf@chromium.org>
Tested-by: Ilja Friedel <ihf@chromium.org>

[modify] https://crrev.com/425528bea361d396becfa36552fe99fc2abba1a9/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

Comment 3 by ihf@chromium.org, Mar 3 2016

Labels: Build-PFQ-Code-Yellow Arch-All
Most of this will surface telemetry failures earlier, but also other tests with Chrome dependencies.

Comment 4 by ihf@chromium.org, Mar 3 2016

Cc: wiley@chromium.org cywang@chromium.org
 Issue 591731  has been merged into this issue.
Labels: -Build-PFQ-Code-Yellow gardener
Removing P2 issues from CodeYellow (but please still work on these!)

Comment 6 by wiley@chromium.org, Mar 7 2016

Cc: -wiley@chromium.org
Labels: -gardener Hotlist-CrOSGardener
Labels: Hotlist-CrOS-Gardener
Components: -Build Infra>Client>ChromeOS
Status: Archived (was: Assigned)
Bulk closing Infra>Client>ChromeOS issues untouched in over a year.

Sign in to add a comment