New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 591778 link

Starred by 1 user
Status: Fixed
Owner:
drott@chromium.org
Closed: Mar 2016
Cc:
█ dim...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Revert: https://codereview.chromium.org/1672553004 broke font layout tests

Project Member Reported by dim...@chromium.org, Mar 3 2016 
Example of broken run:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/7227

Snippet:

Regressions: Unexpected text-only failures (1)
  inspector-protocol/layout-fonts/languages-emoji-rare-glyphs.html [ Failure ]

Regressions: Unexpected image-only failures (1)
  fast/text/unicode-fallback-font.html [ Failure ]

Comment 2 by cbiesin...@chromium.org, Mar 3 2016

Components: Blink>Fonts
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/508edd3841b53f2f6063c6a6ef58f34a4e41e71c

commit 508edd3841b53f2f6063c6a6ef58f34a4e41e71c
Author: drott <drott@chromium.org>
Date: Fri Mar 04 08:46:51 2016

Reland: Use FontFallbackPriority Fonts in FontFallbackIterator

Now that the pieces are in place, use the emoji and symbol fonts in
FontFallbackIterator. Previously FontCache's character fallback
functions were extended so that they take FontFallbackPriority into
account. These functions can now be used in FontFallbackIterator as a
fallback priority stage where those fonts are used as the first fallback
font in order to correctly distinguish between emoji and text
presentation emoji.

Relanded after revert in https://codereview.chromium.org/1758383002/
Rebaselining the test results since now the emoji font is used more
often.

Original issue LGTM'ed in https://codereview.chromium.org/1672553004/

BUG=549571, 591778 
TBR=eae, behdad

Review URL: https://codereview.chromium.org/1764933002

Cr-Commit-Position: refs/heads/master@{#379249}

[modify] https://crrev.com/508edd3841b53f2f6063c6a6ef58f34a4e41e71c/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/508edd3841b53f2f6063c6a6ef58f34a4e41e71c/third_party/WebKit/Source/platform/fonts/Font.cpp
[modify] https://crrev.com/508edd3841b53f2f6063c6a6ef58f34a4e41e71c/third_party/WebKit/Source/platform/fonts/Font.h
[modify] https://crrev.com/508edd3841b53f2f6063c6a6ef58f34a4e41e71c/third_party/WebKit/Source/platform/fonts/FontDataRange.h
[modify] https://crrev.com/508edd3841b53f2f6063c6a6ef58f34a4e41e71c/third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp
[modify] https://crrev.com/508edd3841b53f2f6063c6a6ef58f34a4e41e71c/third_party/WebKit/Source/platform/fonts/FontFallbackIterator.h
[modify] https://crrev.com/508edd3841b53f2f6063c6a6ef58f34a4e41e71c/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp

Comment 4 by drott@chromium.org, Mar 4 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment