New issue
Advanced search Search tips

Issue 591777 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Exclude the invisible audio nodes from primary active node selection and don't persist their active state in user prefs

Project Member Reported by jen...@chromium.org, Mar 3 2016

Issue description

Version: R51
OS: Chrome

Among the audio nodes cras sends to chrome, some of them are invisible to end user but could be used by other media API, such as:
  AUDIO_TYPE_KEYBOARD_MIC,
  AUDIO_TYPE_AOKR,
  AUDIO_TYPE_POST_MIX_LOOPBACK,
  AUDIO_TYPE_POST_DSP_LOOPBACK,

These nodes will not show up in ash tray to users, and won't be selected as primary active nodes, but they could be added as additional active nodes by some other apps. Therefore, we should exclude these nodes from primary active node selection logic, and not persist their active state in the user prefs either.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b46664f407fa853f2573f05db37784b04f5a013c

commit b46664f407fa853f2573f05db37784b04f5a013c
Author: jennyz <jennyz@chromium.org>
Date: Tue Mar 08 18:18:10 2016

Exclude non-simple-usage audio nodes from being selected as primary node, and do not persist their active state in prefs.

BUG= 591777 

Review URL: https://codereview.chromium.org/1759103003

Cr-Commit-Position: refs/heads/master@{#379861}

[modify] https://crrev.com/b46664f407fa853f2573f05db37784b04f5a013c/chromeos/audio/cras_audio_handler.cc
[modify] https://crrev.com/b46664f407fa853f2573f05db37784b04f5a013c/chromeos/audio/cras_audio_handler_unittest.cc

Status: Fixed (was: Started)
No visible change on UI side. Just verify everything related to audio just works.
Labels: M-51

Sign in to add a comment