New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 591765 link

Starred by 0 users

Issue metadata

Status: WontFix
Owner:
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

5.4% regression in startup.warm.blank_page at 378772:378796

Project Member Reported by lanwei@google.com, Mar 3 2016

Issue description

See the link to graphs below.
 

Comment 1 by lanwei@google.com, Mar 3 2016

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=591765

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDA36748wgM


Bot(s) for this bug's original alert(s):

chromium-rel-win8-dual

===== BISECT JOB RESULTS =====
Status: completed


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@378771         92.694737   0.205196    5           good
chromium@378778         92.757895   0.43814     5           good
chromium@378781         92.894737   0.539313    5           good
chromium@378784         98.063158   0.258913    5           bad
chromium@378796         98.042105   1.029617    5           bad

Bisect job ran on: win_8_perf_bisect
Bug ID: 591765

Test Command: python src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --also-run-disabled-tests startup.warm.blank_page
Test Metric: window_display_time/window_display_time
Relative Change: 5.77%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/win_8_perf_bisect/builds/1864
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9019184435201060592


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with label Cr-Tests-AutoBisect.  Thank you!
Cc: ashej...@chromium.org
Bisect re-kicked with wider revision range.

Details on the below link:
-------------------------
https://chromeperf.appspot.com/group_report?bug_id=591765

Thank you!
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Mar 11 2016

Cc: robliao@chromium.org
Owner: robliao@chromium.org

=== Auto-CCing suspected CL author robliao@chromium.org ===

Hi robliao@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Revert of Make the EarlyInitStartup Code Default (patchset #1 id:1 of https://codereview.chromium.org/1453923002/ )
Author  : robliao
Commit description:
  
Reason for revert:
Reverting - Looks like we can't easily get perf data from the bots.

Original issue's description:
> Make the EarlyInitStartup Code Default
>
> We're satisfied with the performance characteristics of running Extension
> Feature Initialization on a background thread that we'd like to do it
> all the time now.
>
> BUG= 470743 
>
> Committed: https://crrev.com/697fb4718088e9b87a30f21f57168af70ef273ae
> Cr-Commit-Position: refs/heads/master@{#360352}
>
> Committed: https://crrev.com/9b13cbdc3205421a28bd583878c1108ed0eaead0
> Cr-Commit-Position: refs/heads/master@{#378308}

TBR=jochen@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 470743 

Review URL: https://codereview.chromium.org/1749213005

Cr-Commit-Position: refs/heads/master@{#378782}
Commit  : 088106bebeac47281eb94ec5af24f5205b4819a1
Date    : Wed Mar 02 18:42:40 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@378710         92.75       0.934825    12          good
chromium@378752         94.394737   4.785423    12          good
chromium@378768         93.526316   0.789474    5           good
chromium@378776         94.280702   2.584394    12          good
chromium@378780         94.635965   4.319724    12          good
chromium@378781         92.8        0.359671    5           good
chromium@378782         98.692982   0.932589    12          bad
chromium@378784         98.95614    1.944824    12          bad
chromium@378860         98.756579   1.700564    8           bad

Bisect job ran on: win_8_perf_bisect
Bug ID: 591765

Test Command: python src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --also-run-disabled-tests startup.warm.blank_page
Test Metric: window_display_time/window_display_time
Relative Change: 7.24%
Score: 99.0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/win_8_perf_bisect/builds/1878
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9018506127770900368


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with label Cr-Tests-AutoBisect.  Thank you!
Status: WontFix (was: Assigned)
This CL is a revert. The associated code is not in the codebase anymore.
I'll also note this is expect as this is a performance improvement CL. The main mystery that remains is crbug.com/558432

Sign in to add a comment