New issue
Advanced search Search tips

Issue 591757 link

Starred by 0 users

Issue metadata

Status: WontFix
Owner:
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

11.4% regression in page_cycler.basic_oopif at 378972:378979

Project Member Reported by lanwei@google.com, Mar 3 2016

Issue description

See the link to graphs below.
 

Comment 1 by lanwei@google.com, Mar 3 2016

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=591757

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDA36OYvwoM


Bot(s) for this bug's original alert(s):

android-one
Cc: lanwei@chromium.org tdres...@chromium.org
Owner: keishi@chromium.org
Looks like https://chromium.googlesource.com/chromium/src/+/f5ff205e2de07090a8dd52397b2573368fdc3229

Although https://bugs.chromium.org/p/chromium/issues/detail?id=588354#c6 states that there were fewer perf regression with this approach, this still looks pretty bad.

keishi@, is this regression expected?

Feel free to mark WontFix if you think this is reasonable.

Comment 3 by keishi@chromium.org, Mar 23 2016

Status: WontFix (was: Assigned)
Yes as I noted in the bug for the CL, page_cycler.basic_oopif has regressed pretty badly because of it. In the old code we were triggering GC for each iframe creation so my CL reduces that and a slight regression was expected. If you looked at the per page measurments, it looks like nationalgeographic is the only one that regressed. It looks like that particular site may have reacted badly with my change, but since it didn't regress other pages I think this is acceptable. 

Sign in to add a comment