Switch Telemetry's to show console log instead of Javascript page state on failure |
||||
Issue descriptionCurrently, telemetry tries to print out page state using javascript (https://github.com/catapult-project/catapult/blob/40afc53353daf28b955397c8e27d6f1de7bb10b6/telemetry/telemetry/internal/browser/web_contents.py#L107). From my experience, this is rarely useful & just make it harder to debug telemetry log due to huge log spamming. Example: https://build.chromium.org/p/chromium.perf/builders/Win%20Zenbook%20Perf%20%283%29/builds/999/steps/image_decoding.image_decoding_measurement.reference/logs/stdio I think we should at least remove this, and may be replace with something better like showing the inspector log console. Any opinion?
,
Mar 3 2016
Agreed, the page state has hardly ever been useful for debugging test timeouts. The console output (if it isn't already printed) would be much more useful. CC'ing zmo and bajones for more feedback. See Issue 591705 for an issue actively being debugged where the page state isn't giving enough information.
,
Mar 3 2016
Here's another example of a timeout where the console output would be much more useful than the current page state: https://build.chromium.org/p/chromium.gpu/builders/Win7%20Release%20%28NVIDIA%29/builds/45055/steps/webgl_conformance_tests%20on%20NVIDIA%20GPU%20on%20Windows%20on%20Windows-2008ServerR2-SP1/logs/stdio Look for WebglConformance.conformance_textures_image_tex_image_and_sub_image_2d_with_image_rgba_rgba_unsigned_short_4_4_4_4 . Can we make the change to dump the console log instead?
,
Mar 3 2016
I'd be behind switching to the console log instead.
,
Mar 3 2016
Yes.
,
Mar 4 2016
,
Mar 8 2016
Fixed in https://codereview.chromium.org/1765283002/ Please feel free to reopen this if the console logging doesn't work. |
||||
►
Sign in to add a comment |
||||
Comment 1 by sullivan@chromium.org
, Mar 3 2016