New issue
Advanced search Search tips

Issue 591719 link

Starred by 9 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocked on:
issue 387740

Blocking:
issue 674593
issue 800767


Show other hotlists

Hotlists containing this issue:
Non-Standard-IDL


Sign in to add a comment

Blink::MediaStream Remove deprecated createObjectURL()

Project Member Reported by mcasas@chromium.org, Mar 3 2016

Issue description

From [1]
> Changes since October 17, 2013
> ...
> Removed createObjectURL.
> ...

This affects, for starters, [2], but, since the way MediaStreams
are found in Blink (and in content/ too), is via searching for a
url or guid in this registry, the removal might spread around.
Obviously, it needs an Intent To Deprecate [3] etc.


[1] https://www.w3.org/TR/mediacapture-streams/#change-log
[2] https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/modules/mediastream/URLMediaStream.idl&sq=package:chromium&type=cs&l=31
[3] http://www.chromium.org/blink#TOC-Launch-Process:-Deprecation
 
Cc: niklase@chromium.org guidou@chromium.org hta@chromium.org emir...@chromium.org
Adding some interested parties. (I think there was 
no issue tracker for this, please merge in otherwise.)

Comment 2 by hta@chromium.org, Mar 3 2016

Blockedon: 387740
Added to my tracking spreadsheet. Priority definitely after getting HTML.srcObject=stream to work - until then, there is no alternative.

Status: Available (was: Unconfirmed)

Comment 4 by guidou@chromium.org, May 26 2016

Owner: guidou@chromium.org

Comment 5 by hta@webrtc.org, Jun 2 2016

First step is adding relevant use counters. Do we need to count both usage of srcObject and usage of CreateObjectURL(stream)?

Comment 6 by hta@chromium.org, Jan 27 2017

The use counters have been added. CCing @foolip so that he can add links to them.

Comment 7 by hta@chromium.org, Jan 27 2017

Cc: foolip@chromium.org

Comment 8 by hta@chromium.org, Jan 27 2017

A spec bug has been opened to suggest reviving this in the spec, but this did not achieve WG consensus: https://github.com/w3c/mediacapture-main/issues/404

Cc: wolenetz@chromium.org
Blocking: 674593
Status: Assigned (was: Available)
Blocking: 800767
Owner: orphis@chromium.org
Status: Verified (was: Assigned)
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7422130d3da18b70d4cc81951feda2ab615edef9

commit 7422130d3da18b70d4cc81951feda2ab615edef9
Author: Guido Urdaneta <guidou@chromium.org>
Date: Fri Oct 12 11:20:26 2018

Remove MediaStreamRegistry.

This class is useless now that URL.createObjectURL(MediaStream) has
been removed from the Web platform.

Bug:  591719 
Change-Id: I4a56bd8c0cbb86dacab8dafa6acb807509a86367
Reviewed-on: https://chromium-review.googlesource.com/c/1221320
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Philip J├Ągenstedt <foolip@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599170}
[modify] https://crrev.com/7422130d3da18b70d4cc81951feda2ab615edef9/chrome/renderer/extensions/cast_streaming_native_handler.cc
[modify] https://crrev.com/7422130d3da18b70d4cc81951feda2ab615edef9/chrome/renderer/extensions/cast_streaming_native_handler.h
[modify] https://crrev.com/7422130d3da18b70d4cc81951feda2ab615edef9/chrome/renderer/resources/extensions/cast_streaming_receiver_session_custom_bindings.js
[modify] https://crrev.com/7422130d3da18b70d4cc81951feda2ab615edef9/content/public/renderer/media_stream_utils.cc
[modify] https://crrev.com/7422130d3da18b70d4cc81951feda2ab615edef9/content/renderer/media/web_media_element_source_utils.cc
[modify] https://crrev.com/7422130d3da18b70d4cc81951feda2ab615edef9/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/7422130d3da18b70d4cc81951feda2ab615edef9/content/shell/renderer/layout_test/test_media_stream_renderer_factory.cc
[modify] https://crrev.com/7422130d3da18b70d4cc81951feda2ab615edef9/third_party/blink/public/BUILD.gn
[delete] https://crrev.com/68550e484d7eecf6bd1d39fca300644ab2c21f5d/third_party/blink/public/web/web_media_stream_registry.h
[modify] https://crrev.com/7422130d3da18b70d4cc81951feda2ab615edef9/third_party/blink/renderer/core/html/media/html_media_element.cc
[modify] https://crrev.com/7422130d3da18b70d4cc81951feda2ab615edef9/third_party/blink/renderer/core/html/media/html_media_element.h
[modify] https://crrev.com/7422130d3da18b70d4cc81951feda2ab615edef9/third_party/blink/renderer/modules/exported/BUILD.gn
[delete] https://crrev.com/68550e484d7eecf6bd1d39fca300644ab2c21f5d/third_party/blink/renderer/modules/exported/web_media_stream_registry.cc
[modify] https://crrev.com/7422130d3da18b70d4cc81951feda2ab615edef9/third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element.cc
[modify] https://crrev.com/7422130d3da18b70d4cc81951feda2ab615edef9/third_party/blink/renderer/modules/media_controls/elements/media_control_play_button_element.cc
[modify] https://crrev.com/7422130d3da18b70d4cc81951feda2ab615edef9/third_party/blink/renderer/modules/mediacapturefromelement/html_media_element_capture.cc
[modify] https://crrev.com/7422130d3da18b70d4cc81951feda2ab615edef9/third_party/blink/renderer/modules/mediastream/BUILD.gn
[modify] https://crrev.com/7422130d3da18b70d4cc81951feda2ab615edef9/third_party/blink/renderer/modules/mediastream/media_stream.cc
[modify] https://crrev.com/7422130d3da18b70d4cc81951feda2ab615edef9/third_party/blink/renderer/modules/mediastream/media_stream.h
[delete] https://crrev.com/68550e484d7eecf6bd1d39fca300644ab2c21f5d/third_party/blink/renderer/modules/mediastream/media_stream_registry.cc
[delete] https://crrev.com/68550e484d7eecf6bd1d39fca300644ab2c21f5d/third_party/blink/renderer/modules/mediastream/media_stream_registry.h

Sign in to add a comment