DCHECK in HostResolverImpl::ResolveAsIP
Reported by
ascheg...@yandex-team.ru,
Mar 3 2016
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:44.0) Gecko/20100101 Firefox/44.0 Example URL: Steps to reproduce the problem: When proxy is an IP address, ProxyScriptDecider::DoQuickCheck calls resolver with the HOST_RESOLVER_SYSTEM_ONLY flag, and DCHECK in HostResolverImpl::ResolveAsIP fails because it doesn't allow this flag. What is the expected behavior? What went wrong? This DCHECK looks obsolete and should be removed. Did this work before? N/A Chrome version: Channel: n/a OS Version: Flash Version:
,
Mar 3 2016
,
Mar 4 2016
,
Mar 4 2016
,
Mar 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/368a1007f97c81c0d0a8e15a8affdcdd429dad5a commit 368a1007f97c81c0d0a8e15a8affdcdd429dad5a Author: eroman <eroman@chromium.org> Date: Fri Mar 04 21:52:55 2016 Remove an incorrect DCHECK() when calling HostResolverImpl::Resolve() with an IP literal and HOST_RESOLVER_SYSTEM_ONLY flag. The existing DCHECK() what a whitelist for all flags except this one and hence firing. Changing it to include HOST_RESOLVER_SYSTEM_ONLY would make it a trivial whitelist of everything so just remove the DCHECK all-together instead. BUG= 591706 Review URL: https://codereview.chromium.org/1768643002 Cr-Commit-Position: refs/heads/master@{#379372} [modify] https://crrev.com/368a1007f97c81c0d0a8e15a8affdcdd429dad5a/net/dns/host_resolver_impl.cc [modify] https://crrev.com/368a1007f97c81c0d0a8e15a8affdcdd429dad5a/net/dns/host_resolver_impl_unittest.cc
,
Mar 4 2016
Thanks for the report ascheglov! Should be resolved now. |
||||
►
Sign in to add a comment |
||||
Comment 1 by b...@chromium.org
, Mar 3 2016