New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 591701 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Long URLs cause the network error interstitial layout to have horizontal scroll

Project Member Reported by edwardjung@chromium.org, Mar 3 2016

Issue description

Version: M50
OS: All

As reported by ainslie on the updated network error interstitial.

What is the expected output? What do you see instead?
Long URLs should wrap.


 
non-wrapping-url.png
76.2 KB View Download
non-wrapping-url2.png
96.1 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b32b0757bf8d929d8d4765015714f9bf53f825a3

commit b32b0757bf8d929d8d4765015714f9bf53f825a3
Author: edwardjung <edwardjung@chromium.org>
Date: Thu Mar 03 17:18:06 2016

Wrap long URLs on the network error interstitial to prevent layout
breakages

BUG= 591701 

Review URL: https://codereview.chromium.org/1764643002

Cr-Commit-Position: refs/heads/master@{#379025}

[modify] https://crrev.com/b32b0757bf8d929d8d4765015714f9bf53f825a3/components/neterror/resources/neterror.css

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 3 2016

Labels: merge-merged-2666
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b32b0757bf8d929d8d4765015714f9bf53f825a3

commit b32b0757bf8d929d8d4765015714f9bf53f825a3
Author: edwardjung <edwardjung@chromium.org>
Date: Thu Mar 03 17:18:06 2016

Wrap long URLs on the network error interstitial to prevent layout
breakages

BUG= 591701 

Review URL: https://codereview.chromium.org/1764643002

Cr-Commit-Position: refs/heads/master@{#379025}

[modify] https://crrev.com/b32b0757bf8d929d8d4765015714f9bf53f825a3/components/neterror/resources/neterror.css

Labels: Merge-Request-50
Request merge to M50 branch. 

Fix is appearing in Canary. 

Comment 4 by tin...@google.com, Mar 7 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)

Comment 5 Deleted

Please try to merge your change to M50 branch 2661 ASAP if you think it is a safe merge as we're very close to M50 Beta candidate cut.
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 9 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39b1e959f579c814732b4a3f4f0a90cc5e750d24

commit 39b1e959f579c814732b4a3f4f0a90cc5e750d24
Author: edwardjung <edwardjung@chromium.org>
Date: Wed Mar 09 20:26:50 2016

Wrap long URLs on the network error interstitial to prevent layout breakages

BUG= 591701 
NOTRY=true
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1764643002

Cr-Commit-Position: refs/heads/master@{#379025}
(cherry picked from commit b32b0757bf8d929d8d4765015714f9bf53f825a3)

Review URL: https://codereview.chromium.org/1772073002

Cr-Commit-Position: refs/branch-heads/2661@{#152}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/39b1e959f579c814732b4a3f4f0a90cc5e750d24/components/neterror/resources/neterror.css

Status: Fixed (was: Assigned)

Sign in to add a comment