New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 591699 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Error when sorting a Proxy with an array as target

Reported by marco.m...@gmail.com, Mar 3 2016

Issue description

Chrome Version       : 49.0.2623.75 (Build ufficiale) (a 64 bit)
Other browsers tested:
    Firefox: OK
         IE: OK

What steps will reproduce the problem?
1. Execute this JS code:
    var pArray = new Proxy([3,2,1], {});
    pArray.sort()

What is the expected result?
I would expect that pArray gets sorted

What happens instead?
An error is raised: "Uncaught illegal access"

I have tested other array methods (such as push, pop, splice, shift, unshift, reverse) and everything works fine.

 

Comment 1 by b...@chromium.org, Mar 3 2016

Components: Blink>JavaScript

Comment 2 by habl...@google.com, Mar 3 2016

Cc: neis@chromium.org littledan@chromium.org jkummerow@chromium.org
Components: -Blink>JavaScript Blink>JavaScript>Language
Labels: -Pri-3 Pri-2 OS-All
Status: Available (was: Unconfirmed)

Comment 3 by neis@chromium.org, Mar 4 2016

Owner: neis@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 4 2016

Comment 5 by neis@chromium.org, Mar 4 2016

Status: Fixed (was: Started)
Labels: -Pri-2 Pri-1
Labels: merge-approved-4.9 Merge-Approved-5.0
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 9 2016

Labels: merge-merged-4.9
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/c60edba4a1b7eff59825c6e2d2b9415ca57dbd31

commit c60edba4a1b7eff59825c6e2d2b9415ca57dbd31
Author: neis <neis@chromium.org>
Date: Wed Mar 09 09:51:37 2016

Version 4.9.385.30 (cherry-pick)

Merged 86c955fee0aa15c37a7af1bd7dcb0a8bf5a6d92c

Fix Array.prototype.sort on proxies.

BUG= chromium:591699 
LOG=N
R=hablich@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1775343002

Cr-Commit-Position: refs/branch-heads/4.9@{#36}
Cr-Branched-From: 2fea296569597e5064f81fd8fce58f1848de261a-refs/heads/4.9.385@{#1}
Cr-Branched-From: 0c1430ac2b65847559d6a09f883ee7e5a91063c9-refs/heads/master@{#33306}

[modify] https://crrev.com/c60edba4a1b7eff59825c6e2d2b9415ca57dbd31/include/v8-version.h
[modify] https://crrev.com/c60edba4a1b7eff59825c6e2d2b9415ca57dbd31/src/runtime/runtime-array.cc
[modify] https://crrev.com/c60edba4a1b7eff59825c6e2d2b9415ca57dbd31/test/mjsunit/array-sort.js

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 10 2016

Labels: merge-merged-5.0
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/b5c05a57ad8525d1cc2dd64d335798a1ba54ff83

commit b5c05a57ad8525d1cc2dd64d335798a1ba54ff83
Author: neis <neis@chromium.org>
Date: Thu Mar 10 09:34:42 2016

Version 5.0.71.14 (cherry-pick)

Merged 86c955fee0aa15c37a7af1bd7dcb0a8bf5a6d92c

Fix Array.prototype.sort on proxies.

BUG= chromium:591699 
LOG=N
R=hablich@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1777203002

Cr-Commit-Position: refs/branch-heads/5.0@{#20}
Cr-Branched-From: ad16e6c2cbd2c6b0f2e8ff944ac245561c682ac2-refs/heads/5.0.71@{#1}
Cr-Branched-From: bd9df50d75125ee2ad37b3d92c8f50f0a8b5f030-refs/heads/master@{#34215}

[modify] https://crrev.com/b5c05a57ad8525d1cc2dd64d335798a1ba54ff83/include/v8-version.h
[modify] https://crrev.com/b5c05a57ad8525d1cc2dd64d335798a1ba54ff83/src/runtime/runtime-array.cc
[modify] https://crrev.com/b5c05a57ad8525d1cc2dd64d335798a1ba54ff83/test/mjsunit/array-sort.js

Comment 10 by neis@chromium.org, Mar 10 2016

Labels: -merge-approved-4.9 -Merge-Approved-5.0

Sign in to add a comment