shell_dialogs_unittests target does not link on platforms other than Windows. |
||
Issue description
Version: 51.0.2666.0
OS: All except windows.
What steps will reproduce the problem?
Run ninja -C out/Debug shell_dialogs_unittests on Mac.
Linking fails with the error message -
Undefined symbols for architecture x86_64:
"std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::find_last_of(char const*, unsigned long, unsigned long) const", referenced from:
base::FilePath::DirName() const in libbase.a(base.file_path.o)
base::FilePath::BaseName() const in libbase.a(base.file_path.o)
base::(anonymous namespace)::ExtensionSeparatorPosition(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in libbase.a(base.file_path.o)
"std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::at(unsigned long) const",
........
,
Mar 6 2016
Here is the failing link line-
FAILED: /Users/karandeepb/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang -Wl,-search_paths_first -Wl,-pie -mmacosx-version-min=10.6 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -arch x86_64 -L. -Wl,-rpath,@loader_path/. -Wl,-rpath,@loader_path/../../.. -stdlib=libc++ -o shell_dialogs_unittests libtest_support_base.a librun_all_unittests.a libgtest.a libbase_static.a libgmock.a libxml2.a libchrome_zlib.a libzlib_x86_simd.a libdynamic_annotations.a libbase.dylib libbase_i18n.dylib libicuuc.dylib libshell_dialogs.dylib -framework AppKit -framework ApplicationServices -framework Carbon -framework CoreFoundation -framework Foundation -framework IOKit -framework Security && (export BUILT_FRAMEWORKS_DIR=/Users/karandeepb/Desktop/chromium/src/out/Debug; export BUILT_PRODUCTS_DIR=/Users/karandeepb/Desktop/chromium/src/out/Debug; export CONFIGURATION=Debug; export EXECUTABLE_NAME=shell_dialogs_unittests; export EXECUTABLE_PATH=shell_dialogs_unittests; export FULL_PRODUCT_NAME=shell_dialogs_unittests; export PRODUCT_NAME=shell_dialogs_unittests; export PRODUCT_TYPE=com.apple.product-type.tool; export SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk; export SRCROOT=/Users/karandeepb/Desktop/chromium/src/out/Debug/../../ui/shell_dialogs; export SOURCE_ROOT="${SRCROOT}"; export TARGET_BUILD_DIR=/Users/karandeepb/Desktop/chromium/src/out/Debug; export TEMP_DIR="${TMPDIR}"; export XCODE_VERSION_ACTUAL=0640; (cd ../../ui/shell_dialogs && ../../build/mac/change_mach_o_flags_from_xcode.sh); G=$?; ((exit $G) || rm -rf shell_dialogs_unittests) && exit $G)
,
Mar 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/711ed960a44b9efe6875c68a6d0b3795c5a742a0 commit 711ed960a44b9efe6875c68a6d0b3795c5a742a0 Author: karandeepb <karandeepb@chromium.org> Date: Mon Mar 07 00:49:20 2016 Make shell_dialogs_unittests link correctly on Non-Windows gyp builds. BUG= 591663 Review URL: https://codereview.chromium.org/1759113002 Cr-Commit-Position: refs/heads/master@{#379503} [modify] https://crrev.com/711ed960a44b9efe6875c68a6d0b3795c5a742a0/ui/shell_dialogs/shell_dialogs.gyp
,
Mar 7 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by karandeepb@chromium.org
, Mar 4 2016