New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 591637 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
NOT IN USE
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Misalignment of the language dropdown menu is observed in www.urbandictionary.com.

Reported by lpa...@etouch.net, Mar 3 2016

Issue description

Chrome Version: 50.0.2661.11 (Official Build) d99fa8d200178bce07b02a15d79512e7236088ee-refs/branch-heads/2661@{#51} 32/64-bit.
OS: Mac, Windows (Win 7 Aero-Enabled)

Steps:
1. Launch chrome and navigate to http://www.urbandictionary.com/define.php?term=asdfasdf
2. Hover the mouse pointer over 'language dropdown icon' and observe the position of the dropdown menu.

Actual:  Misalignment of the language dropdown menu is observed.

Expected: Position of the language dropdown menu should be proper.

This is a regression issue broken in M-49.

Manual regression Range:
Good Build: 49.0.2621.0
Bad Build: 49.0.2622.0

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/91fe29fbd70af7d5ce441d36b1d36431dfccecf1..5b549adb97c791f7e3362c529deecc702b3443d4?pretty=fuller&n=100

Suspecting: r369366 

Note: Issue is seen on both Windows and Mac OS, will update Linux info.
 
Dropdown.png
70.0 KB View Download
Labels: -M-49 M-51

Comment 2 by msten...@opera.com, Mar 3 2016

Yes, this was caused by r369366.

Comment 3 by msten...@opera.com, Mar 3 2016

Components: -Blink>Layout Blink>Layout>MultiCol
Labels: -OS-Windows -OS-Mac OS-All
tc.html
570 bytes View Download

Comment 4 by e...@chromium.org, Mar 3 2016

Labels: -Pri-1 Pri-2

Comment 5 by e...@chromium.org, Aug 24 2016

Status: Fixed (was: Assigned)
Fixed in 54.

Comment 6 by e...@chromium.org, Aug 24 2016

Status: Assigned (was: Fixed)
Never mind, still an issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0740b0dfd20e2f99cddc773e0fe1460ef05da508

commit 0740b0dfd20e2f99cddc773e0fe1460ef05da508
Author: mstensho <mstensho@opera.com>
Date: Sun Dec 04 10:58:08 2016

Complete layout even if a block needs relayout due to widows or column balancing.

We cannot just abort in the middle of layoutBlockFlow() when we detect that we
need another layout pass (due to new column height or because we want an
earlier break to satisfy the widows requirement). We might miss our only
opportunity to detect size changes that way, and thus skip necessary layout and
repositioning of absolutely positioned descendants.

BUG= 591637 

Review-Url: https://codereview.chromium.org/2471623003
Cr-Commit-Position: refs/heads/master@{#436192}

[add] https://crrev.com/0740b0dfd20e2f99cddc773e0fe1460ef05da508/third_party/WebKit/LayoutTests/fast/multicol/abspos-new-width-rebalance.html
[add] https://crrev.com/0740b0dfd20e2f99cddc773e0fe1460ef05da508/third_party/WebKit/LayoutTests/fragmentation/widows-change-width-abspos-percent-width.html
[add] https://crrev.com/0740b0dfd20e2f99cddc773e0fe1460ef05da508/third_party/WebKit/LayoutTests/fragmentation/widows-change-width-abspos-right-aligned.html
[modify] https://crrev.com/0740b0dfd20e2f99cddc773e0fe1460ef05da508/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
[modify] https://crrev.com/0740b0dfd20e2f99cddc773e0fe1460ef05da508/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

Comment 8 by msten...@opera.com, Dec 5 2016

Status: Fixed (was: Assigned)

Sign in to add a comment