New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 591622 link

Starred by 1 user
Status: Fixed
Owner:
dgozman@chromium.org
Closed: Mar 2016
Cc:
nyerramilli@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Tab crash is observed when clicked on 'Add folder' button in Dev-tool.

Reported by jshan...@etouch.net, Mar 3 2016 
Chrome Version: 51.0.2665.0 (Official Build) c5656532d43869dab92268b04fdc4d57f8a96c88-refs/heads/master@{#378647}
OS: Windows

Steps:
1. Launch Chrome, go to NTP and open Dev-tool.
2. Go to Timeline section, press F1 to open setting and click on 'Workspace'.
3. Reload the page and click on 'Add folder' button and observe

Actual: Tab crash is observed when clicked on 'Add folder' button.

Expected: No tab crash should be seen.

This is a regression issue broken in M-51, will soon update the bisect info.
Actual_screencast.mp4
455 KB Download
Expected_screencast.mp4
398 KB Download

Comment 1 by jshan...@etouch.net, Mar 3 2016 

Correction in OS:Mac, Windows (Win 7 Aero-Enabled)

Generated Crash ID: d60b9fd400000000 (a833461b-ee34-4791-bce3-8765e0ae8fd7)

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/5d6a2e1871be2f4f8cc4eacb366a5abf8766fbfc..e5db881b268bc26ae3989a9f6f6a3325d7323baf?pretty=fuller&n=100

Suspecting: r378509 ?

Please hekp to re-assign if your changes is not the cause for this issue.

Comment 2 by ranjitkan@chromium.org, Mar 3 2016

Labels: ReleaseBlock-Beta
Stack Trace for the crash ID provided:

CRASHED [EXCEPTION_ACCESS_VIOLATION_READ @ 0x00000010 ] MAGIC SIGNATURE THREAD
0x00007ffd724b15dd	(chrome_child.dll -hashtable.h:661 )	WTF::HashTable<WTF::String,WTF::KeyValuePair<WTF::String,int>,WTF::KeyValuePairKeyExtractor,WTF::StringHash,WTF::HashMapValueTraits<WTF::HashTraits<WTF::String>,WTF::HashTraits<int> >,WTF::HashTraits<WTF::String>,WTF::PartitionAllocator>::lookup<WTF::IdentityHashTranslator<WTF::StringHash>,WTF::String>(WTF::String)
0x00007ffd72461dc1	(chrome_child.dll -hashtable.h:944 )	WTF::HashTable<WTF::String,WTF::KeyValuePair<WTF::String,WTF::RefPtr<blink::JSONValue> >,WTF::KeyValuePairKeyExtractor,WTF::StringHash,WTF::HashMapValueTraits<WTF::HashTraits<WTF::String>,WTF::HashTraits<WTF::RefPtr<blink::JSONValue> > >,WTF::HashTraits<WTF::String>,WTF::PartitionAllocator>::find<WTF::IdentityHashTranslator<WTF::StringHash>,WTF::String>(WTF::String const &)
0x00007ffd723db4d9	(chrome_child.dll -values.cpp:235 )	blink::protocol::DictionaryValue::get(WTF::String const &)
0x00007ffd723db589	(chrome_child.dll -values.cpp:217 )	blink::protocol::DictionaryValue::getString(WTF::String const &,WTF::String *)
0x00007ffd704d2065	(chrome_child.dll -inspectortracingagent.cpp:85 )	blink::InspectorTracingAgent::setLayerTreeId(int)
0x00007ffd717476a0	(chrome_child.dll -webdevtoolsagentimpl.cpp:473 )	blink::WebDevToolsAgentImpl::initializeDeferredAgents()
0x00007ffd7174666d	(chrome_child.dll -webdevtoolsagentimpl.cpp:510 )	blink::WebDevToolsAgentImpl::attach(blink::WebString const &,int)
0x00007ffd724f72cc	(chrome_child.dll -webembeddedworkerimpl.cpp:177 )	blink::WebEmbeddedWorkerImpl::attachDevTools(blink::WebString const &,int)
0x00007ffd7271c5e5	(chrome_child.dll -shared_worker_devtools_agent.cc:85 )	content::SharedWorkerDevToolsAgent::OnAttach(std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,int)
0x00007ffd71b42433	(chrome_child.dll -ipc_message_templates.h:118 )	IPC::MessageT<DevToolsAgentMsg_Attach_Meta,std::tuple<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,int>,void>::Dispatch<content::EmbeddedWorkerDevToolsAgent,content::EmbeddedWorkerDevToolsAgent,void,void ( content::EmbeddedWorkerDevToolsAgent::*)(std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,int)>(IPC::Message const *,content::EmbeddedWorkerDevToolsAgent *,content::EmbeddedWorkerDevToolsAgent *,void *,void ( content::EmbeddedWorkerDevToolsAgent::*)(std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,int))
0x00007ffd71b427a4	(chrome_child.dll -embedded_worker_devtools_agent.cc:33 )	content::EmbeddedWorkerDevToolsAgent::OnMessageReceived(IPC::Message const &)
0x00007ffd721056e2	(chrome_child.dll -message_router.cc:52 )	IPC::MessageRouter::RouteMessage(IPC::Message const &)
0x00007ffd719ccc1a	(chrome_child.dll -child_thread_impl.cc:635 )	content::ChildThreadImpl::OnMessageReceived(IPC::Message const &)
0x00007ffd71455533	(chrome_child.dll -ipc_channel_proxy.cc:293 )	IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const &)
0x00007ffd6ff88918	(chrome_child.dll -task_annotator.cc:51 )	base::debug::TaskAnnotator::RunTask(char const *,base::PendingTask const &)
0x00007ffd7273ad2e	(chrome_child.dll -task_queue_manager.cc:288 )	scheduler::TaskQueueManager::ProcessTaskFromWorkQueue(scheduler::internal::WorkQueue *,scheduler::internal::TaskQueueImpl::Task *)
0x00007ffd7273a4de	(chrome_child.dll -task_queue_manager.cc:200 )	scheduler::TaskQueueManager::DoWork(base::TimeTicks,bool)
0x00007ffd719e2a82	(chrome_child.dll -bind_internal.h:314 )	base::internal::InvokeHelper<1,void,base::internal::RunnableAdapter<void ( content::WebFileWriterBase::*)(__int64,bool)> >::MakeItSo<base::WeakPtr<content::WebFileWriterImpl>,__int64 const &,bool const &>(base::internal::RunnableAdapter<void ( content::WebFileWriterBase::*)(__int64,bool)>,base::WeakPtr<content::WebFileWriterImpl>,__int64 const &,bool const &)
0x00007ffd7273b0e1	(chrome_child.dll -bind_internal.h:354 )	base::internal::Invoker<base::IndexSequence<0,1,2>,base::internal::BindState<base::internal::RunnableAdapter<void ( scheduler::TaskQueueManager::*)(base::TimeTicks,bool)>,void ,base::WeakPtr<scheduler::TaskQueueManager>,base::TimeTicks &,bool>,base::internal::InvokeHelper<1,void,base::internal::RunnableAdapter<void ( scheduler::TaskQueueManager::*)(base::TimeTicks,bool)> >,void >::Run(base::internal::BindStateBase *)
0x00007ffd6ff88918	(chrome_child.dll -task_annotator.cc:51 )	base::debug::TaskAnnotator::RunTask(char const *,base::PendingTask const &)
0x00007ffd6ff442fb	(chrome_child.dll -message_loop.cc:476 )	base::MessageLoop::RunTask(base::PendingTask const &)
0x00007ffd6ff44e43	(chrome_child.dll -message_loop.cc:597 )	base::MessageLoop::DoWork()
0x00007ffd6ff86505	(chrome_child.dll -message_pump_default.cc:33 )	base::MessagePumpDefault::Run(base::MessagePump::Delegate *)
0x00007ffd6ff8703e	(chrome_child.dll -run_loop.cc:35 )	base::RunLoop::Run()
0x00007ffd6ff43640	(chrome_child.dll -message_loop.cc:293 )	base::MessageLoop::Run()
0x00007ffd71a4f5be	(chrome_child.dll -renderer_main.cc:219 )	content::RendererMain(content::MainFunctionParams const &)
0x00007ffd713583e9	(chrome_child.dll -content_main_runner.cc:395 )	content::RunNamedProcessTypeMain(std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,content::MainFunctionParams const &,content::ContentMainDelegate *)
0x00007ffd71358226	(chrome_child.dll -content_main_runner.cc:764 )	content::ContentMainRunnerImpl::Run()
0x00007ffd71355680	(chrome_child.dll -content_main.cc:19 )	content::ContentMain(content::ContentMainParams const &)
0x00007ffd712cad81	(chrome_child.dll -chrome_main.cc:84 )	ChromeMain
0x00007ff620420f6e	(chrome.exe -main_dll_loader_win.cc:183 )	MainDllLoader::Launch(HINSTANCE__ *)
0x00007ff6204201af	(chrome.exe -chrome_exe_main_win.cc:230 )	wWinMain
0x00007ff62045de97	(chrome.exe -crt0.c:251 )	__tmainCRTStartup
0x00007ffd936e13d1	(KERNEL32.DLL + 0x000013d1 )	BaseThreadInitThunk
0x00007ffd96765453	(ntdll.dll + 0x00015453 )	RtlUserThreadStart

Adding release block label, please undo if not the case.

Comment 3 by jshan...@etouch.net, Mar 3 2016

Labels: OS-Linux
Good build: 51.0.2664.0
Bad build: 51.0.2665.0
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6eceb74841afe66e73115c84317b3bbe29b124f

commit b6eceb74841afe66e73115c84317b3bbe29b124f
Author: dgozman <dgozman@chromium.org>
Date: Fri Mar 04 01:53:03 2016

[DevTools] Fix crash in InspectorTracingAgent.

|m_state| can be null at the time we call setLayerTreeId.

BUG= 591622 

Review URL: https://codereview.chromium.org/1761793004

Cr-Commit-Position: refs/heads/master@{#379174}

[modify] https://crrev.com/b6eceb74841afe66e73115c84317b3bbe29b124f/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp

Comment 5 by dgozman@chromium.org, Mar 4 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment