New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 591613 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Trybot command "tools/perf/run_benchmark try all-win page_cycler.typical_25" fail

Project Member Reported by nedngu...@google.com, Mar 3 2016

Issue description

Reported by brucedawson@:

$ tools/perf/run_benchmark try all-win page_cycler.typical_25
Uploaded chromium try job to rietveld for win platform. View progress at https://codereview.chromium.org/1741923002
Could not commit bisect config change for win-x64, error 
Error running tryjob.
(ERROR) 2016-02-26 13:34:00,351 trybot_command._AttemptTryjob:384  Could not commit bisect config change for win-x64, error 
Error running tryjob.


After debugging, I figure out the reason it's failing is because the config we generate for win is exactly the same as win-x64. Hence the command steps look s.t like:

Generate the config change for win
git commit -a -m "win"
git cl upload
git cl try ...

Generate the config change for win-x64 (which does not change anything because config is the same)
git commit -a -m "win-x64" --> error because there is nothing to commit.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91da72fe17e3d7466c36f9b1f6a07998516a3264

commit 91da72fe17e3d7466c36f9b1f6a07998516a3264
Author: nednguyen <nednguyen@google.com>
Date: Thu Mar 03 07:55:52 2016

[tools/perf] Skip try job run if trybot config file does not change

Sometime, users run trybot job against many bots of different platforms
(e.g:  platforms win & winx64). Sometimes the configs of these different
platforms are the same because they happens to share the same bot.

In this case, we will skip the trybot run if the config file does not change.

BUG= 591613 

Review URL: https://codereview.chromium.org/1765483002

Cr-Commit-Position: refs/heads/master@{#378979}

[modify] https://crrev.com/91da72fe17e3d7466c36f9b1f6a07998516a3264/tools/perf/core/trybot_command.py
[modify] https://crrev.com/91da72fe17e3d7466c36f9b1f6a07998516a3264/tools/perf/core/trybot_command_unittest.py

Owner: nedngu...@google.com
Status: Fixed (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 3 2016

Labels: merge-merged-2666
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91da72fe17e3d7466c36f9b1f6a07998516a3264

commit 91da72fe17e3d7466c36f9b1f6a07998516a3264
Author: nednguyen <nednguyen@google.com>
Date: Thu Mar 03 07:55:52 2016

[tools/perf] Skip try job run if trybot config file does not change

Sometime, users run trybot job against many bots of different platforms
(e.g:  platforms win & winx64). Sometimes the configs of these different
platforms are the same because they happens to share the same bot.

In this case, we will skip the trybot run if the config file does not change.

BUG= 591613 

Review URL: https://codereview.chromium.org/1765483002

Cr-Commit-Position: refs/heads/master@{#378979}

[modify] https://crrev.com/91da72fe17e3d7466c36f9b1f6a07998516a3264/tools/perf/core/trybot_command.py
[modify] https://crrev.com/91da72fe17e3d7466c36f9b1f6a07998516a3264/tools/perf/core/trybot_command_unittest.py

 Issue 584852  has been merged into this issue.
 Issue 584852  has been merged into this issue.

Sign in to add a comment