Issue metadata
Sign in to add a comment
|
Regression: Focus does not shift to Email textbox in avatar bubble on pressing Tab key.
Reported by
vvishwak...@etouch.net,
Mar 3 2016
|
||||||||||||||||||||||||
Issue descriptionVersion: 50.0.2661.11 (Official Build) d99fa8d200178bce07b02a15d79512e7236088ee-refs/branch-heads/2661@{#51} (32/64-bit) OS: Mac, Windows(Win 7-Aero enabled) What steps will reproduce the problem? 1) Launch chrome, go to 'chrome://settings' and click on 'Sign in to chrome' button (avatar bubble opens) . 2) Press Tab key from keyboard twice and observe. On pressing Tab key twice, focus shifts to 'Password' textbox. On pressing Tab key twice, focus should be on 'Email' textbox. This is a Regression issue broken in M-50, below is the bisect info Good build: 50.0.2657.0 Bad build: 50.0.2658.0 Narrow bisect URL: https://chromium.googlesource.com/chromium/src/+log/7a1e387c1670c314ff76f26f5061c8abae030c7d..11efbc5592132de8ad0f2e5ef158ecaf91cb8861?pretty=fuller&n=100 Suspecting: r376949 Note: Issue is seen on Windows and Mac OS, will update Linux info.
,
Mar 3 2016
,
Mar 4 2016
,
Mar 4 2016
,
Mar 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97e1c9eed32d48ac464dcd5ee482c8123f8b810f commit 97e1c9eed32d48ac464dcd5ee482c8123f8b810f Author: tkent <tkent@chromium.org> Date: Fri Mar 04 05:59:15 2016 FocusController::setInitialFocus should ignore sequential focus navigation starting point. If an element was focused before calling setInitialFocus(), we unexpectedly started to search for focus candidates at the last focused element. BUG= 591612 TEST=automated Review URL: https://codereview.chromium.org/1759413002 Cr-Commit-Position: refs/heads/master@{#379223} [modify] https://crrev.com/97e1c9eed32d48ac464dcd5ee482c8123f8b810f/third_party/WebKit/Source/core/core.gypi [modify] https://crrev.com/97e1c9eed32d48ac464dcd5ee482c8123f8b810f/third_party/WebKit/Source/core/page/FocusController.cpp [add] https://crrev.com/97e1c9eed32d48ac464dcd5ee482c8123f8b810f/third_party/WebKit/Source/core/page/FocusControllerTest.cpp
,
Mar 4 2016
,
Mar 7 2016
,
Mar 7 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Mar 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5e1612c1fc2db5802b56d3c6813d60ea320ea99 commit b5e1612c1fc2db5802b56d3c6813d60ea320ea99 Author: Kent Tamura <tkent@chromium.org> Date: Mon Mar 07 01:11:06 2016 Merge "FocusController::setInitialFocus should ignore sequential focus navigation starting point." to M50 branch If an element was focused before calling setInitialFocus(), we unexpectedly started to search for focus candidates at the last focused element. BUG= 591612 TEST=automated Review URL: https://codereview.chromium.org/1759413002 Cr-Commit-Position: refs/heads/master@{#379223} (cherry picked from commit 97e1c9eed32d48ac464dcd5ee482c8123f8b810f) Review URL: https://codereview.chromium.org/1768873002 . Cr-Commit-Position: refs/branch-heads/2661@{#97} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/b5e1612c1fc2db5802b56d3c6813d60ea320ea99/third_party/WebKit/Source/core/core.gypi [modify] https://crrev.com/b5e1612c1fc2db5802b56d3c6813d60ea320ea99/third_party/WebKit/Source/core/page/FocusController.cpp [add] https://crrev.com/b5e1612c1fc2db5802b56d3c6813d60ea320ea99/third_party/WebKit/Source/core/page/FocusControllerTest.cpp
,
Mar 8 2016
Fix is working as intended. Rechecked on Verified OS for chrome version: 50.0.2661.18 and adding TE-verified labels.
,
Mar 8 2016
Verified the above issue on Win 7, Win 8.1, Win 10, Mac and Linux OS.
,
Sep 29 2017
,
Sep 29 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by ranjitkan@chromium.org
, Mar 3 2016