New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 591611 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Splitter can resize only left element.

Project Member Reported by ryoh@chromium.org, Mar 3 2016

Issue description

Chrome Version: ToT

I'm implementing 3 pane layout for Files app.
(Please see attached image, right pane will be a new "preview" panel, but currently, it is just a white box)

I inserted two splitters between those elements.
I would like to let the right splitter resize right (new "preview") panel, but now, splitters can resize only "left" elements:
https://code.google.com/p/chromium/codesearch#chromium/src/ui/webui/resources/js/cr/ui/splitter.js&l=205

tapted@, dbeam@
I added you to CCs, because you submitted/reviewd recent patch for Splitter (https://codereview.chromium.org/1711233003).

I think I can add some extra flags to determine which element should be resized.
 
Untitled.png
189 KB View Download

Comment 1 by ryoh@chromium.org, Mar 3 2016

Components: Platform>Apps>Core

Comment 2 by ryoh@chromium.org, Mar 3 2016

Components: Platform>Apps>FileManager

Comment 3 by ryoh@chromium.org, Mar 3 2016

Here is a patch:
https://codereview.chromium.org/1760823002/
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9613e62a3e9d55ffdc04d1276ee57c54ae8322e2

commit 9613e62a3e9d55ffdc04d1276ee57c54ae8322e2
Author: ryoh <ryoh@chromium.org>
Date: Tue Mar 08 04:39:04 2016

Allow splitter to resize next element

To specify which element should be resized, I added a new argument "resizeNextElement" to decorate method.

BUG= 591611 
TEST=none

Review URL: https://codereview.chromium.org/1760823002

Cr-Commit-Position: refs/heads/master@{#379737}

[modify] https://crrev.com/9613e62a3e9d55ffdc04d1276ee57c54ae8322e2/chrome/test/data/webui/splitter_test.html
[modify] https://crrev.com/9613e62a3e9d55ffdc04d1276ee57c54ae8322e2/ui/webui/resources/js/cr/ui/splitter.js

Comment 5 by ryoh@chromium.org, Mar 8 2016

Status: Fixed (was: Started)
Labels: VerifyIn-51
Labels: Needs-Feedback
ryoh@ Could you please provide test steps to verify this bug?
Status: Verified (was: Fixed)
Bulk verified

Sign in to add a comment