Issue metadata
Sign in to add a comment
|
Auto fix icon is seen enabled even after clicking on it for few times to apply that feature |
||||||||||||||||||||||
Issue descriptionVersion: 50.0.2661.5 (Official Build) dev (64-bit) OS: Chrome Platform: 7978.3.0 (Official Build) dev-channel Peppy, Mighty Daisy, Blaze What steps will reproduce the problem? 1.Sign in to user>> download 2,3 images>> open it in gallery 2.Go to edit settings>> apply auto fix icon>> and observe Expected: On applying auto fix feature, the image should get fixed automatically and the auto fix icon should be seen disabled Actual: Instead auto fix icon is seen enabled even after clicking on it for few times This is a Regression issue as it is working fine in 48.0.2564.116/7647.84.0 stable channel Daisy Issue is not applicable to Linux and Windows
,
Mar 3 2016
able to reproduce the issue on Peppy using chrome version 50.0.2661.11/7978.4.0
,
Mar 7 2016
Bisected. This issue becomes to happen after https://crrev.com/1731753002 @ryoh: Could you take a look?
,
Mar 7 2016
I found that this bug occurs also on undo/redo. Here is a patch: https://codereview.chromium.org/1766343002/
,
Mar 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e534ef0d453c7aa40a2d4f973521bedd57d4c02 commit 5e534ef0d453c7aa40a2d4f973521bedd57d4c02 Author: ryoh <ryoh@chromium.org> Date: Tue Mar 08 02:26:13 2016 Gallery: Update edit-mode-applicavilities even if it's a instant auto fix, and update them on undo/redo BUG= 591609 TEST=manually Review URL: https://codereview.chromium.org/1766343002 Cr-Commit-Position: refs/heads/master@{#379703} [modify] https://crrev.com/5e534ef0d453c7aa40a2d4f973521bedd57d4c02/ui/file_manager/gallery/js/image_editor/image_editor.js [modify] https://crrev.com/5e534ef0d453c7aa40a2d4f973521bedd57d4c02/ui/file_manager/gallery/js/slide_mode.js
,
Mar 8 2016
,
Mar 11 2016
please merge. fukino@ can help
,
Mar 11 2016
,
Mar 11 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Mar 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d82140b585a7bc81054ad11f7dfadbec61b97d16 commit d82140b585a7bc81054ad11f7dfadbec61b97d16 Author: Naoki Fukino <fukino@chromium.org> Date: Fri Mar 11 08:21:02 2016 Gallery: Update edit-mode-applicavilities even if it's a instant auto fix, and update them on undo/redo BUG= 591609 TEST=manually TBR=ryoh@chromium.org Review URL: https://codereview.chromium.org/1766343002 Cr-Commit-Position: refs/heads/master@{#379703} (cherry picked from commit 5e534ef0d453c7aa40a2d4f973521bedd57d4c02) Review URL: https://codereview.chromium.org/1784143003 . Cr-Commit-Position: refs/branch-heads/2661@{#191} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/d82140b585a7bc81054ad11f7dfadbec61b97d16/ui/file_manager/gallery/js/image_editor/image_editor.js [modify] https://crrev.com/d82140b585a7bc81054ad11f7dfadbec61b97d16/ui/file_manager/gallery/js/slide_mode.js
,
Mar 24 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sandeepk...@techmahindra.com
, Mar 3 2016