Fix cubic-bezier inconsistency in Blink and CC |
|||||||||
Issue descriptionCubic-bezier accuracy in blink depends on duration. Cubic-bezier accuracy in CC doesn't. Currently in tests we want to achieve desired accuracy for splines using a specific duration. // Reverse the blink::accuracyForDuration function to calculate duration // from epsilon. // Taken from cubic_bezier.cc: var kBezierEpsilon = 1e-7; https://codereview.chromium.org/1360233004/patch/40001/50004 Duration mustn't affect cc/blink consistency.
,
Mar 3 2016
,
May 26 2016
,
May 26 2016
,
Jun 15 2016
,
Oct 6 2016
,
Nov 2 2016
,
Nov 9 2016
,
Jan 23 2017
Blink still uses varying accuracy based on the duration while cc does not. https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/animation/AnimationUtilities.h?sq=package:chromium&dr=C&rcl=1485173813&l=82
,
Jan 24 2017
,
Jan 24 2017
Be careful: this may cause performance degradation if many animations (the cubic bezier solver will take significantly more iterations to find a solution)
,
Feb 3 2017
We should try using the cc accuracy level in Blink first and see if it's fine. I'd check it by testing deviation from Firefox and other browsers and seeing if it increases significantly.
,
Jan 25 2018
Blink bases its cubic bezier accuracy on the effect's duration: https://cs.chromium.org/chromium/src/?q=function:AccuracyForDuration while the compositor uses a constant: https://cs.chromium.org/search/?q=kBezierEpsilon |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by loyso@chromium.org
, Mar 3 2016