save-data header value gets appended on page refreshes |
||||||||
Issue descriptionWhat steps will reproduce the problem? 1. Load some simple page with data-saver enabled. 2. Chrome dev tools shows save-data: on for the requests. 3. Refresh the page. 4. Chrome dev tools shows save-data: on,on for the requests. Refreshing the pages appends more 'on' to the save-data header. http://csb.stanford.edu/class/public/pages/sykes_webdesign/05_simple.html
,
Mar 9 2016
Thanks for catching this.
,
Mar 10 2016
,
Mar 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c957da3f5a7b7e3eb37483a57ebbf323f997f1f commit 8c957da3f5a7b7e3eb37483a57ebbf323f997f1f Author: rajendrant <rajendrant@chromium.org> Date: Fri Mar 11 07:49:12 2016 save-data header value gets appended on page refreshes When data-saver is enabled, Chrome sets save-data header value to 'on'. When the webpage is refreshed, the sub resource requests get the save-data value as 'on,on'. BUG= 591594 Review URL: https://codereview.chromium.org/1783653002 Cr-Commit-Position: refs/heads/master@{#380568} [modify] https://crrev.com/8c957da3f5a7b7e3eb37483a57ebbf323f997f1f/chrome/browser/data_saver/data_saver_browsertest.cc [modify] https://crrev.com/8c957da3f5a7b7e3eb37483a57ebbf323f997f1f/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp [modify] https://crrev.com/8c957da3f5a7b7e3eb37483a57ebbf323f997f1f/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
,
Mar 11 2016
Needed in M-50 for fixing the save-data header during page-reloads. Requesting for approval. Thanks Raj
,
Mar 12 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Mar 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a773f1e10667737074f79c4caa9de50da1fbd073 commit a773f1e10667737074f79c4caa9de50da1fbd073 Author: Tarun Bansal <tbansal@google.com> Date: Mon Mar 14 21:52:26 2016 save-data header value gets appended on page refreshes When data-saver is enabled, Chrome sets save-data header value to 'on'. When the webpage is refreshed, the sub resource requests get the save-data value as 'on,on'. BUG= 591594 Review URL: https://codereview.chromium.org/1783653002 Cr-Commit-Position: refs/heads/master@{#380568} (cherry picked from commit 8c957da3f5a7b7e3eb37483a57ebbf323f997f1f) Review URL: https://codereview.chromium.org/1800843002 . Cr-Commit-Position: refs/branch-heads/2661@{#225} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/a773f1e10667737074f79c4caa9de50da1fbd073/chrome/browser/data_saver/data_saver_browsertest.cc [modify] https://crrev.com/a773f1e10667737074f79c4caa9de50da1fbd073/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp [modify] https://crrev.com/a773f1e10667737074f79c4caa9de50da1fbd073/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
,
Mar 14 2016
,
Mar 16 2016
Tested the issue on Windows 7, Mac 10.10.5, Ubuntu 14.04 using 50.0.2661.37. Refreshing the pages appends only one 'on' to the save-data header. Please find attached screenshot. Marking it as TE-Verified.
,
Mar 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f67faf0fa3c57d392fcf6b5d2b1c9f324b0bc35b commit f67faf0fa3c57d392fcf6b5d2b1c9f324b0bc35b Author: toyoshim <toyoshim@chromium.org> Date: Fri Mar 24 05:37:26 2017 Should reset "Save-Data" header on all kinds of reloads Existing code just reset the "Save-Data" HTTP header only on FrameLoadTypeReload. But this should be done for all kinds of reload variants including ReloadMainResource and ReloadBypassingCache. BUG= 674404 , 591594 Review-Url: https://codereview.chromium.org/2769033004 Cr-Commit-Position: refs/heads/master@{#459365} [modify] https://crrev.com/f67faf0fa3c57d392fcf6b5d2b1c9f324b0bc35b/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp [modify] https://crrev.com/f67faf0fa3c57d392fcf6b5d2b1c9f324b0bc35b/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by cbentzel@chromium.org
, Mar 3 2016