New issue
Advanced search Search tips

Issue 591582 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug

Blocking:
issue 505804



Sign in to add a comment

[md] add ink drops to download shelf

Project Member Reported by est...@chromium.org, Mar 3 2016

Issue description

items on download shelf should get ripples on press [and maybe on hover]
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93bfca9c89bf3f9232206b07ca312665c825810f

commit 93bfca9c89bf3f9232206b07ca312665c825810f
Author: estade <estade@chromium.org>
Date: Tue Mar 08 04:14:01 2016

[MD] some tweaks to download shelf

- add ripple to dropdown button
  - ink drop is spec'd to 32x32 for "small" size while the touch target is 36x36
- fix some layout issues affecting item internals
- add some convenience ctors to gfx::Insets (a scan of the code indicates
  there are many places these could be used)

BUG= 591582 

Review URL: https://codereview.chromium.org/1750403005

Cr-Commit-Position: refs/heads/master@{#379731}

[modify] https://crrev.com/93bfca9c89bf3f9232206b07ca312665c825810f/chrome/browser/ui/views/bar_control_button.cc
[modify] https://crrev.com/93bfca9c89bf3f9232206b07ca312665c825810f/chrome/browser/ui/views/download/download_item_view_md.cc
[modify] https://crrev.com/93bfca9c89bf3f9232206b07ca312665c825810f/ui/gfx/geometry/insets.cc
[modify] https://crrev.com/93bfca9c89bf3f9232206b07ca312665c825810f/ui/gfx/geometry/insets.h
[modify] https://crrev.com/93bfca9c89bf3f9232206b07ca312665c825810f/ui/gfx/geometry/insets_f.h
[modify] https://crrev.com/93bfca9c89bf3f9232206b07ca312665c825810f/ui/views/animation/ink_drop_host_view.cc
[modify] https://crrev.com/93bfca9c89bf3f9232206b07ca312665c825810f/ui/views/animation/ink_drop_host_view.h
[modify] https://crrev.com/93bfca9c89bf3f9232206b07ca312665c825810f/ui/views/controls/button/custom_button.h

Comment 3 by est...@chromium.org, Mar 31 2016

here are some TODOs associated with my latest patch:
1. on rare occasions, the text seems to have subpixel AA problems
2. hovering an item during the animation results in a broken looking hover
3. there's a blip of red on the left side of newly opened download items (hard to notice)
fixed #3
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15bda587d910b5d9f59b7184ecfeda37022eb6f4

commit 15bda587d910b5d9f59b7184ecfeda37022eb6f4
Author: estade <estade@chromium.org>
Date: Mon Apr 04 23:28:46 2016

MD - add ripples to DL shelf items

BUG= 591582 

Review URL: https://codereview.chromium.org/1832963002

Cr-Commit-Position: refs/heads/master@{#385052}

[modify] https://crrev.com/15bda587d910b5d9f59b7184ecfeda37022eb6f4/chrome/browser/ui/views/download/download_item_view_md.cc
[modify] https://crrev.com/15bda587d910b5d9f59b7184ecfeda37022eb6f4/chrome/browser/ui/views/download/download_item_view_md.h
[modify] https://crrev.com/15bda587d910b5d9f59b7184ecfeda37022eb6f4/ui/views/animation/button_ink_drop_delegate.cc
[modify] https://crrev.com/15bda587d910b5d9f59b7184ecfeda37022eb6f4/ui/views/animation/button_ink_drop_delegate.h
[modify] https://crrev.com/15bda587d910b5d9f59b7184ecfeda37022eb6f4/ui/views/animation/flood_fill_ink_drop_animation.cc
[modify] https://crrev.com/15bda587d910b5d9f59b7184ecfeda37022eb6f4/ui/views/animation/flood_fill_ink_drop_animation.h
[modify] https://crrev.com/15bda587d910b5d9f59b7184ecfeda37022eb6f4/ui/views/animation/ink_drop_animation_controller_factory_unittest.cc
[modify] https://crrev.com/15bda587d910b5d9f59b7184ecfeda37022eb6f4/ui/views/animation/ink_drop_animation_controller_impl.cc
[modify] https://crrev.com/15bda587d910b5d9f59b7184ecfeda37022eb6f4/ui/views/animation/ink_drop_animation_controller_impl.h
[modify] https://crrev.com/15bda587d910b5d9f59b7184ecfeda37022eb6f4/ui/views/animation/ink_drop_animation_controller_impl_unittest.cc
[modify] https://crrev.com/15bda587d910b5d9f59b7184ecfeda37022eb6f4/ui/views/animation/ink_drop_animation_unittest.cc
[modify] https://crrev.com/15bda587d910b5d9f59b7184ecfeda37022eb6f4/ui/views/animation/ink_drop_state.cc
[modify] https://crrev.com/15bda587d910b5d9f59b7184ecfeda37022eb6f4/ui/views/animation/ink_drop_state.h
[modify] https://crrev.com/15bda587d910b5d9f59b7184ecfeda37022eb6f4/ui/views/animation/square_ink_drop_animation.cc
[modify] https://crrev.com/15bda587d910b5d9f59b7184ecfeda37022eb6f4/ui/views/animation/square_ink_drop_animation.h
[modify] https://crrev.com/15bda587d910b5d9f59b7184ecfeda37022eb6f4/ui/views/controls/button/custom_button.cc
[modify] https://crrev.com/15bda587d910b5d9f59b7184ecfeda37022eb6f4/ui/views/controls/button/custom_button_unittest.cc
[modify] https://crrev.com/15bda587d910b5d9f59b7184ecfeda37022eb6f4/ui/views/controls/button/menu_button.cc
[modify] https://crrev.com/15bda587d910b5d9f59b7184ecfeda37022eb6f4/ui/views/controls/button/menu_button_unittest.cc

Comment 6 by est...@chromium.org, Apr 11 2016

Status: Fixed (was: Assigned)

Sign in to add a comment