New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 591581 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

ProcessesApiTest.Processes fails on some MSan bots

Project Member Reported by afakhry@chromium.org, Mar 3 2016

Issue description

Bots are:

Linux MSan Tests: https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/14159

Linux ChromeOS MSan Tests: https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20MSan%20Tests/builds/7714

The test was disabled before. I re-enabled it as part of the migration to IDL. I will disable it for now until the migration to the new task manager CL lands.

 
Summary: ProcessesApiTest.Processes fails on some MSan bots (was: ProcessesApiTest.Processes Fails on some MSan bots)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3153eaee359ae99e2b4d3604937e253cd9206ae6

commit 3153eaee359ae99e2b4d3604937e253cd9206ae6
Author: afakhry <afakhry@chromium.org>
Date: Thu Mar 03 02:29:25 2016

ProcessesApiTest.Processes fails on some MSan bots

I'll disabled it for now until the follow-up CL for migrating to the
new task manager lands.

TBR=rdevlin.cronin@chromium.org
BUG= 591581 

Review URL: https://codereview.chromium.org/1759813003

Cr-Commit-Position: refs/heads/master@{#378923}

[modify] https://crrev.com/3153eaee359ae99e2b4d3604937e253cd9206ae6/chrome/browser/extensions/api/processes/processes_apitest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 3 2016

Labels: merge-merged-2666
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3153eaee359ae99e2b4d3604937e253cd9206ae6

commit 3153eaee359ae99e2b4d3604937e253cd9206ae6
Author: afakhry <afakhry@chromium.org>
Date: Thu Mar 03 02:29:25 2016

ProcessesApiTest.Processes fails on some MSan bots

I'll disabled it for now until the follow-up CL for migrating to the
new task manager lands.

TBR=rdevlin.cronin@chromium.org
BUG= 591581 

Review URL: https://codereview.chromium.org/1759813003

Cr-Commit-Position: refs/heads/master@{#378923}

[modify] https://crrev.com/3153eaee359ae99e2b4d3604937e253cd9206ae6/chrome/browser/extensions/api/processes/processes_apitest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98241839b528f945fabb03f38fb1ea6a3e837f09

commit 98241839b528f945fabb03f38fb1ea6a3e837f09
Author: afakhry <afakhry@chromium.org>
Date: Fri Mar 11 19:27:47 2016

Migrate ProcessesEventRouter to the new task manager

This CL migrates the dependency of the ProcessesAPIs to the new task manager
implementation.

The API of the process info has been fixed, since processes don't have titles, instead we added a list of tasks running in that process, with their titles and optional tab IDs.

BUG=525201, 591581 
TEST=browser_tests --gtest_filter=ProcessesApiTest.*

Review URL: https://codereview.chromium.org/1584473004

Cr-Commit-Position: refs/heads/master@{#380696}

[modify] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/chrome/browser/extensions/api/processes/processes_api.cc
[modify] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/chrome/browser/extensions/api/processes/processes_api.h
[modify] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/chrome/browser/extensions/api/processes/processes_apitest.cc
[modify] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/chrome/browser/extensions/api/tabs/tabs_api.cc
[modify] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/chrome/browser/task_management/providers/arc/arc_process_task.cc
[modify] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/chrome/browser/task_management/providers/task.cc
[modify] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/chrome/browser/task_management/providers/task.h
[modify] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/chrome/browser/task_management/providers/task_provider.cc
[modify] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/chrome/browser/task_management/providers/task_provider.h
[modify] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/chrome/browser/task_management/providers/task_provider_observer.h
[modify] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/chrome/browser/task_management/providers/web_contents/renderer_task.cc
[modify] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/chrome/browser/task_management/providers/web_contents/renderer_task.h
[modify] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/chrome/browser/task_management/providers/web_contents/web_contents_task_provider.cc
[modify] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/chrome/browser/task_management/sampling/task_group.cc
[modify] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/chrome/browser/task_management/sampling/task_group.h
[modify] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/chrome/browser/task_management/sampling/task_manager_impl.cc
[modify] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/chrome/browser/task_management/sampling/task_manager_impl.h
[modify] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/chrome/browser/task_management/task_manager_interface.cc
[modify] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/chrome/browser/task_management/task_manager_interface.h
[modify] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/chrome/browser/task_management/task_manager_observer.cc
[modify] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/chrome/browser/task_management/task_manager_observer.h
[modify] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/chrome/browser/task_management/test_task_manager.cc
[modify] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/chrome/browser/task_management/test_task_manager.h
[modify] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/chrome/chrome_browser_extensions.gypi
[modify] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/chrome/common/extensions/api/processes.idl
[modify] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/chrome/common/extensions/api/schemas.gni
[modify] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/chrome/common/extensions/api/schemas.gypi
[modify] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/chrome/test/data/extensions/api_test/processes/api/test.js
[add] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/chrome/test/data/extensions/api_test/processes/onupdated_with_memory/background.js
[add] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/chrome/test/data/extensions/api_test/processes/onupdated_with_memory/manifest.json
[modify] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/content/public/browser/web_contents.h
[modify] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/content/public/browser/web_contents_observer.h
[delete] https://crrev.com/a87c5bb23137ad66a2dce5bfb2247b6ea8a25cf8/extensions/browser/extension_function_util.cc
[delete] https://crrev.com/a87c5bb23137ad66a2dce5bfb2247b6ea8a25cf8/extensions/browser/extension_function_util.h
[modify] https://crrev.com/98241839b528f945fabb03f38fb1ea6a3e837f09/extensions/extensions.gypi

Status: Fixed (was: Assigned)

Sign in to add a comment