New issue
Advanced search Search tips

Issue 591580 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Test failure due to new histograms checks.

Project Member Reported by dim...@chromium.org, Mar 3 2016

Issue description

Break: https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/17129

Caused by: https://codereview.chromium.org/1719363002

Snippet from log:

ExtensionApiTest.Metrics (run #1):
[ RUN      ] ExtensionApiTest.Metrics
[1644:1287:0302/164907:WARNING:vt_video_decode_accelerator_mac.cc(209)] Failed to create hardware VideoToolbox session. Hardware accelerated video decoding will be disabled.
[1644:1287:0302/164907:WARNING:ipc_message_attachment_set.cc(57)] MessageAttachmentSet destroyed with unconsumed descriptors: 0/1
[1636:1287:0302/164908:INFO:CONSOLE(0)] "[SUCCESS] recordUserAction", source: chrome-extension://danlodiebfiaeldoidcganghbmobkaib/_generated_background_page.html (0)
[1636:1287:0302/164908:INFO:CONSOLE(0)] "[SUCCESS] recordValue", source: chrome-extension://danlodiebfiaeldoidcganghbmobkaib/_generated_background_page.html (0)
[1636:1287:0302/164908:INFO:CONSOLE(0)] "[SUCCESS] recordSparseValue", source: chrome-extension://danlodiebfiaeldoidcganghbmobkaib/_generated_background_page.html (0)
[1636:1287:0302/164908:INFO:CONSOLE(0)] "[SUCCESS] recordTimes", source: chrome-extension://danlodiebfiaeldoidcganghbmobkaib/_generated_background_page.html (0)
[1636:1287:0302/164908:INFO:CONSOLE(0)] "[SUCCESS] recordCounts", source: chrome-extension://danlodiebfiaeldoidcganghbmobkaib/_generated_background_page.html (0)
[1636:1287:0302/164908:INFO:CONSOLE(0)] "[SUCCESS] getFieldTrial", source: chrome-extension://danlodiebfiaeldoidcganghbmobkaib/_generated_background_page.html (0)
[1636:1287:0302/164908:INFO:CONSOLE(0)] "[SUCCESS] getVariationParams1", source: chrome-extension://danlodiebfiaeldoidcganghbmobkaib/_generated_background_page.html (0)
[1636:1287:0302/164908:INFO:CONSOLE(0)] "[SUCCESS] getVariationParams2", source: chrome-extension://danlodiebfiaeldoidcganghbmobkaib/_generated_background_page.html (0)
[1636:1287:0302/164908:FATAL:histogram.cc(253)] Check failed: histogram.
0   browser_tests                       0x0000000104c91443 _ZN4base5debug10StackTraceC1Ev + 19
1   browser_tests                       0x0000000104ca7cb9 _ZN7logging10LogMessageD2Ev + 73
2   browser_tests                       0x0000000104cb45b3 _ZN4base9Histogram7Factory5BuildEv + 483
3   browser_tests                       0x0000000104cb5f88 _ZN4base15LinearHistogram10FactoryGetERKNSt3__112basic_stringIcNS1_11char_traitsIcEENS1_9allocatorIcEEEEiiji + 104
4   browser_tests                       0x00000001088e95f4 _ZN10extensions30MetricsHistogramHelperFunction11RecordValueERKNSt3__112basic_stringIcNS1_11char_traitsIcEENS1_9allocatorIcEEEEN4base13HistogramTypeEiimi + 148
5   browser_tests                       0x00000001088e96cd _ZN10extensions33MetricsPrivateRecordValueFunction7RunSyncEv + 173
6   browser_tests                       0x000000010875fb21 _ZN21SyncExtensionFunction3RunEv + 33
7   browser_tests                       0x00000001087614e8 _ZN10extensions27ExtensionFunctionDispatcher28DispatchWithCallbackInternalERK31ExtensionHostMsg_Request_ParamsPN7content15RenderFrameHostERKN4base8CallbackIFvN17ExtensionFunction12ResponseTypeERKNS7_9ListValueERKNSt3__112basic_stringIcNSE_11char_traitsIcEENSE_9allocatorIcEEEENS_9functions14HistogramValueEEEE + 984
8   browser_tests                       0x0000000108760ff1 _ZN10extensions27ExtensionFunctionDispatcher8DispatchERK31ExtensionHostMsg_Request_ParamsPN7content15RenderFrameHostE + 497
9   browser_tests                       0x0000000108779f87 _ZN10extensions28ExtensionWebContentsObserver17OnMessageReceivedERKN3IPC7MessageEPN7content15RenderFrameHostE + 151
10  browser_tests                       0x000000010894c192 _ZN10extensions34ChromeExtensionWebContentsObserver17OnMessageReceivedERKN3IPC7MessageEPN7content15RenderFrameHostE + 34
11  browser_tests                       0x00000001082b4054 _ZN7content15WebContentsImpl17OnMessageReceivedEPNS_14RenderViewHostEPNS_15RenderFrameHostERKN3IPC7MessageE + 436
12  browser_tests                       0x00000001080a0c03 _ZN7content19RenderFrameHostImpl17OnMessageReceivedERKN3IPC7MessageE + 227
13  browser_tests                       0x00000001081e3349 _ZN7content21RenderProcessHostImpl17OnMessageReceivedERKN3IPC7MessageE + 1033
14  browser_tests                       0x0000000105d15318 _ZN3IPC12ChannelProxy7Context17OnDispatchMessageERKNS_7MessageE + 120
 
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfbec0cfb2d25d36b67bd297ebea4a622a4faa74

commit cfbec0cfb2d25d36b67bd297ebea4a622a4faa74
Author: dimich <dimich@chromium.org>
Date: Thu Mar 03 01:15:18 2016

Revert of Collect information about failing histogram factory calls. (patchset #2 id:40001 of https://codereview.chromium.org/1719363002/ )

Reason for revert:
Breaks at least one test: https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/17129

BUG= 591580 

Original issue's description:
> Collect information about failing histogram factory calls.
>
> BUG=588946
>
> Committed: https://crrev.com/fdc36c10667c4f6d5f4d9f391733774ae24666ce
> Cr-Commit-Position: refs/heads/master@{#378884}

TBR=asvitkine@chromium.org,bcwhite@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=588946

Review URL: https://codereview.chromium.org/1758993002

Cr-Commit-Position: refs/heads/master@{#378903}

[modify] https://crrev.com/cfbec0cfb2d25d36b67bd297ebea4a622a4faa74/base/metrics/histogram.cc
[modify] https://crrev.com/cfbec0cfb2d25d36b67bd297ebea4a622a4faa74/base/metrics/histogram_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment