New issue
Advanced search Search tips

Issue 591575 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
EstimatedDays: ----
NextAction: ----
OS: Linux , Android
Pri: 2
Type: Bug

Blocking:
issue 597791



Sign in to add a comment

Allow downloading whole page for Blimp.

Project Member Reported by anandc@chromium.org, Mar 3 2016

Issue description

In order to obtain meaningful test numbers, we should have a way to download the whole page when browsing with Blimp.

 

Comment 1 by anandc@chromium.org, Mar 15 2016

Owner: dtrainor@chromium.org
Labels: OS-Android
Owner: khushals...@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2da2b2322423c358333c95f017539d835f677884

commit 2da2b2322423c358333c95f017539d835f677884
Author: khushalsagar <khushalsagar@chromium.org>
Date: Wed Mar 23 22:11:35 2016

content: Make record_whole_document available for all platforms.

Move record_whole_document in WebPreferences from OS_ANDROID to all platforms. This will be used on the blimp engine to record the whole page rather than just the interest rect.

BUG=  591575 

Review URL: https://codereview.chromium.org/1808363002

Cr-Commit-Position: refs/heads/master@{#382937}

[modify] https://crrev.com/2da2b2322423c358333c95f017539d835f677884/content/public/common/common_param_traits_macros.h
[modify] https://crrev.com/2da2b2322423c358333c95f017539d835f677884/content/public/common/web_preferences.cc
[modify] https://crrev.com/2da2b2322423c358333c95f017539d835f677884/content/public/common/web_preferences.h
[modify] https://crrev.com/2da2b2322423c358333c95f017539d835f677884/content/renderer/render_view_impl.cc

Comment 4 by amin...@google.com, Mar 24 2016

Components: Mobile>Blimp
Labels: -Proj-Blimp

Comment 5 by amin...@google.com, Mar 24 2016

Blocking: 597791

Comment 6 by klo...@chromium.org, Mar 28 2016

Status: Fixed (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00c406052433085e22fa4f73d990c8e4ff3320b3

commit 00c406052433085e22fa4f73d990c8e4ff3320b3
Author: khushalsagar <khushalsagar@chromium.org>
Date: Mon Mar 28 20:00:29 2016

blimp: Add settings to allow the client to download the whole page.

- Add a settings feature to allow the engine and client to send global
  settings flags
- Add a switch on the client to request the whole document.

BUG= 591575 

Review URL: https://codereview.chromium.org/1810213009

Cr-Commit-Position: refs/heads/master@{#383547}

[modify] https://crrev.com/00c406052433085e22fa4f73d990c8e4ff3320b3/blimp/client/BUILD.gn
[modify] https://crrev.com/00c406052433085e22fa4f73d990c8e4ff3320b3/blimp/client/app/blimp_client_switches.cc
[modify] https://crrev.com/00c406052433085e22fa4f73d990c8e4ff3320b3/blimp/client/app/blimp_client_switches.h
[add] https://crrev.com/00c406052433085e22fa4f73d990c8e4ff3320b3/blimp/client/feature/settings_feature.cc
[add] https://crrev.com/00c406052433085e22fa4f73d990c8e4ff3320b3/blimp/client/feature/settings_feature.h
[modify] https://crrev.com/00c406052433085e22fa4f73d990c8e4ff3320b3/blimp/client/session/blimp_client_session.cc
[modify] https://crrev.com/00c406052433085e22fa4f73d990c8e4ff3320b3/blimp/client/session/blimp_client_session.h
[modify] https://crrev.com/00c406052433085e22fa4f73d990c8e4ff3320b3/blimp/common/create_blimp_message.cc
[modify] https://crrev.com/00c406052433085e22fa4f73d990c8e4ff3320b3/blimp/common/create_blimp_message.h
[modify] https://crrev.com/00c406052433085e22fa4f73d990c8e4ff3320b3/blimp/common/create_blimp_message_unittest.cc
[modify] https://crrev.com/00c406052433085e22fa4f73d990c8e4ff3320b3/blimp/common/proto/BUILD.gn
[modify] https://crrev.com/00c406052433085e22fa4f73d990c8e4ff3320b3/blimp/common/proto/blimp_message.proto
[add] https://crrev.com/00c406052433085e22fa4f73d990c8e4ff3320b3/blimp/common/proto/settings.proto
[modify] https://crrev.com/00c406052433085e22fa4f73d990c8e4ff3320b3/blimp/engine/BUILD.gn
[modify] https://crrev.com/00c406052433085e22fa4f73d990c8e4ff3320b3/blimp/engine/app/blimp_browser_main_parts.cc
[modify] https://crrev.com/00c406052433085e22fa4f73d990c8e4ff3320b3/blimp/engine/app/blimp_browser_main_parts.h
[modify] https://crrev.com/00c406052433085e22fa4f73d990c8e4ff3320b3/blimp/engine/app/blimp_content_browser_client.cc
[modify] https://crrev.com/00c406052433085e22fa4f73d990c8e4ff3320b3/blimp/engine/app/blimp_content_browser_client.h
[add] https://crrev.com/00c406052433085e22fa4f73d990c8e4ff3320b3/blimp/engine/app/engine_settings.cc
[add] https://crrev.com/00c406052433085e22fa4f73d990c8e4ff3320b3/blimp/engine/app/engine_settings.h
[add] https://crrev.com/00c406052433085e22fa4f73d990c8e4ff3320b3/blimp/engine/app/settings_manager.cc
[add] https://crrev.com/00c406052433085e22fa4f73d990c8e4ff3320b3/blimp/engine/app/settings_manager.h
[add] https://crrev.com/00c406052433085e22fa4f73d990c8e4ff3320b3/blimp/engine/app/settings_manager_unittest.cc
[modify] https://crrev.com/00c406052433085e22fa4f73d990c8e4ff3320b3/blimp/engine/feature/engine_render_widget_feature.cc
[modify] https://crrev.com/00c406052433085e22fa4f73d990c8e4ff3320b3/blimp/engine/feature/engine_render_widget_feature.h
[modify] https://crrev.com/00c406052433085e22fa4f73d990c8e4ff3320b3/blimp/engine/feature/engine_render_widget_feature_unittest.cc
[add] https://crrev.com/00c406052433085e22fa4f73d990c8e4ff3320b3/blimp/engine/feature/engine_settings_feature.cc
[add] https://crrev.com/00c406052433085e22fa4f73d990c8e4ff3320b3/blimp/engine/feature/engine_settings_feature.h
[add] https://crrev.com/00c406052433085e22fa4f73d990c8e4ff3320b3/blimp/engine/feature/engine_settings_feature_unittest.cc
[modify] https://crrev.com/00c406052433085e22fa4f73d990c8e4ff3320b3/blimp/engine/session/blimp_engine_session.cc
[modify] https://crrev.com/00c406052433085e22fa4f73d990c8e4ff3320b3/blimp/engine/session/blimp_engine_session.h

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/498195618ff83fc35e096685d07a9f28cd6cadff

commit 498195618ff83fc35e096685d07a9f28cd6cadff
Author: wez <wez@chromium.org>
Date: Fri Apr 22 04:05:04 2016

Add pretty-printing for SETTINGS messages.

This was missed from issue 1810213009, which added them to the protocol.

BUG= 591575 

Review URL: https://codereview.chromium.org/1912983002

Cr-Commit-Position: refs/heads/master@{#389019}

[modify] https://crrev.com/498195618ff83fc35e096685d07a9f28cd6cadff/blimp/common/logging.cc
[modify] https://crrev.com/498195618ff83fc35e096685d07a9f28cd6cadff/blimp/common/logging_unittest.cc

Labels: Archive-Blimp

Sign in to add a comment