Add tests so that issue 590028 doesn't happen again.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd5c75db316b5fd049d5da855b8cedf15605f727 commit bd5c75db316b5fd049d5da855b8cedf15605f727 Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Mon Mar 07 20:16:48 2016 [Extension UI Views] Add tests for clicking the different message bubble buttons Add browser tests for clicking on the bubble's dismiss and action buttons, as well as for focus loss. Regression tests for bug 590028. BUG= 591572 TBR=sky@chromium.org (settings_api_bubble_helper_views.cc, reviewed by Finnur) Review URL: https://codereview.chromium.org/1768623002 Cr-Commit-Position: refs/heads/master@{#379627} [modify] https://crrev.com/bd5c75db316b5fd049d5da855b8cedf15605f727/chrome/browser/ui/extensions/extension_message_bubble_factory.cc [modify] https://crrev.com/bd5c75db316b5fd049d5da855b8cedf15605f727/chrome/browser/ui/extensions/extension_message_bubble_factory.h [modify] https://crrev.com/bd5c75db316b5fd049d5da855b8cedf15605f727/chrome/browser/ui/views/extensions/extension_message_bubble_view.cc [modify] https://crrev.com/bd5c75db316b5fd049d5da855b8cedf15605f727/chrome/browser/ui/views/extensions/extension_message_bubble_view.h [modify] https://crrev.com/bd5c75db316b5fd049d5da855b8cedf15605f727/chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc [modify] https://crrev.com/bd5c75db316b5fd049d5da855b8cedf15605f727/chrome/browser/ui/views/settings_api_bubble_helper_views.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b7f84c4bcbd0bf31ef4db0051f9c522f8094ce0 commit 2b7f84c4bcbd0bf31ef4db0051f9c522f8094ce0 Author: wfh <wfh@chromium.org> Date: Sat Mar 12 04:53:07 2016 Revert of [Extension UI Views] Add tests for clicking the different message bubble buttons (patchset #2 id:20001 of https://codereview.chromium.org/1768623002/ ) Reason for revert: this is breaking the win10 fyi bot see bug 594317 Original issue's description: > [Extension UI Views] Add tests for clicking the different message bubble buttons > > Add browser tests for clicking on the bubble's dismiss and action buttons, as > well as for focus loss. Regression tests for bug 590028. > > BUG= 591572 > TBR=sky@chromium.org (settings_api_bubble_helper_views.cc, reviewed by Finnur) > > Committed: https://crrev.com/bd5c75db316b5fd049d5da855b8cedf15605f727 > Cr-Commit-Position: refs/heads/master@{#379627} TBR=asargent@chromium.org,finnur@chromium.org,rdevlin.cronin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 591572 Review URL: https://codereview.chromium.org/1786933002 Cr-Commit-Position: refs/heads/master@{#380857} [modify] https://crrev.com/2b7f84c4bcbd0bf31ef4db0051f9c522f8094ce0/chrome/browser/ui/extensions/extension_message_bubble_factory.cc [modify] https://crrev.com/2b7f84c4bcbd0bf31ef4db0051f9c522f8094ce0/chrome/browser/ui/extensions/extension_message_bubble_factory.h [modify] https://crrev.com/2b7f84c4bcbd0bf31ef4db0051f9c522f8094ce0/chrome/browser/ui/views/extensions/extension_message_bubble_view.cc [modify] https://crrev.com/2b7f84c4bcbd0bf31ef4db0051f9c522f8094ce0/chrome/browser/ui/views/extensions/extension_message_bubble_view.h [modify] https://crrev.com/2b7f84c4bcbd0bf31ef4db0051f9c522f8094ce0/chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc [modify] https://crrev.com/2b7f84c4bcbd0bf31ef4db0051f9c522f8094ce0/chrome/browser/ui/views/settings_api_bubble_helper_views.cc
Comment 1 by bugdroid1@chromium.org
, Mar 7 2016