New issue
Advanced search Search tips

Issue 591571 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , All
Pri: 2
Type: Bug



Sign in to add a comment

Always use original decode for bilerp

Project Member Reported by vmp...@chromium.org, Mar 3 2016

Issue description

We can always use the original decode for bilerp even with a strict clip, since we can just return to skia a new image with it's width/height and offset adjusted from the original image (without copies).

 
Labels: OS-All
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09885a2c46ae80f2e07fce7858a52c0b45f4dbb7

commit 09885a2c46ae80f2e07fce7858a52c0b45f4dbb7
Author: vmpstr <vmpstr@chromium.org>
Date: Thu Mar 03 20:45:24 2016

cc: ImageDecodes: Always use original decode for bilerp.

Instead of extracting a subrect in case of scale, we can always use
the original decode since Skia will Do The Right Thing. That is, Skia
already implements a cheap subrect extraction if it needs to do it,
so there is no point in replicating this logic.

R=enne, ericrk
BUG= 591571 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1763793002

Cr-Commit-Position: refs/heads/master@{#379079}

[modify] https://crrev.com/09885a2c46ae80f2e07fce7858a52c0b45f4dbb7/cc/tiles/software_image_decode_controller.cc

Status: Fixed (was: Assigned)

Sign in to add a comment