New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 591568 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

FAFT update tests should be able to run without given a shellball

Project Member Reported by waihong@chromium.org, Mar 3 2016

Issue description

The FAFT update tests, aka suite:faft_lv5, require the shellball in the OS image be the same as the active firmware. Otherwise, after executing the shellball to AU, the active firmware will be overwritten to some other different version. It is not expected.

So these tests need to pass a shellball file as a parameter. This extra parameter prevents these tests running in the lab automatically. We should have a way to modify the existing shellball to replace its BIOS and EC images using the active ones. This way helps to make the shellball and active firmware like the same.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/28d82a8891126a067e243a5d9557beba70d0b669

commit 28d82a8891126a067e243a5d9557beba70d0b669
Author: Tom Wai-Hong Tam <waihong@chromium.org>
Date: Thu Mar 03 22:44:43 2016

FAFT: Support running firmware update tests without given a shellball

The firmware update tests require the shellball in the OS image be
the same as the active firmware. Otherwise, after executing the
shellball to AU, the active firmware will be overwritten to some
other different version. It is not expected.

So these tests need to pass a shellball file as a parameter. This
extra parameter prevents these tests running in the lab automatically

This change supports modifying the existing shellball to replace its
BIOS and EC images using the active ones. This way helps to make the
shellball and active firmware like the same.

BUG= chromium:591568 
TEST=Ran the modified firmware update tests on Cyan, both the cases:
 - not given a shellball;
 - given a shellball.

Change-Id: I319584d730afd574ac2acffda41fb8174945cd78
Reviewed-on: https://chromium-review.googlesource.com/330263
Commit-Ready: Wai-Hong Tam <waihong@chromium.org>
Tested-by: Wai-Hong Tam <waihong@chromium.org>
Reviewed-by: danny chan <dchan@chromium.org>

[modify] https://crrev.com/28d82a8891126a067e243a5d9557beba70d0b669/client/cros/faft/utils/firmware_updater.py
[modify] https://crrev.com/28d82a8891126a067e243a5d9557beba70d0b669/server/site_tests/firmware_UpdateFirmwareVersion/firmware_UpdateFirmwareVersion.py
[modify] https://crrev.com/28d82a8891126a067e243a5d9557beba70d0b669/server/site_tests/firmware_UpdateKernelSubkeyVersion/firmware_UpdateKernelSubkeyVersion.py
[modify] https://crrev.com/28d82a8891126a067e243a5d9557beba70d0b669/server/cros/faft/firmware_test.py
[modify] https://crrev.com/28d82a8891126a067e243a5d9557beba70d0b669/server/site_tests/firmware_UpdateFirmwareDataKeyVersion/firmware_UpdateFirmwareDataKeyVersion.py
[modify] https://crrev.com/28d82a8891126a067e243a5d9557beba70d0b669/client/cros/faft/rpc_functions.py

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5b8024a7af857cef72537c70cd6c9c1dc54f0134

commit 5b8024a7af857cef72537c70cd6c9c1dc54f0134
Author: Tom Wai-Hong Tam <waihong@chromium.org>
Date: Thu Mar 03 22:53:47 2016

FAFT: Add FAFT firmware update tests back to lab running suites

These tests support running without given an extra shellball argument.
Add them back to lab running suites.

BUG= chromium:591568 
TEST=None

Change-Id: I3d0b3295f38cc053951b7009f7064d0c8fe75d4e
Reviewed-on: https://chromium-review.googlesource.com/330264
Commit-Ready: Dan Shi <dshi@google.com>
Tested-by: Wai-Hong Tam <waihong@chromium.org>
Reviewed-by: Wai-Hong Tam <waihong@chromium.org>

[modify] https://crrev.com/5b8024a7af857cef72537c70cd6c9c1dc54f0134/server/site_tests/firmware_UpdateFirmwareDataKeyVersion/control
[modify] https://crrev.com/5b8024a7af857cef72537c70cd6c9c1dc54f0134/server/site_tests/firmware_UpdateKernelSubkeyVersion/control
[modify] https://crrev.com/5b8024a7af857cef72537c70cd6c9c1dc54f0134/server/site_tests/firmware_UpdateFirmwareVersion/control

Status: Fixed (was: Started)
Labels: VerifyIn-51
Labels: VerifyIn-52
Labels: VerifyIn-53
Labels: VerifyIn-54

Comment 8 by ka...@chromium.org, Aug 31 2016

Labels: Bulk-Verified
Status: Verified (was: Fixed)

Sign in to add a comment