New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 591567 link

Starred by 1 user
Status: Fixed
Owner:
█ apaci...@chromium.org
no longer active
Closed: Mar 2016
Cc:
btolsch@chromium.org
mfo...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Media Router] Text overlap with header when scrolled down

Project Member Reported by apaci...@chromium.org, Mar 3 2016 
This was introduced with the addition of the search field.

We currently don't take into account the search field height when determining positioning. The autoresizing work for the dialog would fix this (and the majority of our Mac issues), but in the meantime, we'll just have to update updateElementPositioning_() in the container to handle this.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acbfb0178f3a20e386ff2bb10d6af9faa17ca316

commit acbfb0178f3a20e386ff2bb10d6af9faa17ca316
Author: apacible <apacible@chromium.org>
Date: Thu Mar 03 23:17:58 2016

[Media Router] Take search input into account when updating element positioning.

This change fixes the following:
- the positioning and overlap issue with a long sink list
- ensure the search input always appears at the bottom of the dialog when not in filter mode

BUG= 591567 

Review URL: https://codereview.chromium.org/1761743003

Cr-Commit-Position: refs/heads/master@{#379132}

[modify] https://crrev.com/acbfb0178f3a20e386ff2bb10d6af9faa17ca316/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

Comment 2 by apaci...@chromium.org, Mar 4 2016

Status: Fixed (was: Assigned)

Comment 3 by dbbrooks@chromium.org, Mar 14 2016 

This isn't in M50. Do we want to try for a merge?

Comment 4 by dbbrooks@chromium.org, Mar 14 2016

Labels: M-50

Comment 5 by apaci...@chromium.org, Mar 14 2016 

The long term fix for this will be merged into M50 (crbug/508544).
►

Sign in to add a comment