New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 591559 link

Starred by 1 user
Status: Fixed
Owner:
█ r...@opera.com
NOT IN USE
Closed: Mar 2016
Cc:
style-bugs@google.com
chrome-perf-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Changing disabled attribute of <link> calls resolverChanged(FullStyleUpdate) twice

Reported by r...@opera.com, Mar 3 2016 
In LinkStyle::setDisabledState once via m_sheet->setDisabled() and once directly.
disabled.html
269 bytes View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e55b820ed9915e639871fbe83c9e49712d8e239

commit 6e55b820ed9915e639871fbe83c9e49712d8e239
Author: rune <rune@opera.com>
Date: Thu Mar 03 02:25:26 2016

Removed unnecessary resolverChanged call.

Changing disabled state of a stylesheet link caused active stylesheet
update to happen twice. Once from setDisabled() on the stylesheet and
once directly from LinkStyle::setDisabledState(). Removed the one
called directly from LinkStyle::setDisabledState.

R=esprehn@chromium.org
BUG= 591559 

Review URL: https://codereview.chromium.org/1761693002

Cr-Commit-Position: refs/heads/master@{#378922}

[modify] https://crrev.com/6e55b820ed9915e639871fbe83c9e49712d8e239/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp

Comment 2 by r...@opera.com, Mar 3 2016

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 3 2016

Labels: merge-merged-2666
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e55b820ed9915e639871fbe83c9e49712d8e239

commit 6e55b820ed9915e639871fbe83c9e49712d8e239
Author: rune <rune@opera.com>
Date: Thu Mar 03 02:25:26 2016

Removed unnecessary resolverChanged call.

Changing disabled state of a stylesheet link caused active stylesheet
update to happen twice. Once from setDisabled() on the stylesheet and
once directly from LinkStyle::setDisabledState(). Removed the one
called directly from LinkStyle::setDisabledState.

R=esprehn@chromium.org
BUG= 591559 

Review URL: https://codereview.chromium.org/1761693002

Cr-Commit-Position: refs/heads/master@{#378922}

[modify] https://crrev.com/6e55b820ed9915e639871fbe83c9e49712d8e239/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp
►

Sign in to add a comment