New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 591536 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 590829
issue 591995



Sign in to add a comment

Bisect should handle build failures fast.

Project Member Reported by robert...@chromium.org, Mar 2 2016

Issue description

Rather than timing out waiting for the built image to be uploaded, we should query buildbot and if the build failed we should mark the revision and failed and proceed with the bisect if possible.
 
Blocking: 590829
Blocking: 591995
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/679db72df1a76c534e1ab622236b48b2c4b37841

commit 679db72df1a76c534e1ab622236b48b2c4b37841
Author: robertocn@chromium.org <robertocn@chromium.org>
Date: Tue Mar 22 22:38:46 2016

Checking for failure in requested builds.

When the bisect requests a build that fails, rather than time out waiting
for it, we now query buildbot and handle failures.

R=prasadv,qyearsley
BUG= 591536 

Review URL: https://codereview.chromium.org/1758603004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@299430 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/679db72df1a76c534e1ab622236b48b2c4b37841/scripts/slave/recipe_modules/auto_bisect/__init__.py
[modify] https://crrev.com/679db72df1a76c534e1ab622236b48b2c4b37841/scripts/slave/recipe_modules/auto_bisect/bisector.py
[modify] https://crrev.com/679db72df1a76c534e1ab622236b48b2c4b37841/scripts/slave/recipe_modules/auto_bisect/example.expected/android_arm64_bisector.json
[modify] https://crrev.com/679db72df1a76c534e1ab622236b48b2c4b37841/scripts/slave/recipe_modules/auto_bisect/example.expected/android_bisector.json
[modify] https://crrev.com/679db72df1a76c534e1ab622236b48b2c4b37841/scripts/slave/recipe_modules/auto_bisect/example.expected/basic.json
[modify] https://crrev.com/679db72df1a76c534e1ab622236b48b2c4b37841/scripts/slave/recipe_modules/auto_bisect/example.expected/basic_bisect_script.json
[add] https://crrev.com/679db72df1a76c534e1ab622236b48b2c4b37841/scripts/slave/recipe_modules/auto_bisect/example.expected/delayed_build_test.json
[modify] https://crrev.com/679db72df1a76c534e1ab622236b48b2c4b37841/scripts/slave/recipe_modules/auto_bisect/example.expected/failed_build_test.json
[modify] https://crrev.com/679db72df1a76c534e1ab622236b48b2c4b37841/scripts/slave/recipe_modules/auto_bisect/example.expected/failed_test.json
[modify] https://crrev.com/679db72df1a76c534e1ab622236b48b2c4b37841/scripts/slave/recipe_modules/auto_bisect/example.expected/mac_bisector.json
[modify] https://crrev.com/679db72df1a76c534e1ab622236b48b2c4b37841/scripts/slave/recipe_modules/auto_bisect/example.expected/missing_metric_test.json
[modify] https://crrev.com/679db72df1a76c534e1ab622236b48b2c4b37841/scripts/slave/recipe_modules/auto_bisect/example.expected/reversed_basic.json
[modify] https://crrev.com/679db72df1a76c534e1ab622236b48b2c4b37841/scripts/slave/recipe_modules/auto_bisect/example.expected/windows_bisector.json
[modify] https://crrev.com/679db72df1a76c534e1ab622236b48b2c4b37841/scripts/slave/recipe_modules/auto_bisect/example.expected/windows_x64_bisector.json
[modify] https://crrev.com/679db72df1a76c534e1ab622236b48b2c4b37841/scripts/slave/recipe_modules/auto_bisect/example.py
[modify] https://crrev.com/679db72df1a76c534e1ab622236b48b2c4b37841/scripts/slave/recipe_modules/auto_bisect/revision_state.py
[modify] https://crrev.com/679db72df1a76c534e1ab622236b48b2c4b37841/scripts/slave/recipes/bisect.expected/basic.json
[modify] https://crrev.com/679db72df1a76c534e1ab622236b48b2c4b37841/scripts/slave/recipes/bisect.expected/basic_return_code_test.json
[modify] https://crrev.com/679db72df1a76c534e1ab622236b48b2c4b37841/scripts/slave/recipes/bisect.expected/broken_bad_revision_test.json
[modify] https://crrev.com/679db72df1a76c534e1ab622236b48b2c4b37841/scripts/slave/recipes/bisect.expected/broken_good_revision_test.json
[modify] https://crrev.com/679db72df1a76c534e1ab622236b48b2c4b37841/scripts/slave/recipes/bisect.py
[modify] https://crrev.com/679db72df1a76c534e1ab622236b48b2c4b37841/scripts/slave/recipes/bisect_test/example_bisect_results.expected/aborted_non_telemetry_test.json
[modify] https://crrev.com/679db72df1a76c534e1ab622236b48b2c4b37841/scripts/slave/recipes/bisect_test/example_bisect_results.expected/basic_test.json
[modify] https://crrev.com/679db72df1a76c534e1ab622236b48b2c4b37841/scripts/slave/recipes/bisect_test/example_bisect_results.expected/deps_culprit_test.json
[modify] https://crrev.com/679db72df1a76c534e1ab622236b48b2c4b37841/scripts/slave/recipes/bisect_test/example_bisect_results.expected/failed_direction_test.json
[modify] https://crrev.com/679db72df1a76c534e1ab622236b48b2c4b37841/scripts/slave/recipes/bisect_test/example_bisect_results.expected/failed_test.json
[modify] https://crrev.com/679db72df1a76c534e1ab622236b48b2c4b37841/scripts/slave/recipes/bisect_test/example_bisect_results.py

Status: Fixed (was: Started)
Components: Speed>Bisection

Sign in to add a comment