New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 591530 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

.google.TLD post sign-in throttling is activated on NTP

Project Member Reported by zelidrag@chromium.org, Mar 2 2016

Issue description

Chrome Version       : 50.0.2657.0
OS Version: 7956.1.0

What steps will reproduce the problem?
1. Log in
2. Open NTP quickly after that

What is the expected result?

NTP loads

What happens instead of that?

Sing-in throttle shows - "Loading..."

We should see why NTP causes throttle to kick in here. Are there legit reasons for that now? Can we special-case NTP here without risking cookie jar collisions?


 
Cc: skuhne@chromium.org
Owner: afakhry@chromium.org
Possibly clobbered by changes a while back to limit the number of concurrent tab loads.
NTP pages shows google stuff (doodle, account picture etc). Not sure how it is implemented but I suspect there are traffics to google servers which triggers our MergeSessionLoadPage.

ShouldDelayUrl [1] might be a good start point to investigate. 

[1] https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/chromeos/login/signin/merge_session_throttling_utils.cc&rcl=1456936192&l=170
Cc: abodenha@chromium.org
What is the expected behavior? From what I understood from discussion with Xiyuan, this seems to be necessary to wait until the session is merged.
I think we should load NTP page from local resources only (just if we are offline) instead of blocking it on the signin throttle. It looks super weird that Chrome can't load its "internal" page for 5+ seconds...


Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96379036a48ce6ee82040597d5e9b930c21a7a3d

commit 96379036a48ce6ee82040597d5e9b930c21a7a3d
Author: afakhry <afakhry@chromium.org>
Date: Mon Apr 25 18:24:08 2016

Avoid the long merge session throttle interstitial page for NTP on Chrome OS

While the session is being merged, opening the NTP while cause the throttling
interstitial page to kick in, which can cause a delay in displaying the page for
5+ seconds. Instead we should force loading the local NTP until the merge session
is complete.

BUG= 591530 

Review URL: https://codereview.chromium.org/1910693002

Cr-Commit-Position: refs/heads/master@{#389514}

[modify] https://crrev.com/96379036a48ce6ee82040597d5e9b930c21a7a3d/chrome/browser/chromeos/login/signin/merge_session_navigation_throttle.cc
[modify] https://crrev.com/96379036a48ce6ee82040597d5e9b930c21a7a3d/chrome/browser/chromeos/login/signin/merge_session_resource_throttle.cc
[modify] https://crrev.com/96379036a48ce6ee82040597d5e9b930c21a7a3d/chrome/browser/chromeos/login/signin/merge_session_throttling_utils.cc
[modify] https://crrev.com/96379036a48ce6ee82040597d5e9b930c21a7a3d/chrome/browser/chromeos/login/signin/merge_session_throttling_utils.h
[modify] https://crrev.com/96379036a48ce6ee82040597d5e9b930c21a7a3d/chrome/browser/search/search.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 25 2016

Labels: merge-merged-2716
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96379036a48ce6ee82040597d5e9b930c21a7a3d

commit 96379036a48ce6ee82040597d5e9b930c21a7a3d
Author: afakhry <afakhry@chromium.org>
Date: Mon Apr 25 18:24:08 2016

Avoid the long merge session throttle interstitial page for NTP on Chrome OS

While the session is being merged, opening the NTP while cause the throttling
interstitial page to kick in, which can cause a delay in displaying the page for
5+ seconds. Instead we should force loading the local NTP until the merge session
is complete.

BUG= 591530 

Review URL: https://codereview.chromium.org/1910693002

Cr-Commit-Position: refs/heads/master@{#389514}

[modify] https://crrev.com/96379036a48ce6ee82040597d5e9b930c21a7a3d/chrome/browser/chromeos/login/signin/merge_session_navigation_throttle.cc
[modify] https://crrev.com/96379036a48ce6ee82040597d5e9b930c21a7a3d/chrome/browser/chromeos/login/signin/merge_session_resource_throttle.cc
[modify] https://crrev.com/96379036a48ce6ee82040597d5e9b930c21a7a3d/chrome/browser/chromeos/login/signin/merge_session_throttling_utils.cc
[modify] https://crrev.com/96379036a48ce6ee82040597d5e9b930c21a7a3d/chrome/browser/chromeos/login/signin/merge_session_throttling_utils.h
[modify] https://crrev.com/96379036a48ce6ee82040597d5e9b930c21a7a3d/chrome/browser/search/search.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
bulk verify (M50 clean up)

Sign in to add a comment