New issue
Advanced search Search tips

Issue 591513 link

Starred by 1 user
Status: Fixed
Owner:
rtoy@chromium.org
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Should().beEqualTo should print out quotes for strings

Project Member Reported by rtoy@chromium.org, Mar 2 2016 
For example, if p is a PannerNode,

Should("p.panningModel", p.panningModel).beEqualTo("equalpower");

the output is

p.panningModel is equal to equalpower.

I think it would be nice if the output was

p.panningModel is equal to "equalpower".

to emphasize that the expected value is the string "equalpower".

Comment 1 by rtoy@chromium.org, Apr 1 2016

Owner: rtoy@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/831c01709d57d362f0744bc30d75ede542f784bb

commit 831c01709d57d362f0744bc30d75ede542f784bb
Author: rtoy <rtoy@chromium.org>
Date: Tue Apr 19 00:09:19 2016

Include quotes when printing out strings from beEqualTo

In Should().beEqualTo print out quotes if the expected value is a
string.

Expected results updated for this change; there are otherwise no
changes to the tests themselves.

BUG= 591513 
TEST=none

Review URL: https://codereview.chromium.org/1855573002

Cr-Commit-Position: refs/heads/master@{#388089}

[modify] https://crrev.com/831c01709d57d362f0744bc30d75ede542f784bb/third_party/WebKit/LayoutTests/webaudio/audiochannelmerger-basic-expected.txt
[modify] https://crrev.com/831c01709d57d362f0744bc30d75ede542f784bb/third_party/WebKit/LayoutTests/webaudio/iirfilter-basic-expected.txt
[modify] https://crrev.com/831c01709d57d362f0744bc30d75ede542f784bb/third_party/WebKit/LayoutTests/webaudio/offlineaudiocontext-suspend-resume-eventhandler-expected.txt
[modify] https://crrev.com/831c01709d57d362f0744bc30d75ede542f784bb/third_party/WebKit/LayoutTests/webaudio/offlineaudiocontext-suspend-resume-promise-expected.txt
[modify] https://crrev.com/831c01709d57d362f0744bc30d75ede542f784bb/third_party/WebKit/LayoutTests/webaudio/oscillator-basic-expected.txt
[modify] https://crrev.com/831c01709d57d362f0744bc30d75ede542f784bb/third_party/WebKit/LayoutTests/webaudio/resources/audio-testing.js

Comment 3 by rtoy@chromium.org, Apr 19 2016

Status: Fixed (was: Started)
►

Sign in to add a comment