[Autofill] Fix heuristics to detect consecutive CVCs. |
|||
Issue descriptionA couple of sites seem to put multiple cvcs one after the other in their html. All but one of them is usually hidden. Now a cvc alone is not enough to label a field as a cvc. This is a problem because on some sites (eg. cvs.com) the on that is used is not the first, causing us to miss it.
,
Mar 15 2016
,
Apr 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0de6f5789e5b3524d36ef9a24a36ee78d24b4e22 commit 0de6f5789e5b3524d36ef9a24a36ee78d24b4e22 Author: Justin Donnelly <jdonnelly@chromium.org> Date: Mon Apr 04 19:14:10 2016 [Autofill] Fix heuristics to detect consecutive CVCs. Added a check after parsing a cvc. If it's the only type parsed so far, check the previous field. If it's also a cvc, just label the current field as a cvc without looking at the next fields. This also fixes some cases where we would label some names as cc-names. BUG= 591498 Review URL: https://codereview.chromium.org/1753253003 Cr-Commit-Position: refs/heads/master@{#380916} (cherry picked from commit a9224ac0cc140b536c8e13099fcf3cfc4cc4a80d) Review URL: https://codereview.chromium.org/1860613002 . Cr-Commit-Position: refs/branch-heads/2661@{#478} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/0de6f5789e5b3524d36ef9a24a36ee78d24b4e22/chrome/test/data/autofill/heuristics/output/117_cc_checkout_macys.com.out [modify] https://crrev.com/0de6f5789e5b3524d36ef9a24a36ee78d24b4e22/chrome/test/data/autofill/heuristics/output/118_checkout_cvs.com.out [modify] https://crrev.com/0de6f5789e5b3524d36ef9a24a36ee78d24b4e22/components/autofill/core/browser/credit_card_field.cc [modify] https://crrev.com/0de6f5789e5b3524d36ef9a24a36ee78d24b4e22/components/autofill/core/browser/credit_card_field.h [modify] https://crrev.com/0de6f5789e5b3524d36ef9a24a36ee78d24b4e22/components/autofill/core/browser/credit_card_field_unittest.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Mar 14 2016